walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Merge pull request #765 from Dmitry-Me/checkFormatBeforeSplitting 

Check string has expected format before processing it
This commit is contained in:
orbitcowboy 2016-01-20 15:07:28 +01:00
parent 2484a29916 58541f7ffa
commit ad01a89e05
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/errorlogger.cpp
View File

@ -181,9 +181,13 @@ bool ErrorLogger::ErrorMessage::deserialize(const std::string &data)
temp.append(1, c); temp.append(1, c);
} }
const std::string::size_type colonPos = temp.find(':');
if (colonPos == std::string::npos)
throw InternalError(0, "Internal Error: No colon found in <filename:line> pattern");
ErrorLogger::ErrorMessage::FileLocation loc; ErrorLogger::ErrorMessage::FileLocation loc;
loc.setfile(temp.substr(temp.find(':') + 1)); loc.setfile(temp.substr(colonPos + 1));
temp = temp.substr(0, temp.find(':')); temp = temp.substr(0, colonPos);
std::istringstream fiss(temp); std::istringstream fiss(temp);
fiss >> loc.line; fiss >> loc.line;