walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #583 (False positive: the nullpointer check doesn't handle goto properly)

This commit is contained in:
Daniel Marjamäki 2009-08-12 18:54:52 +02:00
parent 4c32057180
commit ad4ea01750
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/checkother.cpp
View File

@ -1130,6 +1130,10 @@ void CheckOther::nullPointer()
--indentlevel2;
}
// goto destination..
else if (tok2->isName() && Token::simpleMatch(tok2->next(), ":"))
break;
// Reassignment of the struct
else if (tok2->varId() == varid1)
{
@ -1194,6 +1198,10 @@ void CheckOther::nullPointer()
else if (tok1->str() == "{" ||
tok1->str() == "}")
break;
// goto destination..
else if (tok1->isName() && Token::simpleMatch(tok1->next(), ":"))
break;
}
}
}

9
test/testother.cpp
View File

@ -532,6 +532,15 @@ private:
"}\n");
ASSERT_EQUALS("", errout.str());
checkNullPointer("void foo(struct ABC *abc)\n"
"{\n"
" int *a = abc->a;\n"
"out:\n"
" if (!abc)\n"
" ;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
// loops..
checkNullPointer("void freeAbc(struct ABC *abc)\n"
"{\n"