Fixed #3939: Support ****foo++;

lib/checkother.cpp

@@ -238,11 +238,18 @@ void CheckOther::clarifyStatement()
         return;
 
     for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) {
-        if (Token::Match(tok, "[{};] * %var%")) {
+        if (Token::Match(tok, "* %var%")) {
-            tok = tok->tokAt(3);
+            const Token *tok2=tok->previous();
+
+            while (Token::Match(tok2, "*"))
+                tok2=tok2->previous();
+
+            if (Token::Match(tok2, "[{};]")) {
+                tok = tok->tokAt(2);
                 while (tok) {
                     if (tok->str() == "[")
                         tok = tok->link()->next();
+
                     if (Token::Match(tok, ".|:: %var%")) {
                         if (tok->strAt(2) == "(")
                             tok = tok->linkAt(2)->next();
@@ -256,6 +263,7 @@ void CheckOther::clarifyStatement()
             }
         }
     }
+}
 
 void CheckOther::clarifyStatementError(const Token *tok)
 {

test/testother.cpp

@@ -4040,6 +4040,29 @@ private:
               "    bar(*c++);\n"
               "}");
         ASSERT_EQUALS("", errout.str());
+
+        check("char*** f(char*** c) {\n"
+              "    ***c++;\n"
+              "    return c;\n"
+              "}");
+        ASSERT_EQUALS("[test.cpp:2]: (warning) Ineffective statement similar to '*A++;'. Did you intend to write '(*A)++;'?\n", errout.str());
+
+        check("char** f(char*** c) {\n"
+              "    **c[5]--;\n"
+              "    return **c;\n"
+              "}");
+        ASSERT_EQUALS("[test.cpp:2]: (warning) Ineffective statement similar to '*A++;'. Did you intend to write '(*A)++;'?\n", errout.str());
+
+        check("char*** f(char*** c) {\n"
+              "    (***c)++;\n"
+              "    return c;\n"
+              "}");
+        ASSERT_EQUALS("", errout.str());
+
+        check("void *f(char** c) {\n"
+              "    bar(**c++);\n"
+              "}");
+        ASSERT_EQUALS("", errout.str());
     }
 
     // clarify conditions with = and comparison