walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

add support for checking unused std::string local variables

This commit is contained in:
Robert Reif 2011-07-02 19:25:10 -04:00
parent 6800f801c6
commit b32b2c6d87
2 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/checkother.cpp
View File

@ -1769,6 +1769,22 @@ void CheckOther::functionVariableUsage()
tok = tok->next(); tok = tok->next();
} }
// std::string declaration with possible initialization
// std::string s; std::string s = "string";
else if (Token::Match(tok, "[;{}] static| std :: string %var% ;|="))
{
tok = tok->next();
const bool isStatic = tok->str() == "static";
if (isStatic)
tok = tok->next();
tok = tok->tokAt(3);
variables.addVar(tok, Variables::standard, info,
tok->next()->str() == "=" || isStatic);
tok = tok->next();
}
// standard struct type declaration with possible initialization // standard struct type declaration with possible initialization
// struct S s; struct S s = { 0 }; static struct S s; // struct S s; struct S s = { 0 }; static struct S s;
else if (Token::Match(tok, "[;{}] static| struct %type% %var% ;|=") && else if (Token::Match(tok, "[;{}] static| struct %type% %var% ;|=") &&

32
test/testunusedvar.cpp
View File

@ -98,6 +98,7 @@ private:
TEST_CASE(localvarstatic); TEST_CASE(localvarstatic);
TEST_CASE(localvardynamic); TEST_CASE(localvardynamic);
TEST_CASE(localvararray1); // ticket #2780 TEST_CASE(localvararray1); // ticket #2780
TEST_CASE(localvarstring);
// Don't give false positives for variables in structs/unions // Don't give false positives for variables in structs/unions
TEST_CASE(localvarStruct1); TEST_CASE(localvarStruct1);
@ -2781,6 +2782,37 @@ private:
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void localvarstring() // ticket #1597
{
functionVariableUsage("void foo() {\n"
" std::string s;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2]: (style) Unused variable: s\n", errout.str());
functionVariableUsage("void foo() {\n"
" std::string s;\n"
" s = \"foo\";\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2]: (style) Variable 's' is assigned a value that is never used\n", errout.str());
functionVariableUsage("void foo() {\n"
" std::string s = \"foo\";\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2]: (style) Variable 's' is assigned a value that is never used\n", errout.str());
functionVariableUsage("std::string foo() {\n"
" std::string s;\n"
" return s;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2]: (style) Variable 's' is not assigned a value\n", errout.str());
functionVariableUsage("std::string foo() {\n"
" std::string s = \"foo\";\n"
" return s;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
}; };
REGISTER_TEST(TestUnusedVar) REGISTER_TEST(TestUnusedVar)