iwyu.yml: use `debian:unstable` to always get latest include-what-you-use / cleaned up includes (#4466)

* iwyu.yml: use debian:unstable to always get latest include-what-you-use

* cleaned up includes based on include-what-you-use

* mitigated include-what-you-use false positives

.github/workflows/iwyu.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-22.04
 
     container:
-      image: "kalilinux/kali-rolling"
+      image: "debian:unstable" # use latest debian image to get latest include-what-you-get
 
     steps:
       - uses: actions/checkout@v2

cli/cmdlineparser.cpp

@@ -40,7 +40,7 @@
 #include <iostream>
 #include <list>
 #include <set>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <utility>
 
 #ifdef HAVE_RULES

cli/cppcheckexecutor.cpp

@@ -48,7 +48,7 @@
 #include <iostream>
 #include <list>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <utility>
 #include <vector>
 

cli/cppcheckexecutorseh.h

@@ -19,7 +19,7 @@
 #ifndef CPPCHECKEXECUTORSEH_H
 #define CPPCHECKEXECUTORSEH_H
 
-#include "config.h"
+#include "config.h" // IWYU pragma: keep
 
 #ifdef USE_WINDOWS_SEH
 

cli/processexecutor.cpp

@@ -39,7 +39,7 @@
 #include <functional>
 #include <iostream>
 #include <list>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <sys/select.h>
 #include <sys/wait.h>
 #include <unistd.h>

gui/application.cpp

@@ -18,6 +18,8 @@
 
 #include "application.h"
 
+#include <utility>
+
 Application::Application(QString name, QString path,
                          QString params)
     : mName(std::move(name))

gui/cppchecklibrarydata.cpp

@@ -19,6 +19,7 @@
 #include "cppchecklibrarydata.h"
 
 #include <stdexcept>
+#include <string>
 
 #include <QXmlStreamReader>
 #include <QVariant>

gui/erroritem.h

@@ -20,6 +20,7 @@
 #define ERRORITEM_H
 
 #include "errorlogger.h"
+#include "errortypes.h"
 
 #include <QList>
 #include <QMetaType>

gui/projectfile.h

@@ -24,6 +24,7 @@
 
 #include <cstddef>
 #include <map>
+#include <utility>
 
 #include <QObject>
 #include <QString>

gui/report.cpp

@@ -18,6 +18,8 @@
 
 #include "report.h"
 
+#include <utility>
+
 Report::Report(QString filename) :
     QObject(),
     mFilename(std::move(filename))

gui/resultstree.cpp

@@ -21,6 +21,7 @@
 #include "application.h"
 #include "applicationlist.h"
 #include "common.h"
+#include "config.h"
 #include "erroritem.h"
 #include "path.h"
 #include "projectfile.h"

lib/astutils.cpp

@@ -34,6 +34,7 @@
 #include "checkclass.h"
 
 #include <algorithm>
+#include <cassert>
 #include <functional>
 #include <initializer_list>
 #include <iterator>

lib/check.cpp

@@ -28,6 +28,7 @@
 
 #include <cctype>
 #include <iostream>
+#include <utility>
 
 //---------------------------------------------------------------------------
 

lib/checkcondition.cpp

@@ -37,7 +37,6 @@
 #include <limits>
 #include <list>
 #include <memory>
-#include <ostream>
 #include <set>
 #include <sstream>
 #include <utility>

lib/checkfunctions.cpp

@@ -31,7 +31,6 @@
 #include "valueflow.h"
 
 #include <iomanip>
-#include <ostream>
 #include <sstream>
 #include <unordered_map>
 #include <vector>

lib/checkio.cpp

@@ -35,7 +35,7 @@
 #include <map>
 #include <memory>
 #include <set>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <unordered_set>
 #include <utility>
 #include <vector>

lib/checkother.cpp

@@ -39,7 +39,6 @@
 #include <list>
 #include <map>
 #include <memory>
-#include <ostream>
 #include <set>
 #include <sstream>
 #include <utility>

lib/checktype.cpp

@@ -31,7 +31,6 @@
 
 #include <cmath>
 #include <list>
-#include <ostream>
 #include <sstream>
 #include <vector>
 

lib/checkunusedfunctions.cpp

@@ -34,9 +34,8 @@
 #include <cctype>
 #include <cstdlib>
 #include <cstring>
-#include <istream>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <utility>
 #include <vector>
 

lib/checkvaarg.cpp

@@ -26,7 +26,6 @@
 #include "tokenize.h"
 
 #include <cstddef>
-#include <list>
 #include <vector>
 
 //---------------------------------------------------------------------------

lib/clangimport.cpp

@@ -37,7 +37,7 @@
 #include <map>
 #include <memory>
 #include <set>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <stack>
 #include <string>
 #include <utility>

lib/cppcheck.cpp

@@ -49,7 +49,7 @@
 #include <memory>
 #include <new>
 #include <set>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <stdexcept>
 #include <string>
 #include <utility>

lib/ctu.cpp

@@ -33,7 +33,6 @@
 #include <cstdint>
 #include <cstring>
 #include <iterator>  // back_inserter
-#include <ostream>
 #include <sstream>
 #include <utility>
 

lib/errorlogger.cpp

@@ -33,7 +33,7 @@
 #include <cstring>
 #include <iomanip>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 

lib/importproject.cpp

@@ -32,7 +32,7 @@
 #include <fstream> // IWYU pragma: keep
 #include <iostream>
 #include <iterator>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <utility>
 
 #include <tinyxml2.h>

lib/library.cpp

@@ -31,10 +31,9 @@
 #include <climits>
 #include <cstdlib>
 #include <cstring>
-#include <iosfwd>
 #include <list>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <stack>
 #include <string>
 

lib/path.cpp

@@ -19,12 +19,14 @@
 #if defined(__GNUC__) && (defined(_WIN32) || defined(__CYGWIN__))
 #undef __STRICT_ANSI__
 #endif
+
 #include "path.h"
 #include "utils.h"
 
 #include <algorithm>
 #include <cstdlib>
 #include <fstream>
+#include <utility>
 
 #ifndef _WIN32
 #include <unistd.h>

lib/preprocessor.cpp

@@ -31,7 +31,7 @@
 #include <cstddef>
 #include <iterator> // back_inserter
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <utility>
 
 #include <simplecpp.h>

lib/summaries.cpp

@@ -26,9 +26,10 @@
 #include "tokenlist.h"
 
 #include <algorithm>
-#include <fstream>
+#include <fstream> // IWYU pragma: keep
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
+#include <utility>
 #include <vector>
 
 

lib/suppressions.cpp

@@ -31,7 +31,8 @@
 #include <cstdlib>
 #include <cstring>
 #include <functional> // std::bind, std::placeholders
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
+#include <utility>
 
 #include <tinyxml2.h>
 

lib/symboldatabase.cpp

@@ -41,7 +41,7 @@
 #include <iomanip>
 #include <iostream>
 #include <limits>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <stack>
 #include <string>
 #include <type_traits>

lib/templatesimplifier.cpp

@@ -32,7 +32,7 @@
 #include <iostream>
 #include <map>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <stack>
 #include <utility>
 

lib/token.cpp

@@ -40,7 +40,7 @@
 #include <iterator>
 #include <map>
 #include <set>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <stack>
 #include <unordered_set>
 #include <utility>

lib/tokenize.cpp

@@ -44,7 +44,7 @@
 #include <exception>
 #include <memory>
 #include <set>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <stack>
 #include <stdexcept>
 #include <type_traits>

lib/tokenlist.cpp

@@ -31,7 +31,6 @@
 
 #include <algorithm>
 #include <cctype>
-#include <cstring>
 #include <exception>
 #include <functional>
 #include <utility>

lib/valueflow.cpp

@@ -105,7 +105,6 @@
 #include <array>
 #include <cassert>
 #include <climits>
-#include <cmath>
 #include <cstdlib>
 #include <cstring>
 #include <exception>

test/test64bit.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class Test64BitPortability : public TestFixture {
 public:

test/testassert.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 
 class TestAssert : public TestFixture {

test/testastutils.cpp

@@ -26,8 +26,7 @@
 #include "tokenlist.h"
 
 #include <cstring>
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestAstUtils : public TestFixture {
 public:

test/testautovariables.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestAutoVariables : public TestFixture {
 public:

test/testbool.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestBool : public TestFixture {
 public:

test/testboost.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestBoost : public TestFixture {
 public:

test/testbufferoverrun.cpp

@@ -28,10 +28,9 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <map>
 #include <list>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 #include <vector>

test/testcharvar.cpp

@@ -24,8 +24,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestCharVar : public TestFixture {
 public:

test/testclangimport.cpp

@@ -23,10 +23,9 @@
 #include "testsuite.h"
 
 #include <cstdint>
-#include <iosfwd>
 #include <list>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <vector>
 

test/testclass.cpp

@@ -24,9 +24,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <list>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <vector>
 

test/testcmdlineparser.cpp

@@ -27,6 +27,7 @@
 #include "testsuite.h"
 #include "timer.h"
 
+#include <cstdio>
 #include <list>
 #include <set>
 #include <string>

test/testcondition.cpp

@@ -25,9 +25,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 #include <vector>

test/testconstructors.cpp

@@ -24,9 +24,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <list>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 
 

test/testexceptionsafety.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestExceptionSafety : public TestFixture {
 public:

test/testfunctions.cpp

@@ -24,9 +24,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <list>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 
 #include <tinyxml2.h>

test/testgarbage.cpp

@@ -24,9 +24,8 @@
 #include "token.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <list>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 
 

test/testimportproject.cpp

@@ -20,11 +20,10 @@
 #include "settings.h"
 #include "testsuite.h"
 
-#include <iosfwd>
 #include <list>
 #include <memory>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <vector>
 

test/testincompletestatement.cpp

@@ -22,9 +22,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 #include <vector>

test/testio.cpp

@@ -25,8 +25,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 
 class TestIO : public TestFixture {

test/testleakautovar.cpp

@@ -24,9 +24,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 #include <vector>

test/testlibrary.cpp

@@ -26,9 +26,8 @@
 #include "tokenize.h"
 #include "tokenlist.h"
 
-#include <iosfwd>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <unordered_map>
 #include <vector>

test/testmemleak.cpp

@@ -24,10 +24,9 @@
 #include "token.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <list>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 
 class TestMemleakInClass;

test/testnullpointer.cpp

@@ -26,10 +26,9 @@
 #include "token.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <list>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <unordered_map>
 #include <utility>

test/testother.cpp

@@ -26,9 +26,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <unordered_map>
 #include <utility>

test/testpostfixoperator.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestPostfixOperator : public TestFixture {
 public:

test/testpreprocessor.cpp

@@ -30,12 +30,11 @@
 
 #include <atomic>
 #include <cstring>
-#include <iosfwd>
 #include <list>
 #include <map>
 #include <memory>
 #include <set>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <vector>
 

test/testprocessexecutor.cpp

@@ -21,11 +21,11 @@
 #include "settings.h"
 #include "testsuite.h"
 #include "testutils.h"
+#include "timer.h"
 
 #include <algorithm>
 #include <cstddef>
 #include <map>
-#include <ostream>
 #include <sstream>
 #include <string>
 #include <utility>

test/testsimplifytemplate.cpp

@@ -27,8 +27,7 @@
 #include "tokenlist.h"
 
 #include <cstring>
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 #include <vector>
 

test/testsimplifytokens.cpp

@@ -24,8 +24,7 @@
 #include "token.h"
 #include "tokenize.h"
 
-#include <istream>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 

test/testsimplifyusing.cpp

@@ -24,8 +24,7 @@
 #include "token.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 

test/testsizeof.cpp

@@ -22,9 +22,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 #include <vector>

test/teststl.cpp

@@ -24,8 +24,7 @@
 #include "tokenize.h"
 
 #include <cstddef>
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 

test/teststring.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 
 class TestString : public TestFixture {

test/testsummaries.cpp

@@ -22,8 +22,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 

test/testsuppressions.cpp

@@ -31,11 +31,10 @@
 #include <cstddef>
 #include <cstring>
 #include <functional>
-#include <iosfwd>
 #include <list>
 #include <map>
 #include <memory>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 #include <vector>

test/testthreadexecutor.cpp

@@ -21,11 +21,11 @@
 #include "testsuite.h"
 #include "testutils.h"
 #include "threadexecutor.h"
+#include "timer.h"
 
 #include <algorithm>
 #include <cstddef>
 #include <map>
-#include <ostream>
 #include <sstream>
 #include <string>
 #include <utility>

test/testtoken.cpp

@@ -25,8 +25,7 @@
 #include "valueflow.h"
 
 #include <algorithm>
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 #include <vector>
 

test/testtokenlist.cpp

@@ -21,8 +21,7 @@
 #include "token.h"
 #include "tokenlist.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 class TestTokenList : public TestFixture {

test/testtokenrange.cpp

@@ -27,7 +27,6 @@
 #include <algorithm>
 #include <iterator>
 #include <list>
-#include <ostream>
 #include <sstream>
 #include <string>
 

test/testtype.cpp

@@ -24,8 +24,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 class TestType : public TestFixture {

test/testunusedprivfunc.cpp

@@ -23,9 +23,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <map>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 #include <utility>
 #include <vector>

test/testunusedvar.cpp

@@ -23,9 +23,8 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
 #include <list>
-#include <sstream>
+#include <sstream> // IWYU pragma: keep
 #include <string>
 
 class TestUnusedVar : public TestFixture {

test/testutils.h

@@ -27,10 +27,8 @@
 #include "tokenlist.h"
 
 #include <cstdio>
-#include <iosfwd>
 #include <list>
-#include <ostream>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 class Token;

test/testvaarg.cpp

@@ -23,8 +23,7 @@
 #include "testsuite.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 
 class TestVaarg : public TestFixture {
 public:

test/testvalueflow.cpp

@@ -34,7 +34,6 @@
 #include <list>
 #include <map>
 #include <memory>
-#include <ostream>
 #include <set>
 #include <sstream>
 #include <string>

test/testvarid.cpp

@@ -24,8 +24,7 @@
 #include "token.h"
 #include "tokenize.h"
 
-#include <iosfwd>
+#include <sstream> // IWYU pragma: keep
-#include <sstream>
 #include <string>
 
 struct InternalError;