From b75d0665a761bc87351ff72ce7c0bc0652f9aa73 Mon Sep 17 00:00:00 2001
From: Georgy Komarov <jubnzv@gmail.com>
Date: Fri, 6 Nov 2020 11:40:44 +0300
Subject: [PATCH] qt.cfg: Add interfaces with new ignoredReturnErrorCode
 warnings (#2885)

* qt.cfg: Add interfaces with new ignoredReturnErrorCode warnings

* Tweak xmllint configuration
---
 cfg/cppcheck-cfg.rng |  8 +++++++-
 cfg/qt.cfg           | 13 +++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/cfg/cppcheck-cfg.rng b/cfg/cppcheck-cfg.rng
index cd79f5975..9c0bd6adc 100644
--- a/cfg/cppcheck-cfg.rng
+++ b/cfg/cppcheck-cfg.rng
@@ -116,7 +116,13 @@
             <element name="leak-ignore"><empty/></element>
           </optional>
           <optional>
-            <element name="use-retval"><empty/></element>
+            <element name="use-retval"><empty/>
+              <optional>
+                <attribute name="type">
+                    <value>error-code</value>
+                </attribute>
+              </optional>
+            </element>
           </optional>
           <optional>
             <element name="returnValue">
diff --git a/cfg/qt.cfg b/cfg/qt.cfg
index 191bc9434..4773b6a57 100644
--- a/cfg/qt.cfg
+++ b/cfg/qt.cfg
@@ -4590,6 +4590,17 @@
     <use-retval/>
     <const/>
   </function>
+  <!-- QSqlDatabase https://doc.qt.io/qt-5/qsqldatabase.html -->
+  <!-- bool QSqlDatabase::commit() -->
+  <!-- bool QSqlDatabase::rollback() -->
+  <!-- bool QSqlDatabase::open() -->
+  <!-- bool QSqlDatabase::transaction() -->
+  <function name="QSqlDatabase::commit,QSqlDatabase::rollback,QSqlDatabase::open,QSqlDatabase::transaction">
+    <noreturn>false</noreturn>
+    <returnValue type="bool"/>
+    <use-retval type="error-code"/>
+    <leak-ignore/>
+  </function>
   <!-- QSqlQuery https://doc.qt.io/qt-5/qsqlquery.html -->
   <!-- void QSqlQuery::addBindValue(const QVariant &val, QSql::ParamType paramType = QSql::In) -->
   <function name="QSqlQuery::addBindValue">
@@ -4665,6 +4676,7 @@
     <noreturn>false</noreturn>
     <returnValue type="bool"/>
     <leak-ignore/>
+    <use-retval type="error-code"/>
     <arg nr="1" direction="in" default="">
       <not-uninit/>
       <not-bool/>
@@ -4776,6 +4788,7 @@
     <noreturn>false</noreturn>
     <returnValue type="bool"/>
     <leak-ignore/>
+    <use-retval type="error-code"/>
     <arg nr="1" direction="in">
       <not-uninit/>
       <not-bool/>