From 54c445ca2001e67230ca7b8084141036dd73ea41 Mon Sep 17 00:00:00 2001
From: Benjamin Goose <gansb+github@tngtech.com>
Date: Fri, 4 Nov 2011 09:49:49 +0100
Subject: [PATCH] Add tests for various bugs.

False positive: uninitialized variable (ticket #3287).
False positive: null pointer dereference in typeid (ticket #3290).
---
 test/testnullpointer.cpp | 26 ++++++++++++++++++++++++++
 test/testuninitvar.cpp   |  9 +++++++++
 2 files changed, 35 insertions(+)

diff --git a/test/testnullpointer.cpp b/test/testnullpointer.cpp
index 7d0182a04..52f6141e8 100644
--- a/test/testnullpointer.cpp
+++ b/test/testnullpointer.cpp
@@ -55,6 +55,7 @@ private:
         TEST_CASE(printf_with_invalid_va_argument);
         TEST_CASE(scanf_with_invalid_va_argument);
         TEST_CASE(nullpointer_in_return);
+        TEST_CASE(nullpointer_in_typeid);
     }
 
     void check(const char code[], bool inconclusive = false, bool cpp11 = false) {
@@ -1550,6 +1551,31 @@ private:
               "}");
         ASSERT_EQUALS("", errout.str());
     }
+
+    void nullpointer_in_typeid() {
+        // Should throw std::bad_typeid
+        check("struct PolymorphicA { virtual ~A() {} };\n"
+              "bool foo() {\n"
+              "     PolymorphicA* a = 0;\n"
+              "     return typeid(*a) == typeid(*a);\n"
+              "}");
+        TODO_ASSERT_EQUALS("", "[test.cpp:4]: (error) Null pointer dereference\n", errout.str());
+
+        check("struct NonPolymorphicA { ~A() {} };\n"
+              "bool foo() {\n"
+              "     NonPolymorphicA* a = 0;\n"
+              "     return typeid(*a) == typeid(*a);\n"
+              "}");
+        TODO_ASSERT_EQUALS("", "[test.cpp:4]: (error) Null pointer dereference\n", errout.str());
+
+        check("bool foo() {\n"
+              "     char* c = 0;\n"
+              "     return typeid(*c) == typeid(*c);\n"
+              "}");
+        TODO_ASSERT_EQUALS("", "[test.cpp:3]: (error) Null pointer dereference\n", errout.str());
+
+    }
+
 };
 
 REGISTER_TEST(TestNullPointer)
diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
index 508cfce50..411a3f22d 100644
--- a/test/testuninitvar.cpp
+++ b/test/testuninitvar.cpp
@@ -895,6 +895,15 @@ private:
                        "    }\n"
                        "}");
         ASSERT_EQUALS("", errout.str());
+
+        // Assignment in for. Ticket #3287
+        checkUninitVar("int foo(char* in, bool b) {\n"
+                       "    char* c;\n"
+                       "    if (b) for (c = in; *c == 0; ++c) {}\n"
+                       "    else c = in + strlen(in) - 1;\n"
+                       "    *c = 0;\n"
+                       "}\n");
+        TODO_ASSERT_EQUALS("", "[test.cpp:5]: (error) Uninitialized variable: c\n", errout.str());
     }
 
     // switch..