From bacc5ac1ccf653c57c7618001157ed194b025938 Mon Sep 17 00:00:00 2001 From: Alexander Mai Date: Mon, 6 Apr 2015 18:16:37 +0200 Subject: [PATCH] Fix false positives ignoredReturnValue about some posix interfaces. Remove redundant strsignal() output from signal handler --- cfg/posix.cfg | 3 --- cli/cppcheckexecutor.cpp | 3 --- test/cfg/posix.c | 4 ++++ 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/cfg/posix.cfg b/cfg/posix.cfg index b95fda723..34c94b578 100644 --- a/cfg/posix.cfg +++ b/cfg/posix.cfg @@ -1695,7 +1695,6 @@ - false @@ -1708,7 +1707,6 @@ - false @@ -1721,7 +1719,6 @@ - false diff --git a/cli/cppcheckexecutor.cpp b/cli/cppcheckexecutor.cpp index 3c068911a..40614c6c5 100644 --- a/cli/cppcheckexecutor.cpp +++ b/cli/cppcheckexecutor.cpp @@ -346,14 +346,11 @@ static void CppcheckSignalHandler(int signo, siginfo_t * info, void * context) } #endif const char * const signame = signal_name(signo); - const char * const sigtext = strsignal(signo); bool bPrintCallstack=true; const bool isaddressonstack = isAddressOnStack(info->si_addr); FILE* f = (CppCheckExecutor::getExceptionOutput()=="stderr") ? stderr : stdout; fputs("Internal error: cppcheck received signal ", f); fputs(signame, f); - fputs(", ", f); - fputs(sigtext, f); switch (signo) { case SIGBUS: switch (info->si_code) { diff --git a/test/cfg/posix.c b/test/cfg/posix.c index dbe55a44e..14c7dfa2d 100644 --- a/test/cfg/posix.c +++ b/test/cfg/posix.c @@ -182,4 +182,8 @@ void timet_h() { struct timespec* ptp; // cppcheck-suppress uninitvar clock_settime(CLOCK_REALTIME, ptp); + + time_t clock = time(0); + char buf[26]; + ctime_r(&clock, buf); }