walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Merge pull request #426 from Dmitry-Me/moveDeclarationCloserToWhereItIsUsed 

Move declaration closer to where it is used
This commit is contained in:
Daniel Marjamäki 2014-09-11 09:36:01 +02:00
parent 865fc9aa67 e050fba414
commit bb0b4c2b4a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkbufferoverrun.cpp
View File

@ -1013,9 +1013,8 @@ void CheckBufferOverrun::checkGlobalAndLocalVariable()
// check all known fixed size arrays first by just looking them up // check all known fixed size arrays first by just looking them up
const SymbolDatabase* symbolDatabase = _tokenizer->getSymbolDatabase(); const SymbolDatabase* symbolDatabase = _tokenizer->getSymbolDatabase();
for (unsigned int i = 1; i <= _tokenizer->varIdCount(); i++) { for (unsigned int i = 1; i <= _tokenizer->varIdCount(); i++) {
const Variable *var = symbolDatabase->getVariableFromVarId(i); const Variable * const var = symbolDatabase->getVariableFromVarId(i);
if (var && var->isArray() && var->dimension(0) > 0) { if (var && var->isArray() && var->dimension(0) > 0) {
const ArrayInfo arrayInfo(var, _tokenizer, i);
const Token *tok = var->nameToken(); const Token *tok = var->nameToken();
while (tok && tok->str() != ";") { while (tok && tok->str() != ";") {
if (tok->str() == "{") { if (tok->str() == "{") {
@ -1030,6 +1029,7 @@ void CheckBufferOverrun::checkGlobalAndLocalVariable()
break; break;
if (tok->str() == "{") if (tok->str() == "{")
tok = tok->next(); tok = tok->next();
const ArrayInfo arrayInfo(var, _tokenizer, i);
checkScope(tok, arrayInfo); checkScope(tok, arrayInfo);
} }
} }