From be464b43b3a827343156167f62b9e4b4fc8d2ca2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Sun, 24 Jun 2012 15:38:37 +0200 Subject: [PATCH] Memory leaks: updated configuration handling. it's still not auto-tested. --- lib/checkleakautovar.cpp | 56 ++++++++++++++++++++++++++++++++++++++-- lib/checkleakautovar.h | 3 +++ 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/lib/checkleakautovar.cpp b/lib/checkleakautovar.cpp index 730b8cd47..e4d246d38 100644 --- a/lib/checkleakautovar.cpp +++ b/lib/checkleakautovar.cpp @@ -123,6 +123,48 @@ void CheckLeakAutoVar::parseConfigurationFile(const std::string &filename) pos1 = line.find_first_not_of(" ", pos2); } } + + else if (line.compare(0,7,"IGNORE ",0,7) == 0) { + std::string::size_type pos1 = line.find_first_not_of(" ", 7U); + while (pos1 < line.size()) { + std::string::size_type pos2 = line.find_first_of(" ", pos1); + std::string functionName; + if (pos2 == std::string::npos) + functionName = line.substr(pos1); + else + functionName = line.substr(pos1, pos2-pos1); + cfgignore.insert(functionName); + pos1 = line.find_first_not_of(" ", pos2); + } + } + + else if (line.compare(0,4,"USE ",0,4) == 0) { + std::string::size_type pos1 = line.find_first_not_of(" ", 4U); + while (pos1 < line.size()) { + std::string::size_type pos2 = line.find_first_of(" ", pos1); + std::string functionName; + if (pos2 == std::string::npos) + functionName = line.substr(pos1); + else + functionName = line.substr(pos1, pos2-pos1); + cfguse.insert(functionName); + pos1 = line.find_first_not_of(" ", pos2); + } + } + + else if (line.compare(0,9,"NORETURN ",0,9) == 0) { + std::string::size_type pos1 = line.find_first_not_of(" ", 9U); + while (pos1 < line.size()) { + std::string::size_type pos2 = line.find_first_of(" ", pos1); + std::string functionName; + if (pos2 == std::string::npos) + functionName = line.substr(pos1); + else + functionName = line.substr(pos1, pos2-pos1); + cfgnoreturn.insert(functionName); + pos1 = line.find_first_not_of(" ", pos2); + } + } } } @@ -383,10 +425,13 @@ void CheckLeakAutoVar::checkScope(const Token * const startToken, // Handle scopes that might be noreturn if (dealloc.empty() && Token::simpleMatch(tok, ") ; }")) { + const std::string &functionName(tok->link()->previous()->str()); bool unknown = false; - if (_tokenizer->IsScopeNoReturn(tok->tokAt(2), &unknown)) { + if (cfgignore.find(functionName) == cfgignore.end() && + cfguse.find(functionName) == cfguse.end() && + _tokenizer->IsScopeNoReturn(tok->tokAt(2), &unknown)) { if (unknown) { - const std::string &functionName(tok->link()->previous()->str()); + //const std::string &functionName(tok->link()->previous()->str()); varInfo->possibleUsageAll(functionName); } else { varInfo->clear(); @@ -410,6 +455,13 @@ void CheckLeakAutoVar::functionCall(const Token *tok, VarInfo *varInfo, const st std::map &alloctype = varInfo->alloctype; std::map &possibleUsage = varInfo->possibleUsage; + // Ignore function call? + const bool ignore = bool(cfgignore.find(tok->str()) != cfgignore.end()); + //const bool use = bool(cfguse.find(tok->str()) != cfguse.end()); + + if (ignore) + return; + for (const Token *arg = tok->tokAt(2); arg; arg = arg->nextArgument()) { if ((Token::Match(arg, "%var% [-,)]") && arg->varId() > 0) || (Token::Match(arg, "& %var%") && arg->next()->varId() > 0)) { diff --git a/lib/checkleakautovar.h b/lib/checkleakautovar.h index b8e68b1c2..ac6593d68 100644 --- a/lib/checkleakautovar.h +++ b/lib/checkleakautovar.h @@ -86,6 +86,9 @@ private: std::map cfgalloc; std::map cfgdealloc; + std::set cfgignore; + std::set cfguse; + std::set cfgnoreturn; void parseConfigurationFile(const std::string &filename);