walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix FP leakNoVarFunctionCall with passthrough returns (#3249)

This commit is contained in:
keinflue 2021-05-08 08:26:10 +00:00 committed by GitHub
parent be95e2bf21
commit bfa26b5a72
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkmemoryleak.cpp
View File

@ -996,7 +996,7 @@ void CheckMemoryLeakNoVar::checkForUnreleasedInputArgument(const Scope *scope)
const Token* tok2 = tok->next()->astParent(); const Token* tok2 = tok->next()->astParent();
while (tok2 && tok2->isCast()) while (tok2 && tok2->isCast())
tok2 = tok2->astParent(); tok2 = tok2->astParent();
if (tok2 && tok2->isAssignmentOp()) if (Token::Match(tok2, "%assign%|return"))
continue; continue;
const std::string& functionName = tok->str(); const std::string& functionName = tok->str();

5
test/testmemleak.cpp
View File

@ -2174,6 +2174,11 @@ private:
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("char *x() {\n"
" return strcpy(malloc(10), \"abc\");\n"
"}");
ASSERT_EQUALS("", errout.str());
check("void x() {\n" check("void x() {\n"
" free(malloc(10));\n" " free(malloc(10));\n"
"}"); "}");