walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

V817 It is more efficient to seek '\t' character rather than a string. errorlogger.cpp 448 (#1290) 

V817 It is more efficient to seek '}' character rather than a string. errorlogger.cpp 484
V817 It is more efficient to seek '\r' character rather than a string. errorlogger.cpp 497
V817 It is more efficient to seek '\r' character rather than a string. errorlogger.cpp 528
V817 It is more efficient to seek ';' character rather than a string. suppressions.cpp 187
V817 It is more efficient to seek ';' character rather than a string. suppressions.cpp 188

full log: http://www.fly-server.ru/pvs-studio/cppcheck/
This commit is contained in:
Pavel Pimenov 2018-06-17 17:39:28 +03:00 committed by Daniel Marjamäki
parent dbf89856c0
commit c25ab16f5d
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/errorlogger.cpp
View File

@ -445,7 +445,7 @@ static std::string readCode(const std::string &file, unsigned int linenr, unsign
if (endPos + 1 < line.size()) if (endPos + 1 < line.size())
line.erase(endPos + 1); line.erase(endPos + 1);
std::string::size_type pos = 0; std::string::size_type pos = 0;
while ((pos = line.find("\t", pos)) != std::string::npos) while ((pos = line.find('\t', pos)) != std::string::npos)
line[pos] = ' '; line[pos] = ' ';
return line + endl + std::string((column>0 ? column-1 : column), ' ') + '^'; return line + endl + std::string((column>0 ? column-1 : column), ' ') + '^';
} }
@ -481,7 +481,7 @@ std::string ErrorLogger::ErrorMessage::toString(bool verbose, const std::string
findAndReplace(result, "{id}", _id); findAndReplace(result, "{id}", _id);
if (result.find("{inconclusive:") != std::string::npos) { if (result.find("{inconclusive:") != std::string::npos) {
const std::string::size_type pos1 = result.find("{inconclusive:"); const std::string::size_type pos1 = result.find("{inconclusive:");
const std::string::size_type pos2 = result.find("}", pos1+1); const std::string::size_type pos2 = result.find('}', pos1+1);
const std::string replaceFrom = result.substr(pos1,pos2-pos1+1); const std::string replaceFrom = result.substr(pos1,pos2-pos1+1);
const std::string replaceWith = _inconclusive ? result.substr(pos1+14, pos2-pos1-14) : std::string(); const std::string replaceWith = _inconclusive ? result.substr(pos1+14, pos2-pos1-14) : std::string();
findAndReplace(result, replaceFrom, replaceWith); findAndReplace(result, replaceFrom, replaceWith);
@ -494,7 +494,7 @@ std::string ErrorLogger::ErrorMessage::toString(bool verbose, const std::string
findAndReplace(result, "{line}", MathLib::toString(_callStack.back().line)); findAndReplace(result, "{line}", MathLib::toString(_callStack.back().line));
findAndReplace(result, "{column}", MathLib::toString(_callStack.back().col)); findAndReplace(result, "{column}", MathLib::toString(_callStack.back().col));
if (result.find("{code}") != std::string::npos) { if (result.find("{code}") != std::string::npos) {
const std::string::size_type pos = result.find("\r"); const std::string::size_type pos = result.find('\r');
const char *endl; const char *endl;
if (pos == std::string::npos) if (pos == std::string::npos)
endl = "\n"; endl = "\n";
@ -525,7 +525,7 @@ std::string ErrorLogger::ErrorMessage::toString(bool verbose, const std::string
findAndReplace(text, "{column}", MathLib::toString(fileLocation.col)); findAndReplace(text, "{column}", MathLib::toString(fileLocation.col));
findAndReplace(text, "{info}", fileLocation.getinfo().empty() ? mShortMessage : fileLocation.getinfo()); findAndReplace(text, "{info}", fileLocation.getinfo().empty() ? mShortMessage : fileLocation.getinfo());
if (text.find("{code}") != std::string::npos) { if (text.find("{code}") != std::string::npos) {
const std::string::size_type pos = text.find("\r"); const std::string::size_type pos = text.find('\r');
const char *endl; const char *endl;
if (pos == std::string::npos) if (pos == std::string::npos)
endl = "\n"; endl = "\n";

4
lib/suppressions.cpp
View File

@ -184,8 +184,8 @@ bool Suppressions::Suppression::parseComment(std::string comment, std::string *e
if (comment.size() < 2) if (comment.size() < 2)
return false; return false;
if (comment.find(";") != std::string::npos) if (comment.find(';') != std::string::npos)
comment.erase(comment.find(";")); comment.erase(comment.find(';'));
if (comment.find("//", 2) != std::string::npos) if (comment.find("//", 2) != std::string::npos)
comment.erase(comment.find("//",2)); comment.erase(comment.find("//",2));