walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #6816 (FP: buffer overflow, checkminsizes of array with string value)

This commit is contained in:
Daniel Marjamäki 2015-07-27 16:39:41 +02:00
parent b50f554b28
commit c5bbea2994
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkbufferoverrun.cpp
View File

@ -1593,6 +1593,8 @@ void CheckBufferOverrun::checkStringArgument()
for (const Token *argtok = tok->tokAt(2); argtok; argtok = argtok->nextArgument(), argnr++) { for (const Token *argtok = tok->tokAt(2); argtok; argtok = argtok->nextArgument(), argnr++) {
if (!Token::Match(argtok, "%name%|%str% ,|)")) if (!Token::Match(argtok, "%name%|%str% ,|)"))
continue; continue;
if (argtok->variable() && !argtok->variable()->isPointer())
continue;
const Token *strtoken = argtok->getValueTokenMinStrSize(); const Token *strtoken = argtok->getValueTokenMinStrSize();
if (!strtoken) if (!strtoken)
continue; continue;

6
test/testbufferoverrun.cpp
View File

@ -3094,6 +3094,12 @@ private:
" mymemset(temp, \"abc\", 4);\n" " mymemset(temp, \"abc\", 4);\n"
"}", settings); "}", settings);
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("void f() {\n" // #6816 - fp when array has known string value
" const char c[10] = \"c\";\n"
" mymemset(c, 0, 10);\n"
"}", settings);
ASSERT_EQUALS("", errout.str());
} }
void minsize_sizeof() { void minsize_sizeof() {