walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

matchcompiler: don't emmit '!true' or '!false'. Fold to 'false' or 'true'.

This commit is contained in:
Matthias Krüger 2017-04-02 16:30:16 +02:00
parent 92fe210217
commit c65725cb1b
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/matchcompiler.py
View File

@ -188,7 +188,14 @@ class MatchCompiler:
gotoNextToken = ' tok = tok ? tok->next() : NULL;\n' gotoNextToken = ' tok = tok ? tok->next() : NULL;\n'
else: else:
ret += ' if (!tok || !' + self._compileCmd(tok) + ')\n' negatedTok ="!" + self._compileCmd(tok)
# fold !true => false ; !false => true
# this avoids cppcheck warnings about condition always being true/false
if (negatedTok == "!false"):
negatedTok = "true"
elif (negatedTok == "!true"):
negatedTok = "false"
ret += ' if (!tok || ' + negatedTok + ')\n'
ret += ' ' + returnStatement ret += ' ' + returnStatement
if isFindMatch: if isFindMatch: