From 95fa267c0eb2b0d6a80149c42442e66de93cdf83 Mon Sep 17 00:00:00 2001 From: Kimmo Varis Date: Mon, 19 Jul 2010 10:54:53 +0300 Subject: [PATCH 1/2] Remove misleading comment. --- lib/errorlogger.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/errorlogger.h b/lib/errorlogger.h index 385e96b8d..7e3a23986 100644 --- a/lib/errorlogger.h +++ b/lib/errorlogger.h @@ -16,10 +16,10 @@ * along with this program. If not, see . */ -// THIS FILE IS GENERATED BY MACHINE, SEE ../tools/errmsg.cpp ! #ifndef errorloggerH #define errorloggerH + #include #include #include "settings.h" From 9f78177914d3649b649124f5a658de56ce462d06 Mon Sep 17 00:00:00 2001 From: Kimmo Varis Date: Mon, 19 Jul 2010 11:04:30 +0300 Subject: [PATCH 2/2] Remove unused methods from ErrorLogger. --- lib/errorlogger.h | 183 ---------------------------------------------- 1 file changed, 183 deletions(-) diff --git a/lib/errorlogger.h b/lib/errorlogger.h index 7e3a23986..9487a198a 100644 --- a/lib/errorlogger.h +++ b/lib/errorlogger.h @@ -153,189 +153,6 @@ public: */ virtual void reportStatus(unsigned int index, unsigned int max) = 0; - static bool outOfBounds() - { - return true; - } - - static bool stlOutOfBounds() - { - return true; - } - - static bool noConstructor(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool uninitVar(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool unusedPrivateFunction(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool memsetClass() - { - return true; - } - - static bool memsetStruct() - { - return true; - } - - static bool operatorEq(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool virtualDestructor() - { - return true; - } - - static bool mismatchAllocDealloc() - { - return true; - } - - static bool memleak() - { - return true; - } - - static bool resourceLeak() - { - return true; - } - - static bool deallocDealloc() - { - return true; - } - - static bool deallocuse() - { - return true; - } - - static bool mismatchSize() - { - return true; - } - - static bool cstyleCast(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool redundantIfDelete0(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool redundantIfRemove(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool dangerousUsageStrtol() - { - return true; - } - - static bool ifNoAction(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool sprintfOverlappingData() - { - return true; - } - - - static bool udivError() - { - return true; - } - - - static bool unusedStructMember(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool passedByValue(const Settings &s) - { - return s._checkCodingStyle; - } - - static bool constStatement(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool charArrayIndex(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool charBitOp(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool variableScope() - { - return false; - } - - static bool conditionAlwaysTrueFalse(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool strPlusChar() - { - return true; - } - - - static bool returnLocalVariable() - { - return true; - } - - - static bool dangerousFunctionmktemp(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool dangerousFunctiongets(const Settings &s) - { - return s._checkCodingStyle; - } - - - static bool dangerousFunctionscanf(const Settings &s) - { - return s._checkCodingStyle; - } - - static std::string callStackToString(const std::list &callStack); };