walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

buffer overrun: Remove bailout. There is no test case and I fail to produce false positives.

This commit is contained in:
Daniel Marjamäki 2018-06-24 09:50:55 +02:00
parent d0819e4792
commit cb48aae594
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkbufferoverrun.cpp
View File

@ -1293,10 +1293,6 @@ void CheckBufferOverrun::checkGlobalAndLocalVariable()
negativeMemoryAllocationSizeError(tok); negativeMemoryAllocationSizeError(tok);
} }
/** @todo false negatives: this may be too conservative */
if (!var || !var->isPointer() || var->typeStartToken()->next() != var->typeEndToken())
continue;
// malloc() gets count of bytes and not count of // malloc() gets count of bytes and not count of
// elements, so we should calculate count of elements // elements, so we should calculate count of elements
// manually // manually