walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Cache and reuse values

This commit is contained in:
Dmitry-Me 2017-09-27 00:51:04 +03:00
parent 8d4c2d3145
commit d18e8466a9
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/checkunusedvar.cpp
View File

@ -431,8 +431,11 @@ void Variables::leaveScope(bool insideLoop)
static const Token* doAssignment(Variables &variables, const Token *tok, bool dereference, const Scope *scope) static const Token* doAssignment(Variables &variables, const Token *tok, bool dereference, const Scope *scope)
{ {
// a = a + b; // a = a + b;
if (Token::Match(tok, "%var% = %var% !!;") && tok->varId() == tok->tokAt(2)->varId()) { if (Token::Match(tok, "%var% = %var% !!;")) {
return tok->tokAt(2); const Token* rhsVarTok = tok->tokAt(2);
if (tok->varId() == rhsVarTok->varId()) {
return rhsVarTok;
}
} }
if (Token::Match(tok, "%var% %assign%") && tok->strAt(1) != "=") if (Token::Match(tok, "%var% %assign%") && tok->strAt(1) != "=")
@ -629,8 +632,9 @@ static const Token* doAssignment(Variables &variables, const Token *tok, bool de
// check for alias to struct member // check for alias to struct member
// char c[10]; a.b = c; // char c[10]; a.b = c;
else if (Token::Match(tok->tokAt(-2), "%name% .")) { else if (Token::Match(tok->tokAt(-2), "%name% .")) {
if (tok->tokAt(2) && tok->tokAt(2)->varId()) { const Token *rhsVarTok = tok->tokAt(2);
const unsigned int varid2 = tok->tokAt(2)->varId(); if (rhsVarTok && rhsVarTok->varId()) {
const unsigned int varid2 = rhsVarTok->varId();
const Variables::VariableUsage *var2 = variables.find(varid2); const Variables::VariableUsage *var2 = variables.find(varid2);
// struct member aliased to local variable // struct member aliased to local variable
@ -920,11 +924,13 @@ void CheckUnusedVar::checkFunctionVariableUsage_iterateScopes(const Scope* const
(_tokenizer->isCPP() && (Token::Match(tok, "delete %var% ;") || Token::Match(tok, "delete [ ] %var% ;")))) { (_tokenizer->isCPP() && (Token::Match(tok, "delete %var% ;") || Token::Match(tok, "delete [ ] %var% ;")))) {
unsigned int varid = 0; unsigned int varid = 0;
if (tok->str() != "delete") { if (tok->str() != "delete") {
varid = tok->tokAt(2)->varId(); const Token *varTok = tok->tokAt(2);
tok = tok->tokAt(3); varid = varTok->varId();
tok = varTok->next();
} else if (tok->strAt(1) == "[") { } else if (tok->strAt(1) == "[") {
varid = tok->tokAt(3)->varId(); const Token *varTok = tok->tokAt(3);
tok = tok->tokAt(3); varid = varTok->varId();
tok = varTok;
} else { } else {
varid = tok->next()->varId(); varid = tok->next()->varId();
tok = tok->next(); tok = tok->next();