walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Refactoring endsWith utility function

This commit is contained in:
Daniel Marjamäki 2018-07-25 07:43:50 +02:00
parent 9895ea5ff2
commit d300d1f61b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkstring.cpp
View File

@ -276,8 +276,8 @@ void CheckString::checkIncorrectStringCompare()
for (const Scope * scope : symbolDatabase->functionScopes) {
for (const Token* tok = scope->bodyStart->next(); tok != scope->bodyEnd; tok = tok->next()) {
// skip "assert(str && ..)" and "assert(.. && str)"
if ((endsWith(tok->str(), "assert", 6) || endsWith(tok->str(), "ASSERT", 6)) &&
Token::Match(tok, "%name% (") &&
if (Token::Match(tok, "%name% (") &&
(endsWith(tok->str(), "assert") || endsWith(tok->str(), "ASSERT")) &&
(Token::Match(tok->tokAt(2), "%str% &&") || Token::Match(tok->next()->link()->tokAt(-2), "&& %str% )")))
tok = tok->next()->link();

4
lib/utils.h
View File

@ -31,9 +31,9 @@ inline bool endsWith(const std::string &str, char c)
return str[str.size()-1U] == c;
}
inline bool endsWith(const std::string &str, const char end[], std::size_t endlen)
inline bool endsWith(const std::string &str, const std::string &end)
{
return (str.size() >= endlen) && (str.compare(str.size()-endlen, endlen, end)==0);
return (str.size() >= end.size()) && (str.compare(str.size()-end.size(), end.size(), end)==0);
}
inline static const char *getOrdinalText(int i)