walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

#5618 False positive: (performance) Use const reference for 'temp' to avoid unnecessary data copying. - redundantCopyLocalConst/CheckOther::checkRedundantCopy() is prone to false positives. As a quick fix that check becomes inconclusive.

This commit is contained in:
Alexander Mai 2014-05-02 20:09:38 +02:00
parent 935b37da0e
commit d3e8bbdc51
2 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/checkother.cpp
View File

@ -3207,7 +3207,8 @@ void CheckOther::redundantCopyError(const Token *tok,const std::string& varname)
reportError(tok, Severity::performance, "redundantCopyLocalConst", reportError(tok, Severity::performance, "redundantCopyLocalConst",
"Use const reference for '" + varname + "' to avoid unnecessary data copying.\n" "Use const reference for '" + varname + "' to avoid unnecessary data copying.\n"
"The const variable '"+varname+"' is assigned a copy of the data. You can avoid " "The const variable '"+varname+"' is assigned a copy of the data. You can avoid "
"the unnecessary data copying by converting '" + varname + "' to const reference."); "the unnecessary data copying by converting '" + varname + "' to const reference.",
true); // since #5618 that check became inconlusive
} }
//--------------------------------------------------------------------------- //---------------------------------------------------------------------------

19
test/testother.cpp
View File

@ -6091,7 +6091,7 @@ private:
"void foo() {\n" "void foo() {\n"
" const std::string a = getA();\n" " const std::string a = getA();\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (performance) Use const reference for 'a' to avoid unnecessary data copying.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (performance, inconclusive) Use const reference for 'a' to avoid unnecessary data copying.\n", errout.str());
check_redundant_copy("class A{public:A(){}};\n" check_redundant_copy("class A{public:A(){}};\n"
"const A& getA(){static A a;return a;}\n" "const A& getA(){static A a;return a;}\n"
@ -6100,7 +6100,7 @@ private:
" const A a = getA();\n" " const A a = getA();\n"
" return 0;\n" " return 0;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:5]: (performance) Use const reference for 'a' to avoid unnecessary data copying.\n", errout.str()); ASSERT_EQUALS("[test.cpp:5]: (performance, inconclusive) Use const reference for 'a' to avoid unnecessary data copying.\n", errout.str());
check_redundant_copy("const int& getA(){static int a;return a;}\n" check_redundant_copy("const int& getA(){static int a;return a;}\n"
"int main()\n" "int main()\n"
@ -6126,7 +6126,7 @@ private:
" const A a(getA());\n" " const A a(getA());\n"
" return 0;\n" " return 0;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:5]: (performance) Use const reference for 'a' to avoid unnecessary data copying.\n", errout.str()); ASSERT_EQUALS("[test.cpp:5]: (performance, inconclusive) Use const reference for 'a' to avoid unnecessary data copying.\n", errout.str());
check_redundant_copy("const int& getA(){static int a;return a;}\n" check_redundant_copy("const int& getA(){static int a;return a;}\n"
"int main()\n" "int main()\n"
@ -6168,6 +6168,19 @@ private:
" const B b(getA());\n" " const B b(getA());\n"
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// #5618
check_redundant_copy("class Token {\n"
"public:\n"
" const std::string& str();\n"
"};\n"
"void simplifyArrayAccessSyntax() {\n"
" for (Token *tok = list.front(); tok; tok = tok->next()) {\n"
" const std::string temp = tok->str();\n"
" tok->str(tok->strAt(2));\n"
" }\n"
"}\n");
TODO_ASSERT_EQUALS("", "[test.cpp:7]: (performance, inconclusive) Use const reference for 'temp' to avoid unnecessary data copying.\n", errout.str());
} }
void checkNegativeShift() { void checkNegativeShift() {