walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

incorrect logic operator: fixed crashes

This commit is contained in:
Daniel Marjamäki 2014-08-18 05:37:07 +02:00
parent 66d767b4b5
commit d44d6ad94a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -1271,6 +1271,8 @@ void CheckOther::checkIncorrectLogicOperator()
for (const Token* tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) { for (const Token* tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) {
// Opposite comparisons // Opposite comparisons
if (Token::Match(tok, "%oror%|&&") && if (Token::Match(tok, "%oror%|&&") &&
tok->astOperand1() &&
tok->astOperand2() &&
(tok->astOperand1()->isName() || tok->astOperand2()->isName()) && (tok->astOperand1()->isName() || tok->astOperand2()->isName()) &&
isOppositeCond(tok->astOperand1(), tok->astOperand2(), _settings->library.functionpure)) { isOppositeCond(tok->astOperand1(), tok->astOperand2(), _settings->library.functionpure)) {