walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

speed up checks by caching commonly looked up stuff in the symbol database (checkio)

This commit is contained in:
Robert Reif 2012-10-30 15:52:45 +01:00 committed by Daniel Marjamäki
parent 8e14d7682c
commit d7b658a5aa
1 changed files with 369 additions and 351 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/checkio.cpp
View File

@ -40,8 +40,12 @@ namespace {
//---------------------------------------------------------------------------
void CheckIO::checkCoutCerrMisusage()
{
const SymbolDatabase * const symbolDatabase = _tokenizer->getSymbolDatabase();
std::size_t functions = symbolDatabase->functionScopes.size();
for (std::size_t i = 0; i < functions; ++i) {
const Scope * scope = symbolDatabase->functionScopes[i];
bool firstCout = false;
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) {
for (const Token *tok = scope->classStart; tok && tok != scope->classEnd; tok = tok->next()) {
if (tok->str() == "(")
tok = tok->link();
@ -54,6 +58,7 @@ void CheckIO::checkCoutCerrMisusage()
} else if (firstCout && tok->str() == ";")
firstCout = false;
}
}
}
void CheckIO::coutCerrMisusageError(const Token* tok, const std::string& streamName)
@ -116,8 +121,11 @@ void CheckIO::checkFileUsage()
}
}
std::size_t functions = symbolDatabase->functionScopes.size();
for (std::size_t j = 0; j < functions; ++j) {
const Scope * scope = symbolDatabase->functionScopes[j];
unsigned int indent = 0;
for (const Token* tok = _tokenizer->list.front(); tok; tok = tok->next()) {
for (const Token *tok = scope->classStart; tok != scope->classEnd; tok = tok->next()) {
if (tok->str() == "{")
indent++;
else if (tok->str() == "}") {
@ -247,6 +255,7 @@ void CheckIO::checkFileUsage()
}
}
}
}
}
void CheckIO::fflushOnInputStreamError(const Token *tok, const std::string &varname)
@ -289,7 +298,11 @@ void CheckIO::invalidScanf()
if (!_settings->isEnabled("style"))
return;
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) {
const SymbolDatabase * const symbolDatabase = _tokenizer->getSymbolDatabase();
std::size_t functions = symbolDatabase->functionScopes.size();
for (std::size_t j = 0; j < functions; ++j) {
const Scope * scope = symbolDatabase->functionScopes[j];
for (const Token *tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) {
const Token *formatToken = 0;
if (Token::Match(tok, "scanf|vscanf ( %str% ,"))
formatToken = tok->tokAt(2);
@ -326,6 +339,7 @@ void CheckIO::invalidScanf()
}
}
}
}
}
void CheckIO::invalidScanfError(const Token *tok, bool portability)
@ -401,7 +415,10 @@ void CheckIO::checkWrongPrintfScanfArguments()
const SymbolDatabase *symbolDatabase = _tokenizer->getSymbolDatabase();
bool warning = _settings->isEnabled("style");
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) {
std::size_t functions = symbolDatabase->functionScopes.size();
for (std::size_t j = 0; j < functions; ++j) {
const Scope * scope = symbolDatabase->functionScopes[j];
for (const Token *tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) {
if (!tok->isName()) continue;
const Token* argListTok = 0; // Points to first va_list argument
@ -612,6 +629,7 @@ void CheckIO::checkWrongPrintfScanfArguments()
if (numFormat != numFunction)
wrongPrintfScanfArgumentsError(tok, tok->str(), numFormat, numFunction);
}
}
}
void CheckIO::wrongPrintfScanfArgumentsError(const Token* tok,