diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp index 13f090230..080a2daf7 100644 --- a/lib/valueflow.cpp +++ b/lib/valueflow.cpp @@ -136,11 +136,11 @@ static void valueFlowBeforeCondition(TokenList *tokenlist, ErrorLogger *errorLog continue; } - if (varid == 0U) + if (varid == 0U || !var) continue; // bailout: global non-const variables - if (var && var->isGlobal() && !var->isConst()) { + if (var->isGlobal() && !var->isConst()) { if (settings->debugwarnings) bailout(tokenlist, errorLogger, tok, "global variable " + var->nameToken()->str()); continue; @@ -239,12 +239,29 @@ static void valueFlowBeforeCondition(TokenList *tokenlist, ErrorLogger *errorLog } else { tok2 = tok2->link(); } - } else if (var && var->isGlobal() && tok2->str() == "{") { - if (!Token::Match(tok2->previous(), ")|else {")) - break; - if (Token::Match(tok2->previous(), ") {") && - !Token::Match(tok2->linkAt(-1)->previous(), "if|for|while (")) - break; + } else if (tok2->str() == "{") { + // if variable is assigned in loop don't look before the loop + if (tok2->previous() && + (Token::Match(tok2->previous(), "do") || + (tok2->str() == ")" && Token::Match(tok2->linkAt(-1)->previous(), "for|while (")))) { + + const Token *start = tok2; + const Token *end = start->link(); + if (Token::findmatch(start,"++|--| %varid% ++|--|=",end,varid)) { + if (settings->debugwarnings) + bailout(tokenlist, errorLogger, tok2, "variable " + var->nameToken()->str() + " is assigned in loop. so valueflow analysis bailout when start of loop is reached."); + break; + } + } + + // Global variable : stop when leaving the function scope + if (var->isGlobal()) { + if (!Token::Match(tok2->previous(), ")|else {")) + break; + if (Token::Match(tok2->previous(), ") {") && + !Token::Match(tok2->linkAt(-1)->previous(), "if|for|while (")) + break; + } } else if (tok2->str() == "break") { if (settings->debugwarnings) bailout(tokenlist, errorLogger, tok2, "variable " + var->nameToken()->str() + " stopping on break"); diff --git a/test/testvalueflow.cpp b/test/testvalueflow.cpp index 5f34df0f5..48df24277 100644 --- a/test/testvalueflow.cpp +++ b/test/testvalueflow.cpp @@ -144,18 +144,34 @@ private: ASSERT_EQUALS(false, testValueOfX(code, 2U, 1)); // while, for, do-while - code = "void f(int x) {\n" + code = "void f(int x) {\n" // loop condition, x is not assigned inside loop => use condition " a = x;\n" // x can be 37 " while (x == 37) {}\n" "}"; ASSERT_EQUALS(true, testValueOfX(code, 2U, 37)); - code = "void f(int x) {\n" + code = "void f(int x) {\n" // loop condition, x is assigned inside loop => dont use condition " a = x;\n" // don't assume that x can be 37 " while (x != 37) { x++; }\n" "}"; ASSERT_EQUALS(false, testValueOfX(code, 2U, 37)); + code = "void f(int x) {\n" // condition inside loop, x is NOT assigned inside loop => use condition + " a = x;\n" + " do {\n" + " if (x==76) {}\n" + " } while (1);\n" + "}"; + ASSERT_EQUALS(true, testValueOfX(code, 2U, 76)); + + code = "void f(int x) {\n" // conditions inside loop, x is assigned inside do-while => dont use condition + " a = x;\n" + " do {\n" + " if (x!=76) { x=do_something(); }\n" + " } while (1);\n" + "}"; + ASSERT_EQUALS(false, testValueOfX(code, 2U, 76)); + // bailout: ?: bailout("void f(int x) {\n" " y = ((x<0) ? x : ((x==2)?3:4));\n"