walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #1607 (false positive: variable is assigned a value that is never used)

This commit is contained in:
Robert Reif 2010-04-17 14:23:29 +02:00 committed by Daniel Marjamäki
parent 0d30b840dc
commit d851b4a3d4
2 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/checkother.cpp
View File

@ -573,20 +573,9 @@ void CheckOther::functionVariableUsage()
if (tok->next()->str() != "return") if (tok->next()->str() != "return")
{ {
varUsage[tok->strAt(3)].declare = true; varUsage[tok->strAt(3)].declare = true;
varUsage[tok->strAt(3)].aliased = true;
if (tok->tokAt(4)->str() == "=") if (tok->tokAt(4)->str() == "=")
{
varUsage[tok->strAt(3)].write = true; varUsage[tok->strAt(3)].write = true;
if (Token::Match(tok->tokAt(5), "%var% = &| %var%") &&
tok->tokAt(5)->str() == tok->tokAt(3)->str())
{
varUsage[tok->strAt(3)].aliased = true;
}
}
else if (Token::Match(tok->tokAt(5), "%var% = &| %var%") &&
tok->tokAt(5)->str() == tok->tokAt(3)->str())
{
varUsage[tok->strAt(3)].aliased = true;
}
tok = tok->tokAt(3); tok = tok->tokAt(3);
} }
} }

4
test/testunusedvar.cpp
View File

@ -332,13 +332,13 @@ private:
"{\n" "{\n"
" int * i = 0;\n" " int * i = 0;\n"
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:2]: (style) Variable 'i' is assigned a value that is never used\n", errout.str()); TODO_ASSERT_EQUALS("[test.cpp:2]: (style) Variable 'i' is assigned a value that is never used\n", errout.str());
functionVariableUsage("void foo()\n" functionVariableUsage("void foo()\n"
"{\n" "{\n"
" void * i = 0;\n" " void * i = 0;\n"
"}\n"); "}\n");
ASSERT_EQUALS("[test.cpp:2]: (style) Variable 'i' is assigned a value that is never used\n", errout.str()); TODO_ASSERT_EQUALS("[test.cpp:2]: (style) Variable 'i' is assigned a value that is never used\n", errout.str());
} }
void localvar2() void localvar2()