walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

if statements : bug fix and refactorings in the checking for "if (condition);"

This commit is contained in:
Daniel Marjamäki 2008-12-31 07:42:50 +00:00
parent 6167c22eb9
commit da1b84b199
1 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
checkother.cpp
View File

@ -200,31 +200,30 @@ void CheckOther::redundantCondition2()
void CheckOther::WarningIf()
{
// Search for 'if (condition);'
for (const TOKEN *tok = _tokenizer->tokens(); tok; tok = tok->next())
{
if (tok->str() == "if")
if (!TOKEN::simpleMatch(tok, "if ("))
continue;
// Search for the end paranthesis for the condition..
int parlevel = 0;
for (const TOKEN *tok2 = tok->next(); tok2; tok2 = tok2->next())
{
int parlevel = 0;
for (const TOKEN *tok2 = tok->next(); tok2; tok2 = tok2->next())
if (tok2->str() == "(")
++parlevel++;
else if (tok2->str() == ")")
{
if (tok2->str() == "(")
parlevel++;
else if (tok2->str() == ")")
--parlevel;
if ( parlevel <= 0 )
{
parlevel--;
if (parlevel<=0)
if ( TOKEN::Match(tok2, ") ; !!else") )
{
if (strcmp(tok2->strAt(1), ";") == 0 &&
strcmp(tok2->strAt(2), "else") != 0)
{
std::ostringstream ostr;
ostr << _tokenizer->fileLine(tok) << ": Found \"if (condition);\"";
_errorLogger->reportErr(ostr.str());
}
break;
std::ostringstream ostr;
ostr << _tokenizer->fileLine(tok) << ": Found \"if (condition);\"";
_errorLogger->reportErr(ostr.str());
}
break;
}
}
}