From db6f4f4a3b5633e498d5f72a5e9914d70f42f66e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= <daniel.marjamaki@gmail.com>
Date: Sat, 23 Jun 2018 23:04:54 +0200
Subject: [PATCH] Fix a few 'const reference' warnings by Cppcheck

---
 gui/checkthread.cpp         | 2 +-
 gui/checkthread.h           | 2 +-
 gui/cppchecklibrarydata.cpp | 4 ++--
 gui/mainwindow.cpp          | 8 ++++----
 gui/mainwindow.h            | 8 ++++----
 gui/threadhandler.h         | 2 +-
 6 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/gui/checkthread.cpp b/gui/checkthread.cpp
index fa14c6269..e22709ee7 100644
--- a/gui/checkthread.cpp
+++ b/gui/checkthread.cpp
@@ -321,7 +321,7 @@ void CheckThread::stop()
     mCppcheck.terminate();
 }
 
-void CheckThread::parseAddonErrors(QString err, QString tool)
+void CheckThread::parseAddonErrors(QString err, const QString &tool)
 {
     Q_UNUSED(tool);
     QTextStream in(&err, QIODevice::ReadOnly);
diff --git a/gui/checkthread.h b/gui/checkthread.h
index 635be04f6..c85c4aa7a 100644
--- a/gui/checkthread.h
+++ b/gui/checkthread.h
@@ -144,7 +144,7 @@ protected:
 private:
     void runAddonsAndTools(const ImportProject::FileSettings *fileSettings, const QString &fileName);
 
-    void parseAddonErrors(QString err, QString tool);
+    void parseAddonErrors(QString err, const QString &tool);
     void parseClangErrors(const QString &tool, const QString &file0, QString err);
 
     QStringList mFiles;
diff --git a/gui/cppchecklibrarydata.cpp b/gui/cppchecklibrarydata.cpp
index 255176f2b..4f02bace2 100644
--- a/gui/cppchecklibrarydata.cpp
+++ b/gui/cppchecklibrarydata.cpp
@@ -137,7 +137,7 @@ static CppcheckLibraryData::Function::Arg loadFunctionArg(QXmlStreamReader &xmlR
     return arg;
 }
 
-static CppcheckLibraryData::Function loadFunction(QXmlStreamReader &xmlReader, const QString comments)
+static CppcheckLibraryData::Function loadFunction(QXmlStreamReader &xmlReader, const QString &comments)
 {
     CppcheckLibraryData::Function function;
     function.comments = comments;
@@ -258,7 +258,7 @@ QString CppcheckLibraryData::open(QIODevice &file)
     return QString();
 }
 
-static void writeContainerFunctions(QXmlStreamWriter &xmlWriter, const QString name, int extra, const QList<struct CppcheckLibraryData::Container::Function> &functions)
+static void writeContainerFunctions(QXmlStreamWriter &xmlWriter, const QString &name, int extra, const QList<struct CppcheckLibraryData::Container::Function> &functions)
 {
     if (functions.isEmpty() && extra < 0)
         return;
diff --git a/gui/mainwindow.cpp b/gui/mainwindow.cpp
index 9af8122a0..c6814a9c5 100644
--- a/gui/mainwindow.cpp
+++ b/gui/mainwindow.cpp
@@ -723,7 +723,7 @@ void MainWindow::addIncludeDirs(const QStringList &includeDirs, Settings &result
     }
 }
 
-Library::Error MainWindow::loadLibrary(Library *library, QString filename)
+Library::Error MainWindow::loadLibrary(Library *library, const QString &filename)
 {
     Library::Error ret;
 
@@ -1141,7 +1141,7 @@ void MainWindow::openResults()
     }
 }
 
-void MainWindow::loadResults(const QString selectedFile)
+void MainWindow::loadResults(const QString &selectedFile)
 {
     if (selectedFile.isEmpty())
         return;
@@ -1156,7 +1156,7 @@ void MainWindow::loadResults(const QString selectedFile)
     formatAndSetTitle(selectedFile);
 }
 
-void MainWindow::loadResults(const QString selectedFile, const QString sourceDirectory)
+void MainWindow::loadResults(const QString &selectedFile, const QString &sourceDirectory)
 {
     loadResults(selectedFile);
     mUI.mResults->setCheckDirectory(sourceDirectory);
@@ -1292,7 +1292,7 @@ void MainWindow::showAuthors()
     dlg->exec();
 }
 
-void MainWindow::performSelectedFilesCheck(QStringList selectedFilesList)
+void MainWindow::performSelectedFilesCheck(const QStringList &selectedFilesList)
 {
     reAnalyzeSelected(selectedFilesList);
 }
diff --git a/gui/mainwindow.h b/gui/mainwindow.h
index 278cb4add..6812b17c8 100644
--- a/gui/mainwindow.h
+++ b/gui/mainwindow.h
@@ -89,7 +89,7 @@ public slots:
      * @brief Slot to reanalyze selected files
      * @param selectedFilesList list of selected files
      */
-    void performSelectedFilesCheck(QStringList selectedFilesList);
+    void performSelectedFilesCheck(const QStringList &selectedFilesList);
 
     /** @brief Slot to reanalyze modified files */
     void reAnalyzeModified();
@@ -349,14 +349,14 @@ private:
      * @brief Load XML file to the GUI.
      * @param selectedFile Filename (inc. path) of XML file to load.
      */
-    void loadResults(const QString selectedFile);
+    void loadResults(const QString &selectedFile);
 
     /**
      * @brief Load XML file to the GUI.
      * @param selectedFile Filename (inc. path) of XML file to load.
      * @param sourceDirectory Path to the directory that the results were generated for.
      */
-    void loadResults(const QString selectedFile, const QString sourceDirectory);
+    void loadResults(const QString &selectedFile, const QString &sourceDirectory);
 
     /**
     * @brief Load last project results to the GUI.
@@ -376,7 +376,7 @@ private:
      * @param filename filename (no path)
      * @return error code
      */
-    Library::Error loadLibrary(Library *library, QString filename);
+    Library::Error loadLibrary(Library *library, const QString &filename);
 
     /**
      * @brief Tries to load library file, prints message on error
diff --git a/gui/threadhandler.h b/gui/threadhandler.h
index 46bea403a..8adb53aa6 100644
--- a/gui/threadhandler.h
+++ b/gui/threadhandler.h
@@ -72,7 +72,7 @@ public:
     */
     void saveSettings(QSettings &settings) const;
 
-    void setAddonsAndTools(const QStringList &addonsAndTools, const QString misraFile) {
+    void setAddonsAndTools(const QStringList &addonsAndTools, const QString &misraFile) {
         mAddonsAndTools = addonsAndTools;
         mMisraFile = misraFile;
     }