Fixed #8618 (False positive: shared_ptr is passed by reference by intention)
This commit is contained in:
parent
cb2880e7c1
commit
de09c117bf
|
@ -1427,7 +1427,7 @@ void CheckOther::checkPassByReference()
|
||||||
const Token* const tok = var->typeStartToken();
|
const Token* const tok = var->typeStartToken();
|
||||||
if (var->isStlStringType()) {
|
if (var->isStlStringType()) {
|
||||||
;
|
;
|
||||||
} else if (var->isStlType() && Token::Match(tok, "std :: %type% <") && !Token::simpleMatch(tok->linkAt(3), "> ::") && !Token::Match(tok->tokAt(2), "initializer_list|weak_ptr|auto_ptr|unique_ptr")) {
|
} else if (var->isStlType() && Token::Match(tok, "std :: %type% <") && !Token::simpleMatch(tok->linkAt(3), "> ::") && !Token::Match(tok->tokAt(2), "initializer_list|weak_ptr|auto_ptr|unique_ptr|shared_ptr")) {
|
||||||
;
|
;
|
||||||
} else if (var->type() && !var->type()->isEnumType()) { // Check if type is a struct or class.
|
} else if (var->type() && !var->type()->isEnumType()) { // Check if type is a struct or class.
|
||||||
// Ensure that it is a large object.
|
// Ensure that it is a large object.
|
||||||
|
|
|
@ -1378,6 +1378,9 @@ private:
|
||||||
check("void f(std::unique_ptr<std::string> ptr) {}");
|
check("void f(std::unique_ptr<std::string> ptr) {}");
|
||||||
ASSERT_EQUALS("", errout.str());
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
|
check("void f(const std::shared_ptr<std::string> ptr) {}");
|
||||||
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
check("void f(const std::string::size_type x) {}");
|
check("void f(const std::string::size_type x) {}");
|
||||||
ASSERT_EQUALS("", errout.str());
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue