From df8bdabdddb33cf160d88093c39cdb3106a4d8f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Sun, 3 Nov 2019 08:45:07 +0100 Subject: [PATCH] Testing; Readded tests --- test/testcondition.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test/testcondition.cpp b/test/testcondition.cpp index 38bcd94a7..382ba2c4f 100644 --- a/test/testcondition.cpp +++ b/test/testcondition.cpp @@ -2833,6 +2833,19 @@ private: "}"); ASSERT_EQUALS("[test.cpp:4]: (style) Condition '!x' is always true\n", errout.str()); + check("bool f(int x) {\n" + " if(x == 0) { x++; return x == 0; } \n" + " return false;\n" + "}"); + TODO_ASSERT_EQUALS("return value is always true?", "", errout.str()); + + check("void f() {\n" // #6898 (Token::expressionString) + " int x = 0;\n" + " A(x++ == 1);\n" + " A(x++ == 2);\n" + "}"); + TODO_ASSERT_EQUALS("function argument is always true? however is code really weird/suspicious?", "", errout.str()); + check("void f1(const std::string &s) { if(s.empty()) if(s.size() == 0) {}} "); ASSERT_EQUALS("[test.cpp:1] -> [test.cpp:1]: (style) Condition 's.size()==0' is always true\n", errout.str());