walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

avoid crash in checkother:wrongPipeParameterSize when a pointer with unknown size is provided.

This commit is contained in:
Ettl Martin 2013-04-11 14:22:22 +02:00
parent 33cfc1a52e
commit e03a3946d0
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -524,7 +524,7 @@ void CheckOther::checkPipeParameterSize()
const Variable *var = varTok->variable();
MathLib::bigint dim;
if (var && (var->isArray() || var->isPointer()) && ((dim=var->dimension(0U)) < 2)) {
if (var && (var->isArray() || var->isPointer()) && !var->isArgument() && ((dim=var->dimension(0U)) < 2)) {
const std::string strDim = MathLib::longToString(dim);
checkPipeParameterSizeError(varTok,varTok->str(), strDim);
}

9
test/testother.cpp
View File

@ -6114,6 +6114,15 @@ private:
" }\n"
"}",NULL,false,false,true);
ASSERT_EQUALS("", errout.str());
// avoid crash with pointer variable
check("void foo (int* arrayPtr)\n"
"{\n"
" if (pipe (arrayPtr) < 0)\n"
" {}\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void checkCastIntToCharAndBack() { // #160