From e0e262ae25d4ea60ea0665bef243f6972c0127e4 Mon Sep 17 00:00:00 2001
From: versat <versat@users.noreply.github.com>
Date: Wed, 3 Apr 2019 16:02:55 +0200
Subject: [PATCH] gnu.cfg: Use function configuration for `_()` instead of
 define.

There can be preprocessor issues if the macro is used slightly different
or preprocessor conditions are used inside the string argument.
So now a function configuration with very few assumptions is used.
It is assumed that the function does return and has one parameter.
The same configuration is added for N_() since it works similar.
---
 cfg/gnu.cfg | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/cfg/gnu.cfg b/cfg/gnu.cfg
index fbf827a3b..b1fe51c95 100644
--- a/cfg/gnu.cfg
+++ b/cfg/gnu.cfg
@@ -951,7 +951,18 @@
   </function>
   <!-- _(string) is often defined as gettext(string) or string somewhere in projects. -->
   <!-- See https://www.gnu.org/software/gettext//manual/html_node/Mark-Keywords.html -->
-  <define name="_(string)" value="string"/>
+  <!-- <define name="_(string)" value="string"/> does not work always, so use a very conservative
+       function configuration instead if nothing else is seen by Cppcheck -->
+  <function name="_">
+    <noreturn>false</noreturn>
+    <arg nr="1"/>
+  </function>
+  <!-- For N_ often something like "#define N_(String) gettext_noop (String)" is used. To be safe
+       a conservative function configuration is used here like for "_" -->
+  <function name="N_">
+    <noreturn>false</noreturn>
+    <arg nr="1"/>
+  </function>
   <!-- https://linux.die.net/man/3/dgettext -->
   <!-- char * dgettext (const char *domainname, const char *msgid); -->
   <function name="dgettext">