From e0e50139cb2494bb27a0be6c62b33ea1bca3ef0d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Oliver=20St=C3=B6neberg?=
 <firewave@users.noreply.github.com>
Date: Sun, 10 May 2020 16:45:45 +0200
Subject: [PATCH] cleaned up includes based on include-what-you-use (#2632)

* cleaned up includes based on include-what-you-use

* token.cpp: fixed -Wextra-semi-stmt warning
---
 gui/codeeditor.h      | 2 --
 gui/filelist.cpp      | 1 -
 gui/main.cpp          | 2 +-
 gui/mainwindow.h      | 1 -
 gui/threadhandler.h   | 2 +-
 gui/xmlreport.h       | 1 -
 lib/check.h           | 3 ++-
 lib/exprengine.cpp    | 1 -
 lib/forwardanalyzer.h | 2 +-
 lib/token.cpp         | 2 +-
 lib/valueflow.cpp     | 1 +
 11 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/gui/codeeditor.h b/gui/codeeditor.h
index ed73a3015..09fe523d0 100644
--- a/gui/codeeditor.h
+++ b/gui/codeeditor.h
@@ -9,8 +9,6 @@
 class CodeEditorStyle;
 class QPaintEvent;
 class QResizeEvent;
-class QSize;
-class QWidget;
 
 class Highlighter : public QSyntaxHighlighter {
     Q_OBJECT
diff --git a/gui/filelist.cpp b/gui/filelist.cpp
index 2c80ef118..1c822ee0d 100644
--- a/gui/filelist.cpp
+++ b/gui/filelist.cpp
@@ -20,7 +20,6 @@
 #include <QDir>
 #include <QFileInfo>
 #include "filelist.h"
-#include "path.h"
 #include "pathmatch.h"
 
 QStringList FileList::getDefaultFilters()
diff --git a/gui/main.cpp b/gui/main.cpp
index d1bb3c0b8..09fae4af2 100644
--- a/gui/main.cpp
+++ b/gui/main.cpp
@@ -24,6 +24,7 @@
 #include <QSettings>
 #ifdef _WIN32
 #include <QMessageBox>
+#include "aboutdialog.h"
 #else
 #include <iostream>
 #endif
@@ -31,7 +32,6 @@
 #include "common.h"
 #include "mainwindow.h"
 #include "erroritem.h"
-#include "aboutdialog.h"
 #include "translationhandler.h"
 
 
diff --git a/gui/mainwindow.h b/gui/mainwindow.h
index d774fbab7..d5ccf2b1c 100644
--- a/gui/mainwindow.h
+++ b/gui/mainwindow.h
@@ -34,7 +34,6 @@ class ThreadHandler;
 class TranslationHandler;
 class ScratchPad;
 class ProjectFile;
-class ErrorItem;
 class QAction;
 
 /// @addtogroup GUI
diff --git a/gui/threadhandler.h b/gui/threadhandler.h
index 7627f21e6..8a0d86319 100644
--- a/gui/threadhandler.h
+++ b/gui/threadhandler.h
@@ -25,13 +25,13 @@
 #include <QDateTime>
 #include <set>
 #include "threadresult.h"
-#include "importproject.h"
 #include "suppressions.h"
 
 class ResultsView;
 class CheckThread;
 class QSettings;
 class Settings;
+class ImportProject;
 
 /// @addtogroup GUI
 /// @{
diff --git a/gui/xmlreport.h b/gui/xmlreport.h
index 4c044ba0a..813b9d511 100644
--- a/gui/xmlreport.h
+++ b/gui/xmlreport.h
@@ -24,7 +24,6 @@
 #include "report.h"
 
 class ErrorItem;
-class QObject;
 
 /// @addtogroup GUI
 /// @{
diff --git a/lib/check.h b/lib/check.h
index 4fbf2c548..5372f3889 100644
--- a/lib/check.h
+++ b/lib/check.h
@@ -22,7 +22,7 @@
 //---------------------------------------------------------------------------
 
 #include "config.h"
-#include "token.h"
+#include "errorlogger.h" // for Severity::SeverityType
 #include "tokenize.h"
 
 #include <list>
@@ -42,6 +42,7 @@ namespace ValueFlow {
 
 class Settings;
 class Token;
+class ErrorLogger;
 
 /** Use WRONG_DATA in checkers to mark conditions that check that data is correct */
 #define WRONG_DATA(COND, TOK)  (wrongData((TOK), (COND), #COND))
diff --git a/lib/exprengine.cpp b/lib/exprengine.cpp
index e12670f83..5f496a542 100644
--- a/lib/exprengine.cpp
+++ b/lib/exprengine.cpp
@@ -131,7 +131,6 @@
 
 #include "exprengine.h"
 #include "astutils.h"
-#include "path.h"
 #include "settings.h"
 #include "symboldatabase.h"
 #include "tokenize.h"
diff --git a/lib/forwardanalyzer.h b/lib/forwardanalyzer.h
index 5acf97de6..fb400782d 100644
--- a/lib/forwardanalyzer.h
+++ b/lib/forwardanalyzer.h
@@ -19,11 +19,11 @@
 #ifndef forwardanalyzerH
 #define forwardanalyzerH
 
-#include "valueptr.h"
 #include <vector>
 
 class Settings;
 class Token;
+template <class T> class ValuePtr;
 
 struct ForwardAnalyzer {
     struct Action {
diff --git a/lib/token.cpp b/lib/token.cpp
index f45338f38..f90bc1630 100644
--- a/lib/token.cpp
+++ b/lib/token.cpp
@@ -1577,7 +1577,7 @@ void Token::printValueFlow(bool xml, std::ostream &out) const
                 case ValueFlow::Value::ValueKind::Possible:
                     out << "possible ";
                     break;
-                };
+                }
             }
             if (tok->mImpl->mValues->size() > 1U)
                 out << '{';
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
index 07c3bff82..69794867c 100644
--- a/lib/valueflow.cpp
+++ b/lib/valueflow.cpp
@@ -91,6 +91,7 @@
 #include "token.h"
 #include "tokenlist.h"
 #include "utils.h"
+#include "valueptr.h"
 
 #include <algorithm>
 #include <cassert>