fix false positive introduced by previous false negative fix commit
This commit is contained in:
parent
833865e736
commit
e19cbf0cdd
|
@ -168,7 +168,7 @@ void CheckAutoVariables::autoVariables()
|
|||
else if (Token::Match(tok, "return & %var% ;") && tok->tokAt(2)->varId())
|
||||
{
|
||||
const Variable * var1 = symbolDatabase->getVariableFromVarId(tok->tokAt(2)->varId());
|
||||
if (var1 && var1->isArgument())
|
||||
if (var1 && var1->isArgument() && var1->typeEndToken()->str() != "&")
|
||||
errorReturnAddressOfFunctionParameter(tok, tok->strAt(2));
|
||||
}
|
||||
// Invalid pointer deallocation
|
||||
|
|
|
@ -593,6 +593,13 @@ private:
|
|||
"}\n");
|
||||
|
||||
ASSERT_EQUALS("[test.cpp:3]: (error) Return the address of function parameter 'y'\n", errout.str());
|
||||
|
||||
check("const int * foo(const int & y)\n"
|
||||
"{\n"
|
||||
" return &y;\n"
|
||||
"}\n");
|
||||
|
||||
ASSERT_EQUALS("", errout.str());
|
||||
}
|
||||
|
||||
};
|
||||
|
|
Loading…
Reference in New Issue