walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix #11828 False positive when getting a span via an out argument (#5243) 

We didn't warn for the TODO even before this change.
This commit is contained in:
chrchr-github 2023-07-15 17:53:40 +02:00 committed by GitHub
parent 72212331fb
commit e4827cb3df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/valueflow.cpp
View File

@ -8326,9 +8326,6 @@ bool ValueFlow::isContainerSizeChanged(const Token* tok, int indirect, const Set
if (astIsLHS(tok) && Token::Match(tok->astParent(), "%assign%|<<")) if (astIsLHS(tok) && Token::Match(tok->astParent(), "%assign%|<<"))
return true; return true;
const Library::Container* container = tok->valueType()->container; const Library::Container* container = tok->valueType()->container;
// Views cannot change container size
if (container->view)
return false;
if (astIsLHS(tok) && Token::simpleMatch(tok->astParent(), "[")) if (astIsLHS(tok) && Token::simpleMatch(tok->astParent(), "["))
return container->stdAssociativeLike; return container->stdAssociativeLike;
const Library::Container::Action action = astContainerAction(tok); const Library::Container::Action action = astContainerAction(tok);

15
test/teststl.cpp
View File

@ -908,6 +908,21 @@ private:
" if (x.Set(42U)) {}\n" " if (x.Set(42U)) {}\n"
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
checkNormal("struct S { void g(std::span<int>& r) const; };\n" // #11828
"int f(const S& s) {\n"
" std::span<int> t;\n"
" s.g(t);\n"
" return t[0];\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkNormal("char h() {\n"
" std::string s;\n"
" std::string_view sv(s);\n"
" return s[2];\n"
"}\n");
TODO_ASSERT_EQUALS("test.cpp:4:error:Out of bounds access in expression 's[2]' because 's' is empty.\n", "", errout.str());
} }
void outOfBoundsSymbolic() void outOfBoundsSymbolic()