walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #2841 (False positive: Array index out of bounds, can't compare ints to chars)

This commit is contained in:
Daniel Marjamäki 2011-06-29 18:44:05 +02:00
parent 6eecab5d73
commit e597ad72e7
2 changed files with 35 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/checkbufferoverrun.cpp
View File

@ -662,8 +662,15 @@ void CheckBufferOverrun::checkFunctionParameter(const Token &tok, unsigned int p
}
else if (ftok2->str() == ")")
break;
else if (parameter == par && Token::Match(ftok2, "%var% ,|)"))
parameterVarId = ftok2->varId();
else if (parameter == par && Token::Match(ftok2, "%var% ,|)|["))
{
// check type..
const Token *type = ftok2->previous();
while (Token::Match(type, "*|const"))
type = type->previous();
if (type && _tokenizer->sizeOfType(type) == arrayInfo.element_size())
parameterVarId = ftok2->varId();
}
}
// No parameterVarId => bail out

26
test/testbufferoverrun.cpp
View File

@ -118,6 +118,7 @@ private:
TEST_CASE(array_index_for_neq); // #2211: Using != in condition
TEST_CASE(array_index_for_question); // #2561: for, ?:
TEST_CASE(array_index_extern); // FP when using 'extern'. #1684
TEST_CASE(array_index_cast); // FP after cast. #2841
TEST_CASE(buffer_overrun_1);
TEST_CASE(buffer_overrun_2);
@ -1390,6 +1391,31 @@ private:
ASSERT_EQUALS("", errout.str());
}
void array_index_cast()
{
// Ticket #2841. FP when using cast.
// Different types => no error
check("void f1(char *buf) {\n"
" buf[4] = 0;\n"
"}\n"
"void f2() {\n"
" int x[2];\n"
" f1(x);\n"
"}");
ASSERT_EQUALS("", errout.str());
// Same type => error
check("void f1(const char buf[]) {\n"
" char c = buf[4];\n"
"}\n"
"void f2() {\n"
" char x[2];\n"
" f1(x);\n"
"}");
ASSERT_EQUALS("[test.cpp:6] -> [test.cpp:2]: (error) Array 'x[2]' index 4 out of bounds\n", errout.str());
}
void buffer_overrun_1()
{
check("void f()\n"