diff --git a/.clang-tidy b/.clang-tidy index 7088c1b7a..b721e1b94 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -39,8 +39,11 @@ Checks: > -misc-use-anonymous-namespace, -modernize-avoid-c-arrays, -modernize-deprecated-ios-base-aliases, + -modernize-use-nullptr, -misc-include-cleaner, + -misc-unused-using-decls, -modernize-loop-convert, + -modernize-macro-to-enum, -modernize-raw-string-literal, -modernize-replace-auto-ptr, -modernize-return-braced-init-list, diff --git a/clang-tidy.md b/clang-tidy.md index 4bc5c5954..a31fea4a9 100644 --- a/clang-tidy.md +++ b/clang-tidy.md @@ -160,6 +160,8 @@ To be evaluated (need to enable explicitly). These apply to codebases which use later standards then C++11 (C++17 is used when building with Qt6) so we cannot simply apply them. +### Disabled for performance reasons + `portability-std-allocator-const`
Only necessary for code which is exclusively compiled with `libc++`. Also disabled for performance reasons - see https://github.com/llvm/llvm-project/issues/57527#issuecomment-1237935132. @@ -183,3 +185,15 @@ We are currently using our own `naming.json` to enforce naming schemes. Also dis `portability-simd-intrinsics`
We are not using SIMD instructions and it suggests to use `std::experiemental::` features which might not be commonly available. Also disabled for performance reasons - see https://github.com/llvm/llvm-project/issues/57527#issuecomment-1237935132. + +`modernize-macro-to-enum`
+ +It does not seem to produce any warnings for us (needs to be investigated) and it is one of the more expensive checks. + +`misc-unused-using-decls` + +This is the most expensive check for several files and it is providing much in terms of code quality. Reported upstream as https://github.com/llvm/llvm-project/issues/72300. + +`modernize-use-nullptr` + +This is already covered by the `-Wzero-as-null-pointer-constant` compiler warning so there is no need for an additional check. \ No newline at end of file