walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #9039 (STL: array index out of bounds: str.begin() + 1)

This commit is contained in:
Daniel Marjamäki 2019-03-28 12:49:52 +01:00
parent 3917a14c99
commit e88a0c00c1
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/checkstl.cpp
View File

@ -73,6 +73,18 @@ void CheckStl::outOfBounds()
outOfBoundsError(tok, &value, nullptr);
continue;
}
if (Token::Match(tok, "%name% . %name% (") && container->getYield(tok->strAt(2)) == Library::Container::Yield::START_ITERATOR) {
const Token *parent = tok->tokAt(3)->astParent();
const Token *other = nullptr;
if (Token::simpleMatch(parent, "+") && parent->astOperand1() && parent->astOperand1()->hasKnownIntValue())
other = parent->astOperand1();
else if (Token::simpleMatch(parent, "+") && parent->astOperand2() && parent->astOperand2()->hasKnownIntValue())
other = parent->astOperand2();
if (other && other->getKnownIntValue() > value.intvalue) {
outOfBoundsError(tok, &value, &other->values().back());
continue;
}
}
if (!container->arrayLike_indexOp && !container->stdStringLike)
continue;
if (value.intvalue == 0 && Token::Match(tok, "%name% [")) {

10
test/teststl.cpp
View File

@ -274,6 +274,12 @@ private:
" x[0];\n"
"}\n");
ASSERT_EQUALS("", errout.str());
checkNormal("void f() {\n"
" std::string s;\n"
" x = s.begin() + 1;\n"
"}\n");
ASSERT_EQUALS("test.cpp:3:error:Out of bounds access in s because s is empty.\n", errout.str());
}
void outOfBoundsIndexExpression() {
@ -1130,7 +1136,7 @@ private:
void dereference() {
check("void f()\n"
"{\n"
" std::vector<int> ints;\n"
" std::vector<int> ints{1,2,3,4,5};\n"
" std::vector<int>::iterator iter;\n"
" iter = ints.begin() + 2;\n"
" ints.erase(iter);\n"
@ -1202,7 +1208,7 @@ private:
void dereference_auto() {
check("void f()\n"
"{\n"
" std::vector<int> ints;\n"
" std::vector<int> ints{1,2,3,4,5};\n"
" auto iter = ints.begin() + 2;\n"
" ints.erase(iter);\n"
" std::cout << (*iter) << std::endl;\n"