From eb1571af81a9e97e0c4b6017c9d106eb4658d9c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Mon, 30 Apr 2018 22:10:54 +0200 Subject: [PATCH] Refactoring: use range for --- lib/checkclass.cpp | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp index 06df1fddf..58b79f385 100644 --- a/lib/checkclass.cpp +++ b/lib/checkclass.cpp @@ -2401,18 +2401,17 @@ void CheckClass::checkCopyCtorAndEqOperator() bool moveCtor = false; CtorType assignmentOperators = CtorType::NO; - std::list::const_iterator func; - for (func = scope->functionList.begin(); func != scope->functionList.end(); ++func) { - if (copyCtors == CtorType::NO && func->type == Function::eCopyConstructor) { - copyCtors = func->hasBody() ? CtorType::WITH_BODY : CtorType::WITHOUT_BODY; + for (const Function &func : scope->functionList) { + if (copyCtors == CtorType::NO && func.type == Function::eCopyConstructor) { + copyCtors = func.hasBody() ? CtorType::WITH_BODY : CtorType::WITHOUT_BODY; } - if (assignmentOperators == CtorType::NO && func->type == Function::eOperatorEqual) { - const Variable * variable = func->getArgumentVar(0); + if (assignmentOperators == CtorType::NO && func.type == Function::eOperatorEqual) { + const Variable * variable = func.getArgumentVar(0); if (variable && variable->type() && variable->type()->classScope == scope) { - assignmentOperators = func->hasBody() ? CtorType::WITH_BODY : CtorType::WITHOUT_BODY; + assignmentOperators = func.hasBody() ? CtorType::WITH_BODY : CtorType::WITHOUT_BODY; } } - if (func->type == Function::eMoveConstructor) { + if (func.type == Function::eMoveConstructor) { moveCtor = true; break; }