walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckOther::accessMovedError() / accessMoved, accessForwarded warnings: put variable name into single quotes.

This commit is contained in:
Matthias Krüger 2018-01-07 10:57:19 +01:00
parent 83b87b54b4
commit eb58df236e
2 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/checkother.cpp
View File

@ -2677,8 +2677,8 @@ bool CheckOther::isMovedParameterAllowedForInconclusiveFunction(const Token * to
void CheckOther::accessMovedError(const Token *tok, const std::string &varname, const ValueFlow::Value *value, bool inconclusive) void CheckOther::accessMovedError(const Token *tok, const std::string &varname, const ValueFlow::Value *value, bool inconclusive)
{ {
if (!tok) { if (!tok) {
reportError(tok, Severity::warning, "accessMoved", "Access of moved variable v.", CWE672, false); reportError(tok, Severity::warning, "accessMoved", "Access of moved variable 'v'.", CWE672, false);
reportError(tok, Severity::warning, "accessForwarded", "Access of forwarded variable v.", CWE672, false); reportError(tok, Severity::warning, "accessForwarded", "Access of forwarded variable 'v'.", CWE672, false);
return; return;
} }
@ -2696,7 +2696,7 @@ void CheckOther::accessMovedError(const Token *tok, const std::string &varname,
default: default:
return; return;
} }
const std::string errmsg("Access of " + kindString + " variable " + varname + "."); const std::string errmsg("Access of " + kindString + " variable '" + varname + "'.");
const ErrorPath errorPath = getErrorPath(tok, value, errmsg); const ErrorPath errorPath = getErrorPath(tok, value, errmsg);
reportError(errorPath, Severity::warning, errorId, errmsg, CWE672, inconclusive); reportError(errorPath, Severity::warning, errorId, errmsg, CWE672, inconclusive);
} }

38
test/testother.cpp
View File

@ -6173,7 +6173,7 @@ private:
" g(std::move(a));\n" " g(std::move(a));\n"
" g(std::move(a));\n" " g(std::move(a));\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable a.\n", errout.str()); ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void doubleMoveMemberInitialization1() { void doubleMoveMemberInitialization1() {
@ -6187,7 +6187,7 @@ private:
" B b1;\n" " B b1;\n"
" B b2;\n" " B b2;\n"
"};"); "};");
ASSERT_EQUALS("[test.cpp:6]: (warning) Access of moved variable b.\n", errout.str()); ASSERT_EQUALS("[test.cpp:6]: (warning) Access of moved variable 'b'.\n", errout.str());
} }
void doubleMoveMemberInitialization2() { void doubleMoveMemberInitialization2() {
@ -6200,7 +6200,7 @@ private:
" B b1;\n" " B b1;\n"
" B b2;\n" " B b2;\n"
"};"); "};");
ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable b.\n", errout.str()); ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable 'b'.\n", errout.str());
} }
void moveAndAssign1() { void moveAndAssign1() {
@ -6220,7 +6220,7 @@ private:
" B b = g(std::move(a));\n" " B b = g(std::move(a));\n"
" C c = g(std::move(a));\n" " C c = g(std::move(a));\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable a.\n", errout.str()); ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void moveAssignMoveAssign() { void moveAssignMoveAssign() {
@ -6236,8 +6236,8 @@ private:
" a = b;\n" " a = b;\n"
" h(a);\n" " h(a);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (warning) Access of moved variable a.\n" ASSERT_EQUALS("[test.cpp:4]: (warning) Access of moved variable 'a'.\n"
"[test.cpp:8]: (warning) Access of moved variable a.\n", errout.str()); "[test.cpp:8]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void moveAndReset1() { void moveAndReset1() {
@ -6259,7 +6259,7 @@ private:
" b.reset(g(std::move(a)));\n" " b.reset(g(std::move(a)));\n"
" c.reset(g(std::move(a)));\n" " c.reset(g(std::move(a)));\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:7]: (warning) Access of moved variable a.\n", errout.str()); ASSERT_EQUALS("[test.cpp:7]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void moveResetMoveReset() { void moveResetMoveReset() {
@ -6275,8 +6275,8 @@ private:
" a.reset(b);\n" " a.reset(b);\n"
" h(a);\n" " h(a);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (warning) Access of moved variable a.\n" ASSERT_EQUALS("[test.cpp:4]: (warning) Access of moved variable 'a'.\n"
"[test.cpp:8]: (warning) Access of moved variable a.\n", errout.str()); "[test.cpp:8]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void moveAndFunctionParameter() { void moveAndFunctionParameter() {
@ -6287,8 +6287,8 @@ private:
" g(a);\n" " g(a);\n"
" A c = a;\n" " A c = a;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable a.\n" ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable 'a'.\n"
"[test.cpp:6]: (warning) Access of moved variable a.\n", errout.str()); "[test.cpp:6]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void moveAndFunctionParameterReference() { void moveAndFunctionParameterReference() {
@ -6310,8 +6310,8 @@ private:
" g(a);\n" " g(a);\n"
" A c = a;\n" " A c = a;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable a.\n" ASSERT_EQUALS("[test.cpp:5]: (warning) Access of moved variable 'a'.\n"
"[test.cpp:6]: (warning) Access of moved variable a.\n", errout.str()); "[test.cpp:6]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void moveAndFunctionParameterUnknown() { void moveAndFunctionParameterUnknown() {
@ -6321,8 +6321,8 @@ private:
" g(a);\n" " g(a);\n"
" A c = a;\n" " A c = a;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (warning, inconclusive) Access of moved variable a.\n" ASSERT_EQUALS("[test.cpp:4]: (warning, inconclusive) Access of moved variable 'a'.\n"
"[test.cpp:5]: (warning, inconclusive) Access of moved variable a.\n", errout.str()); "[test.cpp:5]: (warning, inconclusive) Access of moved variable 'a'.\n", errout.str());
} }
void moveAndReturn() { void moveAndReturn() {
@ -6334,7 +6334,7 @@ private:
" return g(std::move(b));\n" " return g(std::move(b));\n"
" return h(std::move(a),std::move(b));\n" " return h(std::move(a),std::move(b));\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:7]: (warning) Access of moved variable a.\n", errout.str()); ASSERT_EQUALS("[test.cpp:7]: (warning) Access of moved variable 'a'.\n", errout.str());
} }
void moveAndClear() { void moveAndClear() {
@ -6354,8 +6354,8 @@ private:
" x = p->x;\n" " x = p->x;\n"
" y = p->y;\n" " y = p->y;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (warning) Access of moved variable p.\n" ASSERT_EQUALS("[test.cpp:4]: (warning) Access of moved variable 'p'.\n"
"[test.cpp:5]: (warning) Access of moved variable p.\n", errout.str()); "[test.cpp:5]: (warning) Access of moved variable 'p'.\n", errout.str());
} }
void partiallyMoved() { void partiallyMoved() {
@ -6382,7 +6382,7 @@ private:
" g(std::forward<T>(t));\n" " g(std::forward<T>(t));\n"
" T s = t;\n" " T s = t;\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (warning) Access of forwarded variable t.\n", errout.str()); ASSERT_EQUALS("[test.cpp:4]: (warning) Access of forwarded variable 't'.\n", errout.str());
} }
void funcArgNamesDifferent() { void funcArgNamesDifferent() {