From ecc84ee02793470a15fc31a8939bb9a217852e0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Wed, 2 Aug 2017 08:45:17 +0200 Subject: [PATCH] Fix issue detected by Coverity, StatsDialog::mStatistics was not initialized in the constructor --- gui/statsdialog.cpp | 5 +++-- gui/statsdialog.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gui/statsdialog.cpp b/gui/statsdialog.cpp index c46217213..a2722996f 100644 --- a/gui/statsdialog.cpp +++ b/gui/statsdialog.cpp @@ -30,7 +30,8 @@ #include "checkstatistics.h" StatsDialog::StatsDialog(QWidget *parent) - : QDialog(parent) + : QDialog(parent), + mStatistics(nullptr) { mUI.setupUi(this); @@ -281,7 +282,7 @@ void StatsDialog::copyToClipboard() void StatsDialog::setStatistics(const CheckStatistics *stats) { - mStatistics = const_cast(stats); + mStatistics = stats; mUI.mLblErrors->setText(QString("%1").arg(stats->getCount(ShowTypes::ShowErrors))); mUI.mLblWarnings->setText(QString("%1").arg(stats->getCount(ShowTypes::ShowWarnings))); mUI.mLblStyle->setText(QString("%1").arg(stats->getCount(ShowTypes::ShowStyle))); diff --git a/gui/statsdialog.h b/gui/statsdialog.h index cbc4fde42..91df55234 100644 --- a/gui/statsdialog.h +++ b/gui/statsdialog.h @@ -68,7 +68,7 @@ private slots: private: Ui::StatsDialog mUI; - CheckStatistics *mStatistics; + const CheckStatistics *mStatistics; }; /// @}