From ed03545725f7553279e12d82db70e576ecbfe6b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Wed, 12 Apr 2017 21:45:39 +0200 Subject: [PATCH] Misra: Try to avoid FPs --- addons/misra-test.c | 2 +- addons/misra.py | 12 +----------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/addons/misra-test.c b/addons/misra-test.c index 10c212341..a68ffc445 100644 --- a/addons/misra-test.c +++ b/addons/misra-test.c @@ -24,7 +24,7 @@ void misra_12_1() { } void misra_12_3() { - f((1,2),3); // 12.3 + f((1,2),3); // TODO for (i=0;i<10;i++,j++){} // 12.3 } diff --git a/addons/misra.py b/addons/misra.py index 749fdae4e..d163d8163 100644 --- a/addons/misra.py +++ b/addons/misra.py @@ -123,17 +123,7 @@ def misra_12_3(data): if token.str != ',': continue if token.astParent and (token.astParent.str in ['(', ',', '{']): - if token.astParent.str == ',': - if token == token.astParent.astOperand1: - if noParentheses(token, token.astParent): - continue - elif token == token.astParent.astOperand2: - if noParentheses(token.astParent, token): - continue - else: - continue - else: - continue + continue reportError(token, 12, 3) def misra_13_5(data):