walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Cleanup CheckBufferOverrun

This commit is contained in:
Daniel Marjamäki 2010-04-22 19:58:44 +02:00
parent e28dbda5fa
commit eda18004bd
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/checkbufferoverrun.cpp
View File

@ -932,10 +932,6 @@ void CheckBufferOverrun::checkScope(const Token *tok, const ArrayInfo &arrayInfo
checkFunctionCall(*tok, 2, arrayInfo); checkFunctionCall(*tok, 2, arrayInfo);
if (Token::Match(tok, "memset|memcpy|memmove|memcmp|strncpy|fgets ( %varid% , %any% , %any% )", arrayInfo.varid) ||
Token::Match(tok, "memset|memcpy|memmove|memcmp|fgets ( %var% , %varid% , %any% )", arrayInfo.varid))
{
if (_settings->_checkCodingStyle) if (_settings->_checkCodingStyle)
{ {
// check for strncpy which is not terminated // check for strncpy which is not terminated
@ -960,7 +956,6 @@ void CheckBufferOverrun::checkScope(const Token *tok, const ArrayInfo &arrayInfo
} }
} }
} }
}
// Dangerous usage of strncat.. // Dangerous usage of strncat..
if (Token::Match(tok, "strncpy|strncat ( %varid% , %any% , %num% )", arrayInfo.varid)) if (Token::Match(tok, "strncpy|strncat ( %varid% , %any% , %num% )", arrayInfo.varid))
@ -1060,19 +1055,6 @@ void CheckBufferOverrun::checkGlobalAndLocalVariable()
continue; continue;
} }
/*
if (Token::Match(tok, "%type% *| %var% [ %num% ] [;=]"))
{
unsigned int varpos = 1;
if (tok->next()->str() == "*")
++varpos;
size = MathLib::toLongNumber(tok->strAt(varpos + 2));
type = tok->strAt(varpos - 1);
varid = tok->tokAt(varpos)->varId();
nextTok = varpos + 5;
}
else
*/
if (Token::Match(tok, "%type% *| %var% [ %var% ] [;=]")) if (Token::Match(tok, "%type% *| %var% [ %var% ] [;=]"))
{ {
unsigned int varpos = 1; unsigned int varpos = 1;