walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Merge pull request #832 from simartin/ticket_7068 

Ticket #7068: Treat "memset(&this->member, ..." as member initialization
This commit is contained in:
orbitcowboy 2016-10-01 15:36:32 +02:00 committed by GitHub
parent 6f133a397b dc61b6342d
commit ee0602cd21
2 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/checkclass.cpp
View File

@ -628,6 +628,18 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
return; return;
} }
// Ticket #7068
else if (Token::Match(ftok, "::| memset ( &| this . %name%")) {
if (ftok->str() == "::")
ftok = ftok->next();
int offsetToMember = 4;
if (ftok->tokAt(ftok->strAt(2) == "&"))
++offsetToMember;
assignVar(ftok->tokAt(offsetToMember)->varId(), scope, usage);
ftok = ftok->linkAt(1);
continue;
}
// Clearing array.. // Clearing array..
else if (Token::Match(ftok, "::| memset ( %name% ,")) { else if (Token::Match(ftok, "::| memset ( %name% ,")) {
if (ftok->str() == "::") if (ftok->str() == "::")

42
test/testconstructors.cpp
View File

@ -2807,6 +2807,48 @@ private:
"};"); "};");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// Ticket #7068
check("struct Foo {\n"
" int * p;\n"
" char c;\n"
" Foo() { memset(p, 0, sizeof(int)); }\n"
"};");
ASSERT_EQUALS("[test.cpp:4]: (warning) Member variable 'Foo::c' is not initialized in the constructor.\n", errout.str());
check("struct Foo {\n"
" int i;\n"
" char c;\n"
" Foo() { memset(&i, 0, sizeof(int)); }\n"
"};");
ASSERT_EQUALS("[test.cpp:4]: (warning) Member variable 'Foo::c' is not initialized in the constructor.\n", errout.str());
check("struct Foo { int f; };\n"
"struct Bar { int b; };\n"
"struct FooBar {\n"
" FooBar() {\n"
" memset(&foo, 0, sizeof(foo));\n"
" }\n"
" Foo foo;\n"
" Bar bar;\n"
"};\n"
"int main() {\n"
" FooBar foobar;\n"
" return foobar.foo.f + foobar.bar.b;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (warning) Member variable 'FooBar::bar' is not initialized in the constructor.\n", errout.str());
check("struct Foo { int f; };\n"
"struct Bar { int b; };\n"
"struct FooBar {\n"
" FooBar() {\n"
" memset(&this->foo, 0, sizeof(this->foo));\n"
" }\n"
" Foo foo;\n"
" Bar bar;\n"
"};\n"
"int main() {\n"
" FooBar foobar;\n"
" return foobar.foo.f + foobar.bar.b;\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (warning) Member variable 'FooBar::bar' is not initialized in the constructor.\n", errout.str());
} }
void privateCtor1() { void privateCtor1() {