walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

updated comment. removed a inconclusive condition, I don't think it's needed.

This commit is contained in:
Daniel Marjamäki 2011-10-29 12:52:46 +02:00
parent ad40586e96
commit f04210ad9f
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/checkother.cpp
View File

@ -425,8 +425,8 @@ void CheckOther::checkSizeofForStrncmpSize()
const char pattern1[] = "strncmp ( %any% , %any% , sizeof ( %var% ) )"; const char pattern1[] = "strncmp ( %any% , %any% , sizeof ( %var% ) )";
const char pattern2[] = "strncmp ( %any% , %any% , sizeof %var% )"; const char pattern2[] = "strncmp ( %any% , %any% , sizeof %var% )";
// this check is inconclusive - it might be intentional to use // danmar : this is inconclusive in case the size parameter is
// sizeof(char *) as parameter // sizeof(char *) by intention.
if (!_settings->inconclusive) if (!_settings->inconclusive)
return; return;
@ -2306,9 +2306,6 @@ void CheckOther::checkAlwaysTrueOrFalseStringCompare()
tok = tok->tokAt(7); tok = tok->tokAt(7);
} }
if (!_settings->inconclusive)
return;
tok = _tokenizer->tokens(); tok = _tokenizer->tokens();
while (tok && (tok = Token::findmatch(tok, pattern3)) != NULL) { while (tok && (tok = Token::findmatch(tok, pattern3)) != NULL) {
const Token *var1 = tok->tokAt(2); const Token *var1 = tok->tokAt(2);