walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckBufferOverrun: simplify checking of read|write problems

This commit is contained in:
Daniel Marjamäki 2010-04-21 20:06:59 +02:00
parent f9f6927e63
commit f378b382a0
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/checkbufferoverrun.cpp
View File

@ -477,6 +477,12 @@ void CheckBufferOverrun::checkFunctionCall(const Token &tok, unsigned int par, c
total_size["strncpy"] = 3; total_size["strncpy"] = 3;
total_size["memset"] = 3; total_size["memset"] = 3;
} }
if (par == 2)
{
total_size["read"] = 3;
total_size["write"] = 3;
}
std::map<std::string, unsigned int>::const_iterator it = total_size.find(tok.str()); std::map<std::string, unsigned int>::const_iterator it = total_size.find(tok.str());
if (it != total_size.end()) if (it != total_size.end())
@ -1015,19 +1021,6 @@ void CheckBufferOverrun::checkScope(const Token *tok, const ArrayInfo &arrayInfo
if (n > total_size) if (n > total_size)
outOfBounds(tok->tokAt(4), "snprintf size"); outOfBounds(tok->tokAt(4), "snprintf size");
} }
// Writing data into array..
if (Token::Match(tok, "read|write ( %any% , %varid% , %num% )", arrayInfo.varid) &&
MathLib::isInt(tok->strAt(6)))
{
const unsigned long len = MathLib::toLongNumber(tok->strAt(6));
if (len > total_size)
{
bufferOverrun(tok, arrayInfo.varname);
continue;
}
}
} }
} }