walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

fixed/excluded some shellcheck warnings and actually fail the build when something is found (#3068)

This commit is contained in:
Oliver Stöneberg 2021-01-20 18:43:49 +01:00 committed by GitHub
parent 2cb20124a6
commit f46a9e3543
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 34 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/scriptcheck.yml vendored
View File

@ -26,7 +26,7 @@ jobs:
- name: run Shellcheck - name: run Shellcheck
run: | run: |
find . -name "*.sh" | xargs shellcheck || true find . -name "*.sh" | xargs shellcheck --exclude SC2002,SC2013,SC2034,SC2035,SC2043,SC2046,SC2086,SC2089,SC2090,SC2129,SC2211,SC2231
- name: run pylint - name: run pylint
run: | run: |

2
cve-test-suite/download.sh
View File

@ -3,7 +3,7 @@
echo "CVE" > cve.txt echo "CVE" > cve.txt
for i in `seq 1 20`; for i in $(seq 1 20);
do do
echo "page $i" echo "page $i"
# CVE 119 issues: # CVE 119 issues:

2
man/build-pdf.sh
View File

@ -25,7 +25,7 @@ pandoc $1.md -o $1.pdf -s --number-sections --toc \
--listings \ --listings \
-f markdown \ -f markdown \
-V mainfont="$MainFont" \ -V mainfont="$MainFont" \
-V monofont="$Consolas" \ -V monofont="$MonoFont" \
-V geometry:a4paper \ -V geometry:a4paper \
-V geometry:margin=2.4cm \ -V geometry:margin=2.4cm \
-V subparagraph \ -V subparagraph \

2
test/cfg/generate-cfg-tests.sh
View File

@ -1,5 +1,5 @@
#!/bin/bash #!/bin/bash
cd ~/cppcheck cd ~/cppcheck || exit 1
make generate_cfg_tests make generate_cfg_tests
./generate_cfg_tests cfg/avr.cfg > test/cfg/generated-cfg-tests-avr.cpp ./generate_cfg_tests cfg/avr.cfg > test/cfg/generated-cfg-tests-avr.cpp
./generate_cfg_tests cfg/bsd.cfg > test/cfg/generated-cfg-tests-bsd.cpp ./generate_cfg_tests cfg/bsd.cfg > test/cfg/generated-cfg-tests-bsd.cpp

6
test/cfg/runtests.sh
View File

@ -401,11 +401,7 @@ set -e
if [ $PKGCONFIG_RETURNCODE -ne 0 ]; then if [ $PKGCONFIG_RETURNCODE -ne 0 ]; then
echo "pkg-config needed to retrieve cppunit configuration is not available, skipping syntax check." echo "pkg-config needed to retrieve cppunit configuration is not available, skipping syntax check."
else else
set +e if pkg-config cppunit; then
CPPUNIT=$(pkg-config cppunit)
CPPUNIT_RETURNCODE=$?
set -e
if [ $CPPUNIT_RETURNCODE -ne 0 ]; then
echo "cppunit not found, skipping syntax check for cppunit" echo "cppunit not found, skipping syntax check for cppunit"
else else
echo "cppunit found, checking syntax with ${CXX} now." echo "cppunit found, checking syntax with ${CXX} now."

1
test/synthetic/run-clang.sh
View File

@ -1,3 +1,4 @@
#!/bin/bash
~/llvm/build/bin/clang -cc1 -analyze -analyzer-checker=alpha.security controlflow.c data.c functions.c 2>&1 /dev/null | grep warning ~/llvm/build/bin/clang -cc1 -analyze -analyzer-checker=alpha.security controlflow.c data.c functions.c 2>&1 /dev/null | grep warning
~/llvm/build/bin/clang -cc1 -analyze -analyzer-checker=alpha.security,core ub.c 2>&1 /dev/null | grep warning ~/llvm/build/bin/clang -cc1 -analyze -analyzer-checker=alpha.security,core ub.c 2>&1 /dev/null | grep warning

46
tools/daca2-logs2git.sh
View File

@ -8,7 +8,7 @@ base_url="http://cppcheck.sourceforge.net/devinfo/daca2-report/"
echo ${base_url}daca2.html echo ${base_url}daca2.html
for site in `curl -s --compressed ${base_url}daca2.html | grep "^<tr" | grep -o "\".*\"" | sed s/\"//g` ; do for site in $(curl -s --compressed ${base_url}daca2.html | grep "^<tr" | grep -o "\".*\"" | sed s/\"//g) ; do
echo ${site} ; curl -s --compressed ${base_url}${site} | sort -n --parallel=4 | sed 's/^ *//; s/ *$//; /^$/d; s/^M$//; s/\r$//' | sed -e 's/\[[0-9][0-9]:[0-9][0-9]\]$//' | sed '/^$/d' | sed 's/\&amp\;/\&/g; s/&lt;/</g; s/&gt;/>/g;' > ${site} echo ${site} ; curl -s --compressed ${base_url}${site} | sort -n --parallel=4 | sed 's/^ *//; s/ *$//; /^$/d; s/^M$//; s/\r$//' | sed -e 's/\[[0-9][0-9]:[0-9][0-9]\]$//' | sed '/^$/d' | sed 's/\&amp\;/\&/g; s/&lt;/</g; s/&gt;/>/g;' > ${site}
done done
@ -24,37 +24,37 @@ grep "^-.*" /tmp/daca_tmp_diff > /tmp/daca_tmp_minus
plus_glob=`wc -l /tmp/daca_tmp_plus | cut -d' ' -f1` plus_glob=$(wc -l /tmp/daca_tmp_plus | cut -d' ' -f1)
plus_error=`grep -c ":\ \(inconclusive\ \)\?error: " /tmp/daca_tmp_plus` plus_error=$(grep -c ":\ \(inconclusive\ \)\?error: " /tmp/daca_tmp_plus)
plus_warning=`grep -c ":\ \(inconclusive\ \)\?warning: " /tmp/daca_tmp_plus` plus_warning=$(grep -c ":\ \(inconclusive\ \)\?warning: " /tmp/daca_tmp_plus)
plus_style=`grep -c ":\ \(inconclusive\ \)\?style: " /tmp/daca_tmp_plus` plus_style=$(grep -c ":\ \(inconclusive\ \)\?style: " /tmp/daca_tmp_plus)
plus_performance=`grep -c ":\ \(inconclusive\ \)\?performance: " /tmp/daca_tmp_plus` plus_performance=$(grep -c ":\ \(inconclusive\ \)\?performance: " /tmp/daca_tmp_plus)
plus_portability=`grep -c ":\ \(inconclusive\ \)\?portability: " /tmp/daca_tmp_plus` plus_portability=$(grep -c ":\ \(inconclusive\ \)\?portability: " /tmp/daca_tmp_plus)
#plus_information=`grep -c "]: (information)" /tmp/daca_tmp_plus` #plus_information=$(grep -c "]: (information)" /tmp/daca_tmp_plus)
plus_crash=`grep -c "\ Crash?$" /tmp/daca_tmp_plus` plus_crash=$(grep -c "\ Crash?$" /tmp/daca_tmp_plus)
plus_varid=`grep -c "called with varid 0\." /tmp/daca_tmp_plus` plus_varid=$(grep -c "called with varid 0\." /tmp/daca_tmp_plus)
minus_glob=`wc -l /tmp/daca_tmp_minus | cut -d' ' -f1` minus_glob=$(wc -l /tmp/daca_tmp_minus | cut -d' ' -f1)
minus_error=`grep -c ":\ \(inconclusive\ \)\?error: " /tmp/daca_tmp_minus` minus_error=$(grep -c ":\ \(inconclusive\ \)\?error: " /tmp/daca_tmp_minus)
minus_warning=`grep -c ":\ \(inconclusive\ \)\?warning: " /tmp/daca_tmp_minus` minus_warning=$(grep -c ":\ \(inconclusive\ \)\?warning: " /tmp/daca_tmp_minus)
minus_style=`grep -c ":\ \(inconclusive\ \)\?style: " /tmp/daca_tmp_minus` minus_style=$(grep -c ":\ \(inconclusive\ \)\?style: " /tmp/daca_tmp_minus)
minus_performance=`grep -c ":\ \(inconclusive\ \)\?performance: " /tmp/daca_tmp_minus` minus_performance=$(grep -c ":\ \(inconclusive\ \)\?performance: " /tmp/daca_tmp_minus)
minus_portability=`grep -c ":\ \(inconclusive\ \)\?portability: " /tmp/daca_tmp_minus` minus_portability=$(grep -c ":\ \(inconclusive\ \)\?portability: " /tmp/daca_tmp_minus)
#minus_information=`grep -c "]: (information)" /tmp/daca_tmp_minus` #minus_information=$(grep -c "]: (information)" /tmp/daca_tmp_minus)
minus_crash=`grep -c "\ Crash?$" /tmp/daca_tmp_minus` minus_crash=$(grep -c "\ Crash?$" /tmp/daca_tmp_minus)
minus_varid=`grep -c "called with varid 0\." /tmp/daca_tmp_minus` minus_varid=$(grep -c "called with varid 0\." /tmp/daca_tmp_minus)
files=`git ls-files` files=$(git ls-files)
ID_stats=`awk '{ print $NF }' $files | grep "^\[.*\]$" | sort -n | uniq --count | sort -n` ID_stats=$(awk '{ print $NF }' $files | grep "^\[.*\]$" | sort -n | uniq --count | sort -n)
echo "Update `date`" >> /tmp/daca_msg echo "Update $(date)" >> /tmp/daca_msg
echo "Updated: `git status --porcelain | grep daca | cut -d' ' -f3 | sed s/daca2-// | sed s/\.html// | tr '\n' ' '`" >> /tmp/daca_msg echo "Updated: $(git status --porcelain | grep daca | cut -d' ' -f3 | sed s/daca2-// | sed s/\.html// | tr '\n' ' ')" >> /tmp/daca_msg
echo "all: new: $plus_glob gone: $minus_glob = $((plus_glob-minus_glob))" >> /tmp/daca_msg echo "all: new: $plus_glob gone: $minus_glob = $((plus_glob-minus_glob))" >> /tmp/daca_msg
echo "error: new: $plus_error gone: $minus_error = $((plus_error-minus_error))" >> /tmp/daca_msg echo "error: new: $plus_error gone: $minus_error = $((plus_error-minus_error))" >> /tmp/daca_msg
echo "warning: new: $plus_warning gone: $minus_warning = $((plus_warning-minus_warning))" >> /tmp/daca_msg echo "warning: new: $plus_warning gone: $minus_warning = $((plus_warning-minus_warning))" >> /tmp/daca_msg

4
tools/extract_and_run_more_tests.sh
View File

@ -1,8 +1,8 @@
#!/bin/bash #!/bin/bash
cd ~/cppcheck cd ~/cppcheck || exit 1
rm -rf test1 rm -rf test1
python tools/extracttests.py --code=test1 test/testleakautovar.cpp python tools/extracttests.py --code=test1 test/testleakautovar.cpp
cd ~/cppcheck/test1 cd ~/cppcheck/test1 || exit 1
~/cppcheck/tools/run_more_tests.sh ~/cppcheck/tools/run_more_tests.sh

4
tools/run-coverity.sh
View File

@ -1,6 +1,6 @@
#!/bin/bash #!/bin/bash
PATH=$PATH:/home/danielmarjamaki/cov-analysis-linux64-2019.03/bin PATH=$PATH:/home/danielmarjamaki/cov-analysis-linux64-2019.03/bin
cd /home/danielmarjamaki/cppcheck-devinfo cd /home/danielmarjamaki/cppcheck-devinfo || exit 1
git pull git pull
echo Analyze echo Analyze
@ -15,7 +15,7 @@ curl --insecure \
--form token=e74RRnWR6BVsn5LKdclfcA \ --form token=e74RRnWR6BVsn5LKdclfcA \
--form email=daniel.marjamaki@gmail.com \ --form email=daniel.marjamaki@gmail.com \
--form file=@cppcheck.tgz \ --form file=@cppcheck.tgz \
--form version=`git log -1 --format=oneline | sed -r 's/([a-f0-9]{7}).*/\1/'` \ --form version=$(git log -1 --format=oneline | sed -r 's/([a-f0-9]{7}).*/\1/') \
--form description="Development" \ --form description="Development" \
https://scan.coverity.com/builds?project=cppcheck https://scan.coverity.com/builds?project=cppcheck

2
webreport.sh
View File

@ -10,7 +10,7 @@ mv coverage_report devinfo/
doxygen 2> devinfo/doxygen-errors.txt doxygen 2> devinfo/doxygen-errors.txt
mv doxyoutput/html devinfo/doxyoutput mv doxyoutput/html devinfo/doxyoutput
cd addons cd addons || exit 1
doxygen cppcheckdata.doxyfile doxygen cppcheckdata.doxyfile
mv html ../devinfo/cppcheckdata mv html ../devinfo/cppcheckdata
cd .. cd ..