walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckBufferOverrun: Skip warnings about array index out of bounds in unions. Theoretically, the array is at least as large as the biggest union member.

This commit is contained in:
Daniel Marjamäki 2016-12-18 22:10:30 +01:00
parent 4558701c08
commit f5ad7482a8
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/checkbufferoverrun.cpp
View File

@ -1507,6 +1507,9 @@ void CheckBufferOverrun::bufferOverrun()
if (var->dimension(0) <= 1 && Token::simpleMatch(var->nameToken()->linkAt(1),"] ; }")) if (var->dimension(0) <= 1 && Token::simpleMatch(var->nameToken()->linkAt(1),"] ; }"))
continue; continue;
if (var->scope() && var->scope()->type == Scope::eUnion)
continue;
ArrayInfo arrayInfo(var, symbolDatabase); ArrayInfo arrayInfo(var, symbolDatabase);
arrayInfo.varname(varname); arrayInfo.varname(varname);

6
test/testbufferoverrun.cpp
View File

@ -563,6 +563,12 @@ private:
" ab->a[0] = 0;\n" " ab->a[0] = 0;\n"
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("union { char a[1]; int b; } ab;\n"
"void f() {\n"
" ab.a[2] = 0;\n"
"}");
ASSERT_EQUALS("", errout.str());
} }