walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix #11460 unintvar false positive (#4674) 

* Fix #11460 unintvar false positive

* Format
This commit is contained in:
chrchr-github 2023-01-02 17:44:52 +01:00 committed by GitHub
parent 11f1a9d1f5
commit f793b7dd35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/symboldatabase.cpp
View File

@ -929,7 +929,7 @@ void SymbolDatabase::createSymbolDatabaseNeedInitialization()
if (var.isClass()) { if (var.isClass()) {
if (var.type()) { if (var.type()) {
// does this type need initialization? // does this type need initialization?
if (var.type()->needInitialization == Type::NeedInitialization::True && !var.hasDefault()) if (var.type()->needInitialization == Type::NeedInitialization::True && !var.hasDefault() && !var.isStatic())
needInitialization = true; needInitialization = true;
else if (var.type()->needInitialization == Type::NeedInitialization::Unknown) { else if (var.type()->needInitialization == Type::NeedInitialization::Unknown) {
if (!(var.valueType() && var.valueType()->type == ValueType::CONTAINER)) if (!(var.valueType() && var.valueType()->type == ValueType::CONTAINER))

12
test/testuninitvar.cpp
View File

@ -6249,6 +6249,18 @@ private:
" S s2 = s1;\n" " S s2 = s1;\n"
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// #11460
valueFlowUninit("struct B { int i; };\n"
" struct H {\n"
" void e() const;\n"
" static const B b;\n"
"};\n"
"void f() {\n"
" H h;\n"
" h.e();\n"
"}\n");
ASSERT_EQUALS("", errout.str());
} }
void uninitvar_memberfunction() { void uninitvar_memberfunction() {