walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed Cppcheck warning, condition is always true

This commit is contained in:
Daniel Marjamäki 2015-07-16 20:23:25 +02:00
parent a3fbad50cb
commit fa13179c68
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/settings.cpp
View File

@ -94,7 +94,6 @@ std::string Settings::addEnabled(const std::string &str)
return addEnabled(str.substr(prevPos)); return addEnabled(str.substr(prevPos));
} }
bool handled = false;
if (str == "all") { if (str == "all") {
std::set<std::string>::const_iterator it; std::set<std::string>::const_iterator it;
for (it = id.begin(); it != id.end(); ++it) { for (it = id.begin(); it != id.end(); ++it) {
@ -108,7 +107,7 @@ std::string Settings::addEnabled(const std::string &str)
if (str == "information") { if (str == "information") {
_enabled.insert("missingInclude"); _enabled.insert("missingInclude");
} }
} else if (!handled) { } else {
if (str.empty()) if (str.empty())
return std::string("cppcheck: --enable parameter is empty"); return std::string("cppcheck: --enable parameter is empty");
else else