Commit Graph

223 Commits

Author SHA1 Message Date
PKEuS 2a1ca20795 Fixed duplicate rows on windows when file name case differs (#2041) 2012-12-07 03:54:28 -08:00
Alexander Mai dc6d0c0dea Added Copy message Id to context menu (#4327) 2012-11-03 21:41:42 +01:00
PKEuS fc78cac797 Made several functions in GUI static or const
Fixed cppcheck message about wrong order in initializer list
2012-10-27 12:10:32 +02:00
PKEuS c56170acfa Refactorization: Avoid copying Application instances. 2012-10-27 11:35:00 +02:00
PKEuS 7ffffdfc16 Optionally display error Id in additional column and details view (#3526) 2012-10-27 11:16:52 +02:00
PKEuS 14eede1cba Show translated name of severities in ResultsTree.
Removed redundant break; from switch, removed redundant return (MSVC warning)
2012-10-21 11:37:23 +02:00
XhmikosR 85f75179ff gui: tabs to spaces and remove extra empty lines at the end of files 2012-10-12 17:46:57 +02:00
PKEuS b1a768e5ec Cleanup of includes in GUI (Removed redundant includes, use forward declarations) - Build speedup by 3% in VS10 (LINKCORE=yes, Qt 4.8.3) 2012-10-07 12:25:34 +02:00
larudwer e0c880133c on Windows Backslashes in Pathnames must be double quoted, otherwise some editors like e.c. SciTE are not able to open the file. 2012-03-04 15:53:39 +01:00
Daniel Marjamäki 87a118cd16 GUI: Recheck changed files. Ticket: #816 2012-02-14 21:16:11 +01:00
Reijo Tomperi 8cae17fda8 Update year to 2012 2012-01-01 01:05:37 +02:00
Daniel Marjamäki 6f8e42a5af changed the astyle formatting flags 2011-10-13 20:53:06 +02:00
Kimmo Varis 4c24b6a804 GUI: Rename ErrorItem::id to ErrorItem::errorId. 2011-10-12 22:19:08 +03:00
Kimmo Varis 00ae7dbda3 GUI: Move ShowTypes enum to own class and file.
We are using ShowTypes around the GUI codebase so it makes sense
to have it in its own class. And the class also contains related
helper functions instead of scattering them around different
classes.

ShowTypes also contains the visibility settings for all the
GUI severities. Implementation in this commit makes ShowTypes
class to load the visibility settings when it is created. And save
the settings when it is destroyed.
2011-10-11 22:20:36 +03:00
Kimmo Varis fe1ba6ae37 GUI: Simplify condition.
With current code we always have both filename and linenumber for
each error.
2011-07-21 20:15:24 +03:00
Kimmo Varis e3cd600e4e GUI: Fix always false condition.
Ticket: #2827 (false negative: gui/resultstree.cpp:271 condition always false)
2011-07-17 15:25:46 +03:00
Kimmo Varis aff8fbc05f GUI: Show error if no default editor configured.
There always should be default editor if there is editor
application configured. But it is possible in some cases that
default application is "lost". So check that we have default
application configured before trying to use it. And inform user
to configure default application instead of silently failing to
open the application (and the file) for the user.
2011-07-17 15:11:24 +03:00
Kimmo Varis 79385f0ff8 GUI: Fix separators when opening file to editor.
Ticket: #2916 (Wrong slashes in file path passed to the Windows-text editors)
2011-07-17 14:22:06 +03:00
Zachary Blair 79370258df Fixed #2758 ([GUI] Provide a means to filter results based on a search string) 2011-05-03 22:30:54 -07:00
Kimmo Varis f9c97c7b56 GUI: Add support for inconclusive errors.
This is the first (and quick) support for the inconclusive errors.
We simply add [Inconclusive] to begin of the summary. This is
temporary solution until better GUI is implemented. XML v1 won't
be supporting inconclusive errors. For XML v2 we need still to
decide what to do.
2011-04-16 14:07:33 +03:00
Kimmo Varis 91345234e0 GUI: Refactoring application definition.
Using Application class as method parameters instead of separate
application attributes.
2011-04-02 16:30:47 +03:00
Kimmo Varis 292984db39 GUI: Simplify handling applications with spaces in paths.
Earlier user had to add quotation marks around application executable
path in application dialog. Because we could not determine which part
is path and which part is parameters. As we now have separate
variables we can automatically add the quotation marks when needed
before starting the application. This reduces the confusion users
have had about the correct formatting of paths.
2011-04-02 12:30:21 +03:00
Kimmo Varis 1f7d9145b0 GUI: Have separate setting for editor app path and params.
Currently combined editor application path + params is a bit
problematic (at least in Windows). We really don't know where the app
path ends and parameters start. So proper quoting is not always
possible.

And application path and command line parameters are clearly
different settings anyway. So make them separate settings. It has
bunch of other positive sides too. Like one can now browse new path
for the application without loosing the parameters.

When starting Cppcheck version with these new settings user is warned
that loading settings had problems and asked to check and fix the
settings.
2011-04-02 12:30:16 +03:00
Kimmo Varis d9efd53033 GUI: Add back translation of severity texts.
Translation of severity texts was temporarily disabled by earlier
commits. Now adding new method to ResultsTree for getting
translated severity string.
2011-03-07 23:35:58 +02:00
Kimmo Varis 0d27966eb8 GUI: Update more severity conversion methods. 2011-03-07 23:11:59 +02:00
Kimmo Varis 5bf98447c9 GUI: Make Severity to ShowType use enum values.
Continue converting Severity use in GUI from QString to enum
values.
2011-03-07 22:36:47 +02:00
Kimmo Varis d2c06501d9 GUI: Convert severity in ErrorLine to enum value.
This commit continues converting severity in GUI to enum.
2011-03-07 21:20:09 +02:00
Kimmo Varis 7c589384d2 GUI: Use severity enum in ErrorItem.
Convert from using string to enum values for severity in ErrorItem.
Storing and handling severity as string was the easy way earlier
but it is not convenient or efficient way to handle severities.
This commit is the first step in converting severity handling to
use the enum values instead of strings.
2011-03-07 21:10:30 +02:00
Kimmo Varis e6e616e542 GUI: Fix opening error item with default app. 2011-02-25 12:16:20 +02:00
Erik Lax a1c1234596 Fixed: #2460 (GUI: Errors are sorted by line number alphabetically instead of numerically) 2011-02-11 21:03:39 +02:00
Reijo Tomperi 226b605774 Change year 2010 -> 2011 in license texts. 2011-01-09 21:33:36 +02:00
Kimmo Varis 2a93aa9fce GUI: Convert path to native separators before copying it.
Ticket #2424 (Windows GUI: "Copy full path" doesn't copy the visible full path if it has been changed in preferences)

We keep paths internally with / separator and only convert to native
separators (for Windows) when showing them. Conversion was missing
from path copying function.
2011-01-06 20:36:35 +02:00
Kimmo Varis f150f1ba05 GUI: Add GUI for showing 'portability' warnings.
Add menuitem, icon and toolbar button for portability warnings.
Ticket #2359 (Gui: Show portability warnings).
2010-12-27 11:06:31 +02:00
Kimmo Varis a73970483d GUI: Add "Information" errors items to menu and toolbar. 2010-12-26 15:23:55 +02:00
Kimmo Varis 84180e4fcd GUI: Change Style-warnings icon.
I want to use the current Style-warning icon for Information
messages. So change the Style-warning icon first to new
icon.
2010-12-26 15:23:54 +02:00
Kimmo Varis 31c974c954 GUI: Add Information-severity support. 2010-12-26 15:23:54 +02:00
Kimmo Varis 9186cd8503 GUI: Add partial support for portability severity.
Add 'backend' support for the new 'portability' severity. The new
severity is handled, converted to new SHOW_PORTABILITY and added
with correct type to the result view.

There is no menuitem/toolbar button to show/hide portability
items. Likewise there is no line for portability issues in stats-
dialog.

Ticket #2106 (More severities and new xml format)
2010-12-13 11:25:45 +02:00
Kimmo Varis 8e8e1d1d72 GUI: Collect statistics about amount of different severities.
Add new class for collecting statistics per each error severity. Add
a new tab to Statistics-dialog for these numbers.
2010-11-30 22:50:57 +02:00
Kimmo Varis e0702d3ef8 GUI: Allow selecting multiple items in results tree.
If multiple items are selected then other than "Hide" context menu
items are disabled.
2010-11-28 23:26:53 +02:00
Kimmo Varis 458af3c931 Merge branch 'error-details'
Conflicts:
	gui/resultstree.h
	gui/resultsview.cpp
2010-11-24 17:24:36 +02:00
Zachary Blair 6b9d9188c9 Fixed #1861 (GUI: Allow hiding error) Disabled menu item when not applicable 2010-11-24 00:48:07 -08:00
Kimmo Varis 0da55d6477 GUI: Improve updating details view.
After previous patches the details view was only updated when the
item was clicked with mouse. This patch improves the updating and
now it works also when changing selected item using keyboard.
2010-11-23 22:37:31 +02:00
Kimmo Varis 20334815c6 GUI: Remove Message-column from the error tree view.
The full detailed message is shown in the own panel below error tree.
2010-11-22 23:32:04 +02:00
Zachary Blair a16c0dbd5e Fixed #1861 (GUI: Allow hiding error) 2010-11-21 10:55:34 -08:00
Kimmo Varis 3fba8b52c0 GUI: Right-align line number. 2010-11-19 23:11:40 +02:00
Kimmo Varis a0a1ad806a GUI: Add tooltips for error items. 2010-11-19 22:54:40 +02:00
Kimmo Varis 3226281c59 GUI: Add new "Summary" column to results.
Summary column contains the short message core produces.
2010-11-11 23:15:06 +02:00
Kimmo Varis 999e446777 GUI: Add new short summary to error structures.
Also rename 'msg' in structures to 'message' for consistency.
2010-11-11 22:51:00 +02:00
Kimmo Varis c80c709d7e Add missing include lines. 2010-10-31 13:26:23 +02:00
Kimmo Varis 3ad4067262 GUI: Fix saving new error categories names. 2010-10-28 20:04:35 +03:00
Kimmo Varis 23eb8c41eb GUI: Add icons for warning/performance categories and add them to toolbar. 2010-10-18 21:35:35 +03:00
Kimmo Varis bee8d15848 GUI: Add support for warning and performance -error types. 2010-10-18 20:50:34 +03:00
Kimmo Varis 0fd51a814f Fix ticket #2041 (GUI: duplicate messages because file name case different) 2010-09-10 17:42:14 +03:00
Robert Reif 483a3ddfe1 Fixed #1925 (fix some cppcheck warnings in cppcheck) 2010-08-10 07:26:59 +02:00
Kimmo Varis c3dfe1a356 GUI: Fix bug that every error item got own parent item.
The code could not find existing parent item since items have paths
with native separators and search was done with non-native path
separators.
2010-07-18 13:17:21 +03:00
Kimmo Varis c606dc8403 GUI: Show paths with native separators in result tree.
GUI used to show paths with / separator which is not native
separator in Windows. So lets convert shown paths to native
separators before adding them to the GUI.
2010-07-17 20:26:24 +03:00
Kimmo Varis 801afae88b GUI: Refactor linenumber in ErrorLine to unsigned int. 2010-07-12 01:51:36 +03:00
Kimmo Varis c9d63fa454 GUI: Remember user-selected base path.
Remember the base path user selects when opening files from loaded
XML report.
2010-07-11 16:20:19 +03:00
Kimmo Varis b8793b1529 GUI: Ask file location from user if not found.
When loading report from XML there is no full paths so the file's real
path is not known and cppcheck cannot open it. So if the file has no
absolute path then we ask where the file is located from the user.
2010-07-11 14:22:55 +03:00
Kimmo Varis 9a5166075f GUI: Fix line numbers and filenames in errors.
When converting to use new ErrorItem and ErrorLine I made few mistakes
in how I handled the data. And for some reason there was not even
warnings about converting integers to QStrings.
2010-07-11 01:07:40 +03:00
Kimmo Varis faa483b8d0 GUI: Use integer list instead of variant list for line numbers. 2010-07-10 20:54:33 +03:00
Kimmo Varis 2f0202d105 GUI: More refactoring to use ErrorItem and ErrorLine. 2010-07-10 20:30:31 +03:00
Kimmo Varis 0e9d0e9bde GUI: Refactor error data passing to use own class. 2010-07-10 18:20:45 +03:00
Kimmo Varis 5d55bc0581 GUI: Remove remains of "possible error". 2010-07-03 12:58:56 +03:00
Kimmo Varis 35e655590c GUI: Remove remains of "all style".
Earlier "all style" was just removed as menu item but all the code related
was left in place. This commit actually removes the now unneeded code.
2010-07-03 11:48:25 +03:00
Daniel Marjamäki c718a7c595 astyle: Update to astyle 1.24 2010-04-15 20:08:51 +02:00
Reijo Tomperi 35d2a27b9c Update copyright year in all source files 2010-04-13 22:23:17 +03:00
Daniel Marjamäki 0cad22314e Reverted 'astyle fix'. Those changes are not in sync with my astyle configuration/setup. 2010-04-02 07:30:58 +02:00
Martin Ettl 193aa7d1d3 astyle fix 2010-04-02 02:21:53 +02:00
Martin Ettl 2e7a4c7b75 gui:added an right-click option "copy message" 2009-12-06 17:46:24 +01:00
Daniel Marjamäki 4e340d556d Robert Reif: initialize array (#366) 2009-11-24 17:25:27 +01:00
Reijo Tomperi d5e7d688d2 Fix #864 (GUI fails to open second position for multi-line errors)
Apply patch from robertreif
http://sourceforge.net/apps/trac/cppcheck/ticket/864
2009-11-20 00:43:46 +02:00
Daniel Marjamäki 40f2265abf robertreif: Fixed #442 (Filter duplicate errors in GUI) 2009-11-16 17:09:30 +01:00
Daniel Marjamäki 9207f7ade5 robertreif: Fixed #726 (GUI: Fix quoting of paths with spaces in Windows) 2009-11-16 17:02:28 +01:00
Reijo Tomperi fdde2182b9 Fix GPL comments in all files. ">." was missing from the end. 2009-09-27 18:08:31 +03:00
Kimmo Varis f6d2445e16 Add 'possible style error' severity for the GUI.
Fixes ticket #436 (GUI: All style -severity). The possible style errors can be now selected visible / hidden so all severities have their own menu item.
2009-08-02 15:00:22 +03:00
Kimmo Varis 2fb3b187f0 GUI: Fix GUI to recognize and use "possible error" type (was "all" earlier). 2009-07-31 22:12:05 +03:00
Kimmo Varis 635acfa2ab GUI: Remove security-category.
The security-category was removed from core in commits 03f3ee62a0 and 11bc5195b8.
2009-07-13 16:47:38 +03:00
Kimmo Varis 81ab6a75c3 Fix ticket #456 (GUI:: save only the results selected in view settings)
http://sourceforge.net/apps/trac/cppcheck/ticket/456
2009-07-04 22:29:48 +03:00
Kimmo Varis 3b1c9098b8 GUI: Show instructions instead of error when viewer application is not configured. 2009-07-03 17:46:39 +03:00
Kimmo Varis df7ca21a31 Astyle fixes. 2009-07-02 18:57:09 +03:00
Vesa Pikki 1daba9e913 Error types are now translated aswell. 2009-07-02 13:48:32 +03:00
Vesa Pikki 4206a9d218 Toolbar can now be hidden.
Treeview's headers will now be translated when language changes.
2009-07-02 11:46:26 +03:00
Vesa Pikki ebfa55b1c3 Began adding translations and using Qt Designer .ui files.
Also added QSetting value names to common.h

Work is halfway on both translations and .ui files.

I added a very quick and rough finnish translation.

The program now requires the translation files to be created before running
that can be done with lrelease gui.pro.

To compile the whole GUI one must do the following
cd gui
qmake
lrelease gui.pro
make
2009-07-02 11:33:28 +03:00
Kimmo Varis b245b7a832 GUI: Do not make settings names translatable.
Having translated settings names is a bad idea. If user changes GUI language one loses settings. Also settings might be exported/imported and translated names might not work between systems/users.
2009-07-02 02:02:34 +03:00
Kimmo Varis 23b816f43b Astyle fixes. 2009-07-01 23:47:38 +03:00
Kimmo Varis 64f304684f GUI: Remove GUI for showing unused functions.
Implements ticket #443 (Remove checking of unused functions from GUI) https://sourceforge.net/apps/trac/cppcheck/ticket/443
See also ticket #434
https://sourceforge.net/apps/trac/cppcheck/ticket/434
2009-06-27 10:41:30 +03:00
Kimmo Varis 678714419c GUI: Refactor report saving.
Refactoring report writing to own classes and using QT's XML classes for XML output. This also fixes the ticket ##408 (GUI generates invalid xml).
https://sourceforge.net/apps/trac/cppcheck/ticket/408
2009-06-24 10:54:56 +03:00
Kimmo Varis 2adfd3607d GUI: Enable clearing/saving results also if there are only hidden results.
This commit fixes a bug in my earlier commit that only checked visible results.
2009-06-20 23:42:12 +03:00
Kimmo Varis 0792d89a6b GUI: Disable result cleaning and saving during the checking. 2009-06-20 23:05:17 +03:00
Kimmo Varis 7bbdc8382a GUI: Add new context menu items to copy filename/full path to clipboard. 2009-06-14 15:09:52 +03:00
Reijo Tomperi 170f4cf788 Fix compile error in GUI 2009-06-09 22:42:13 +03:00
Kimmo Varis 7efd4e48b8 GUI: One messagebox was missing "this" parameter. 2009-06-09 17:03:38 +03:00
Vesa Pikki b67424785f Added messagebox to inform user about not found/non visible errors. 2009-06-09 10:51:27 +03:00
Vesa Pikki de0bea3479 Merge branch 'master' of git@github.com:danmar/cppcheck 2009-06-09 09:31:54 +03:00
Vesa Pikki 814cd37c90 Added some warning messageboxes.
One for when user tries to double click and there are now applications specified.
Another for when user tries to check something and the file list is empty.
2009-06-09 09:30:28 +03:00
Kimmo Varis 7ac73e0d25 GUI: Show error message when the viewer application cannot be started. 2009-06-08 16:47:53 +03:00
Kimmo Varis 9b5350e369 GUI: Enable sorting in results view. 2009-06-04 17:46:19 +03:00
Vesa Pikki a330e9c35f Added the initial version of saving results to a file. 2009-06-03 21:18:22 +03:00
Kimmo Varis a89380e93d GUI: Include result tree icons to resource (and executable). 2009-06-02 00:06:44 +03:00
Reijo Tomperi 58eda6e978 Fix ticket #325 (Replace developer names in source files with AUTHORS file)
http://apps.sourceforge.net/trac/cppcheck/ticket/325
2009-05-30 08:48:12 +03:00
Kimmo Varis d73ab89c93 Add icon files to resource file.
Having resource files compiled in the executable makes installing the application easier (especially on Windows).
2009-05-28 11:32:32 +03:00
Vesa Pikki 4f41adf45e Astyle formatting. 2009-05-26 18:23:06 +03:00
Vesa Pikki 76c7290e12 Added 22x22 icons from http://tango.freedesktop.org.
Also added icon source to AUTHORS file.
Also added toolbar with the default actions.
Added icons to result files and errors.
2009-05-26 18:21:39 +03:00
Vesa Pikki de0dd0a2bb Fixed issues pointed out by Reijo.
The number of threads is now atleast 1.
Added a very simple about dialog with version number and license.
Replaced all CppCheck's with Cppcheck.
Renamed "show more errors" to "show possible false positives" in the menu.
User created application now has to have a name and a path.
2009-05-24 11:53:29 +03:00
Vesa Pikki 2d8b08d4ab Added more comments to class members and methods. 2009-05-23 19:29:24 +03:00
Vesa Pikki 2b7bf671d7 Now starts the default application by double clicking the error. 2009-05-23 18:45:05 +03:00
Vesa Pikki 70c32c10e4 Added the initial version of opening a error with user specified application. 2009-05-23 14:26:04 +03:00
Vesa Pikki ae7fc7fe3e When adding a new error, only hides it and doesn't check all errors. 2009-05-23 11:33:38 +03:00
Vesa Pikki f0a26b3ffe Results tree now uses only QStandardItemModel for data storage.
Items are now hidden from the tree and the tree is not recreated everytime it is refreshed.
Also added test.cpp as a sample data for GUI testing.
Added Check all and uncheck all buttons to menu to show/hide all errors more easily.
2009-05-23 11:17:27 +03:00
Vesa Pikki f752cca1e2 Merge branch 'gui'
Conflicts:

	gui/resultstree.cpp
2009-03-22 19:42:45 +02:00
Vesa Pikki 1e66d7f0e4 Merge conflicts. 2009-03-22 19:41:32 +02:00
Vesa Pikki 855dda69b7 Conflicts:
gui/mainwindow.cpp
	gui/resultstree.cpp
2009-03-22 19:40:29 +02:00
Vesa Pikki 0953995ee3 Merged gui branch to master. 2009-03-22 19:39:44 +02:00
Vesa Pikki 55ad06a7b2 Astyle formatting. 2009-03-22 19:38:03 +02:00
Vesa Pikki 856b3cd949 Can now hide and show results based on cpp flags. 2009-03-22 19:37:26 +02:00
Vesa Pikki c6e8d61db3 Added recheck and clear results buttons. 2009-03-22 17:42:48 +02:00
Vesa Pikki 84853aa7f9 Added recheck and clear results buttons. 2009-03-22 17:40:47 +02:00
Vesa Pikki f04bdccee4 Astyle formatting. 2009-03-22 15:15:16 +02:00
Vesa Pikki 5e1994068a Added settings dialog to select what kind of errors are visible. 2009-03-22 14:32:07 +02:00
Vesa Pikki e629db6818 Now adds directory contents to list of files to check.
Only adds proper (.cpp,.c,.cpp,...) files to the list of files to check.
Modified checkthread to clear results after each file.
2009-03-02 19:56:51 +00:00
Vesa Pikki cc6cec091a Began implementing ThreadExecutor with Qt threads. Still a work in progress.
Added tr to all strings.
2009-03-01 20:44:42 +00:00
Vesa Pikki b39c15410b Began implementing a simple Qt based GUI.
Also modified astyle scripts to format gui code aswell.
2009-03-01 07:38:21 +00:00