83be203d44
Merge pull request #2715 from rikardfalkeborn/refactor-use-visitastnodes-more
...
Refactor use visitastnodes more
2020-07-21 15:26:58 +02:00
26c849b732
Merge pull request #2716 from rikardfalkeborn/refactor-use-simple-loop-instead-of-stack-in-checktype
...
Refactor: Simplify checkSignConversion
2020-07-21 15:26:03 +02:00
4ab04db53c
Rename 'cppcheckID' to 'hash'
2020-07-21 11:27:03 +02:00
7973fd843c
Refactor: Simplify checkSignConversion
...
The loop only checks astoperand1 and astoperand2. Simplify the condition
to loop over these instead of using a stack. Also, add a testcase for
when astoperand2 is negative.
2020-07-20 11:16:56 +02:00
ed36856451
Refactor: Use visitAstNodes in checkuninitvar
2020-07-20 11:03:52 +02:00
9ced26a7a1
Refactor: Use visitAstNodes in checkcondition
2020-07-20 11:03:29 +02:00
82fe6193fa
Refactor: Use visitAstNodes in checkstring
2020-07-20 10:25:00 +02:00
2ace2b006a
Refactor: Use visitAstNodes in checkleakautovar
2020-07-20 10:25:00 +02:00
e2a81a382f
Track reading aliases during valueflow forward
2020-07-19 23:25:35 -05:00
4a76dbb632
Bug hunting; Avoid bailout uninit FP, stream object
2020-07-19 16:54:44 +02:00
fe0081496c
Bug hunting; Avoid bailout uninit FP, arrays
2020-07-19 16:27:56 +02:00
7e65b561f0
AST: Fix ast for 'for ((..initexpr..);;)'
2020-07-19 11:10:38 +02:00
3723c708fc
ImportProject; Do not fail loading a GUI project that has warning tags
2020-07-19 08:07:10 +02:00
e9281babc4
Bug hunting; avoid false positives for structs/classes with constructors
2020-07-18 18:54:21 +02:00
7cb65b7f67
GUI: Speedup code editor when selecting another warning in the same file
2020-07-18 18:14:55 +02:00
6bc13080ee
Simplify condition
2020-07-18 07:07:20 +03:00
382f21a5c9
Fixed crash on garbage code: comparisson with an empty second operand
...
This will fix #9774 .
2020-07-18 07:02:12 +03:00
58638d7757
Bug hunting; Fix itc.py test
2020-07-17 13:20:31 +02:00
7a4e6daecd
Fix import GUI project problem
2020-07-17 11:26:03 +02:00
f2bd603bd3
Bug hunting; Fix TestBughuntingChecks
2020-07-17 11:02:46 +02:00
592637af61
Bug hunting; Avoid uninit false positives with simple analysis
2020-07-17 09:05:38 +02:00
9af288e1dd
Fixed #9724 (GUI: The tags do not work anymore)
2020-07-16 23:03:54 +02:00
831690f89b
Use parseDecl instead
2020-07-16 14:33:39 -05:00
0632f86449
Bug hunting; avoid bailout false positives when constructor is called
2020-07-16 16:38:22 +02:00
9edbec8594
astyle formatting
2020-07-16 16:36:11 +02:00
118e9eb3e2
Better handling of CppcheckID suppressions
2020-07-16 15:27:23 +02:00
47ff29f1c8
Merge pull request #2708 from pfultz2/multi-mutex-lock
...
Handle FPs: mutexes being locked at different scopes
2020-07-16 08:35:05 +02:00
423dcfd005
Fix issue 9796: False positive: lifetime, pointer item is not deallocated by pop_back
2020-07-15 12:22:36 -05:00
6ab4f39f52
GUI: Suppress cppcheck-id
2020-07-15 13:03:07 +02:00
af0db3cc21
Add cppcheck-id for warnings. To start with it's a simple id that changes when file is changed.
2020-07-14 22:30:42 +02:00
1f74400f13
Merge branch 'revert-mutex-delete' into multi-mutex-lock
2020-07-14 13:05:14 -05:00
4373404238
Revert "Fixed #9795 (False positive: Local lock is not ineffective, mutex is locked in thread also.)"
...
This reverts commit 27841d6b81
2020-07-14 13:04:59 -05:00
a6d70b9022
Code cleanup, __temp__ files are not needed anymore
2020-07-14 16:54:00 +02:00
8d6fd4769b
Bug hunting; Terminating analysis
2020-07-14 11:22:42 +02:00
176826a1f5
Bug hunting; Avoid false positives
2020-07-14 11:15:26 +02:00
fe324aea49
Bug hunting; Detect internal error and throw exception
2020-07-14 10:25:00 +02:00
6030ab72ab
Bug hunting; Avoid some bailout false positives in uninit checker
2020-07-14 08:12:40 +02:00
e0be224f4e
Merge pull request #2709 from pfultz2/fp-duplicate-cond-this
...
Fix FP of duplicateCondition when modifying the this variable
2020-07-13 21:14:58 +02:00
b2f463dd65
Merge pull request #2707 from Ken-Patrick/fp_pointer_expressions
...
Fix some false positives when the same expression at different places…
2020-07-13 20:59:22 +02:00
519f2a537a
Format
2020-07-13 13:55:45 -05:00
33557012a1
Merge pull request #2706 from rikardfalkeborn/condition-fn-with-sizeof
...
Fix FN with known condition and sizeof
2020-07-13 20:54:25 +02:00
36b9e545ac
Bug hunting; more bailout warnings in uninit check
2020-07-13 20:23:44 +02:00
8ba714373f
Merge pull request #2704 from rikardfalkeborn/9635-memleak-with-comma-operator-in-if-statement
...
Fix #9635 (FP: Memory leak with comma operator in if-statement)
2020-07-13 20:08:57 +02:00
450bdfedf3
Fix FP of duplicateCondition when modifying the this variable
2020-07-13 12:40:01 -05:00
4465d033f6
Bug hunting; When passing uninitialized data to unknown function it is inconclusive if that would be a problem for the function or not
2020-07-13 11:43:11 +02:00
caabe56f14
Handle FPs: mutexes being locked at different scopes
2020-07-12 21:31:53 -05:00
61ccf888b3
Fix some false positives when the same expression at different places does not have the same value
...
Typically with
```
int F(int *f);
void F2(int *a, int *b) {
int c = *a;
F(a); // modifies *a
if (b && c != *a) {}
}
```
we would get the following FP:
```
[test.cpp:3] -> [test.cpp:5]: (style) The comparison 'c != *a' is always false because 'c' and '*a' represent the same value.\n
```
I guess it boils down to isSameExpression only checking that the
expression is the same (in the above case, "*a" and "*a" are indeed the
same), but there's not real check on the values.
So the patch here is a bit hackish, and we still have false negatives in
cases with dereferenced pointers.
2020-07-11 14:13:18 +02:00
d8e7e9176b
Fix FN with known condition and sizeof
...
cppcheck behaved differently if sizeof was to the left or right of the
comparison. In order to fix this, we cannot break the while loop until
all operands have been processed.
2020-07-10 23:39:16 +02:00
27841d6b81
Fixed #9795 (False positive: Local lock is not ineffective, mutex is locked in thread also.)
2020-07-10 19:24:45 +02:00
1e679cc5d1
Fix #9635 (FP: Memory leak with comma operator in if-statement)
...
When checking for comparisons in if-statements, if there are comma
operators in the if-statement, skip until after the last comma.
2020-07-09 21:31:43 +02:00
0c6aabe444
Merge pull request #2703 from rikardfalkeborn/9652-fp-function-call-cast-config
...
Fix #9652 (fp memleak with function call with cast)
2020-07-08 15:10:41 +02:00
4996ec190e
Fix #9652 (fp memleak with function call with cast)
...
When the first argument was (void *)(1), at the start of the second
iteration, arg was pointing to the "1", which caused problems for
nextArgument(), which saw the ")" as the next token and returned
nullptr, signalling that there are no more arguments.
Instead, save the first token in the argument, which makes
nextArgument() do the right thing.
2020-07-08 00:02:39 +02:00
d5345052ab
Fix #9793 (false positive, memleak with lambda)
...
Skip scopes with lambdas (similar to how checkleakautovar does). In
order to fix this when the lambda is inside a for loop, make
hasInlineOrLambdaFunction() recursive. This should be what all existing
users want.
2020-07-07 21:51:36 +02:00
686a6c7862
Fixed compiler warning
2020-07-03 17:54:55 +02:00
d2b2bae7bf
Fixed #7733 (False positive: scope of the variable can be reduced (variable is used in hidden code))
2020-07-01 08:24:52 +02:00
f56a17bf3d
Fixed #8858 (FP: identicalConditionAfterEarlyExit when there is #if)
2020-07-01 07:48:32 +02:00
ddd21a260f
Fixed #6978 (False positive: unusedLabel shown for labels that are used in some preprocessor configurations)
2020-06-30 18:26:24 +02:00
0583763cc6
Fixed #3088 (False positive: Dont report "struct or union member is never used" for structs with __attribute__((packed)) or #pragma pack(push))
2020-06-30 11:00:40 +02:00
1567ccf97b
Merge pull request #2700 from pfultz2/afterConditionFunction
...
Extend scope of afterCondition until end of function
2020-06-30 08:28:08 +02:00
c76c03c711
Replace noreturn with macro
2020-06-29 15:54:51 -05:00
67e06c18a9
Use the already available function scope
2020-06-29 15:36:01 -05:00
a412e3e1f1
Mark syntax error functions as noreturn
2020-06-29 15:33:25 -05:00
600919f624
Remove redundant conditions
2020-06-29 15:13:06 -05:00
f34ff9325a
Fixed testrunner
2020-06-29 21:53:14 +02:00
a0770f05e1
Reuse 'extractForLoopValues' in ValueFlow
2020-06-29 21:01:43 +02:00
07d8cb4f01
Extend scope of afterCondition until end of function
2020-06-29 11:55:59 -05:00
a49d277e0d
Fixed #6471 (FP functionConst - member function modifying member variable after cast (inconclusive))
2020-06-29 13:09:01 +02:00
5164d87a2e
Bug hunting; Fixed false positives for containers
2020-06-28 22:49:51 +02:00
d5b6d49d96
Fix issue 9578: false negative: (style) Condition '...' is always false
2020-06-28 15:28:08 -05:00
b5cd96cbda
ExprEngine; Rename variable
2020-06-28 21:36:56 +02:00
ad5e4fef1f
Bug hunting; improved handling of 'malloc' in uninit checker
2020-06-28 21:20:59 +02:00
6c588cc3ef
Library: Refactoring <alloc> init attribute
2020-06-28 21:01:43 +02:00
0e736e0c29
Rename BugHuntingException to ExprEngineException
2020-06-28 17:39:14 +02:00
d4bd3016da
ExprEngine; Improved handling of for loop, loop variable
2020-06-28 17:28:40 +02:00
c42c751d61
ExprEngine; Fixed testing
2020-06-28 13:41:27 +02:00
f85cdd3f77
ExprEngine: DataIndex update to get better debug output
2020-06-28 10:52:50 +02:00
bcaf792e30
Bug hunting; Fix FP for struct with uninitialized members passed to function in C
2020-06-27 22:11:12 +02:00
c7a8f5217f
ExprEngine; Fixed Cppcheck warning
2020-06-27 21:54:38 +02:00
cd49eb0978
Fix Cppcheck warnings
2020-06-27 20:59:10 +02:00
d353a4ecba
ExprEngine; copy Data => copy arrays
2020-06-27 18:09:43 +02:00
e6aa96d90f
Bug hunting; Improved uninit checking
2020-06-27 14:59:02 +02:00
303cadf99f
Bug hunting; Improved uninitData warning when unknown function is not configured
2020-06-27 14:29:29 +02:00
e19ef6ac62
Bug hunting; Improved uninit checking for function calls with constant parameter
2020-06-27 14:15:53 +02:00
d303510c78
Use value temp.maxTemplateRecursion
2020-06-27 12:57:09 +02:00
ff5a717fc6
Bug hunting; Avoid false positives for const parameter data
2020-06-27 12:17:11 +02:00
57187ef876
ImportProject: Read max template recursion configuration value
2020-06-27 10:34:02 +02:00
b09bcdc38c
Use ValueFlow for compareBoolExpressionWithInt
2020-06-27 08:13:22 +02:00
0352a5d32f
astyle formatting
...
[ci skip]
2020-06-27 07:34:48 +02:00
1ad70bbeb8
Merge pull request #2697 from pfultz2/unique_lock
...
Extend mutex checking for more locking patterns
2020-06-27 07:32:26 +02:00
c3749625f3
Merge pull request #2688 from jpyllman/fix_chklibfunc
...
not report locally declared functions as missing configuration of --check-library
2020-06-27 06:53:09 +02:00
72bdeb9307
Merge pull request #2698 from pfultz2/const-param-casts
...
Fix issue 9778: False positive: constParameter when returning non-const reference cast
2020-06-27 06:45:30 +02:00
cf475fab51
Fix issue 9778: False positive: constParameter when returning non-const reference cast
2020-06-26 15:47:59 -05:00
f5ace9ffbe
SymbolDatabase; Improved ValueType when container methods items
2020-06-26 22:47:28 +02:00
82b91869ee
Extend mutex checking for more locking patterns
2020-06-26 15:06:20 -05:00
c5f9e85ee7
GUI: Add configuration for max recursion in template instantiation
2020-06-26 17:12:02 +02:00
f569bc79f5
Merge pull request #2694 from pfultz2/pch
...
Add option to disable pch since its broken with ccache
2020-06-26 16:45:38 +02:00
98bf0d41aa
TemplateSimplifier; Clarify information message when max recursion limit is reached
2020-06-26 12:59:40 +02:00
262f44e76a
astyle formatting
...
[ci skip]
2020-06-26 12:56:56 +02:00
cb8396aaf8
Merge pull request #2696 from pfultz2/getTokenArgumentFunction-ast
...
Fix issue 9710 and 9767: Use AST to get function from argument
2020-06-26 09:50:18 +02:00
1bef6ed268
Another check for null
2020-06-25 19:12:01 -05:00
263a0364cc
Avoid null pointer dereference
2020-06-25 17:23:42 -05:00
720d882b69
Remove known arg
2020-06-25 17:20:20 -05:00
60c42b17a6
Fix known conditions
2020-06-25 15:46:30 -05:00
af6e76d623
Fixed #9787 (Better handling of user defined literals)
2020-06-25 22:06:34 +02:00
1676ad5f45
Fix issue 9710 and 9767: Use AST to get function from argument
2020-06-25 12:54:46 -05:00
ec8fbb1580
Merge pull request #2682 from pfultz2/check-mutexes
...
Add new check for incorrect usage of mutexes and lock guards
2020-06-25 16:21:36 +02:00
18a8b5bc65
Add option to disable pch since its broken with ccache
2020-06-24 18:41:16 -05:00
3c10a9c659
Update message
2020-06-24 18:09:30 -05:00
34468f3c1a
Template simplifier; Write information message when recursion limit is reached.
2020-06-24 20:30:03 +02:00
693b24d30a
Fix testrunner
2020-06-22 14:31:34 +02:00
ab14d2bc0f
exceptRethrowCopy: Fixed FP in Cppcheck
2020-06-22 12:26:41 +02:00
9b5986505e
AST; Improved ast for variable declaration with assignment
2020-06-22 08:34:31 +02:00
f792cabc2b
ExprEngine; better handling of containers
2020-06-21 21:48:36 +02:00
5497e8ed67
ExprEngine; Improved handling of stream read
2020-06-21 20:05:26 +02:00
11e2b5ea14
Bug hunting; Timeout
2020-06-21 18:28:07 +02:00
65498b5e9a
Bug hunting; Fixed hang when there is recursion
2020-06-21 15:16:05 +02:00
8ec5605bac
Merge pull request #2689 from Ken-Patrick/9769
...
9769: Improve value flow for ternary operator
2020-06-21 13:04:43 +02:00
ff445f9ca2
Bug hunting; Make cve.py happy again
2020-06-21 08:50:27 +02:00
f270ca1909
ExprEngine; Better handling of function calls
2020-06-20 23:00:39 +02:00
5a3789a23f
9769: Improve value flow for ternary operator
...
In some cases, the condition of the ternary operator is assigned a known
value after the two possible results, and in such cases, we would not
take the opportunity to assign a value to the ternary operator (and to
the other parents in the ast).
This patch adds this capability.
2020-06-20 10:29:28 +02:00
7065c5598b
Try to fix compilation with cppcheck.vcxproj
2020-06-20 09:47:35 +02:00
af45148e58
ExprEngine; Refactor and improve code. Add tests for increments.
2020-06-19 20:40:20 +02:00
06aeac75dc
Bug hunting; Fix false negatives
2020-06-19 18:38:02 +02:00
b4443aa5a0
Suppress exceptRethrowCopy false positive
2020-06-19 18:15:04 +02:00
8653c4b3a9
ExprEngine; Fix uninitialized value FP in subfunction when argument is passed by value
2020-06-19 18:05:56 +02:00
6ec15b6d7b
ExprEngine; Simple handling of increment/decrement
2020-06-19 17:35:35 +02:00
a5a3738df4
Fixed cve.py
2020-06-19 17:13:35 +02:00
f60e805798
Running astyle [ci skip]
2020-06-19 16:36:09 +02:00
c62e345340
Fix Cppcheck warning
2020-06-19 14:11:49 +02:00
f516bde744
ExprEngine; Fix TODO assertion
2020-06-19 14:05:19 +02:00
d0ac583b97
Add 'bughuntingchecks'
2020-06-19 13:16:48 +02:00
cbe038e694
ExprEngine: execute functions in same TU
2020-06-19 10:27:59 +02:00
08b0fa21a7
do not report locally declared functions as missing configuration for --check-library
2020-06-18 14:49:19 +02:00
542158d0f4
Bug hunting; checking uninitialized struct member
2020-06-18 13:49:11 +02:00
9320ac287a
only report on functions in --library files
2020-06-18 11:42:07 +02:00
f7029e62ac
Check for mor FPs
2020-06-17 17:06:06 -05:00
3f8218af1b
Removed CheckClass::operatorEq: does not 'belong'
2020-06-17 20:35:43 +02:00
c297ed8204
Better handle noreturn or throwing functions in valueflow
...
Teaching cppcheck about `BOOST_THROW_EXCEPTION` and
`boost::throw_exception`, and using noreturn information from libraries
in value flow.
This fixes false positive nullPointerRedundantCheck with the following
code:
```
void throwexception(int * buf)
{
if (!buf)
boost::throw_exception(std::bad_alloc());
*buf = 0;
}
```
2020-06-17 19:06:14 +02:00
21f76d62a1
Merge branch 'main' into check-mutexes
2020-06-17 10:45:43 -05:00
51a6af299f
Merge pull request #2683 from Ken-Patrick/cast_expandTemplate
...
Fix handling of c++ casts in template expansion
2020-06-17 09:21:01 +02:00
94f92f00fe
Merge pull request #2684 from firewave/precompiled
...
use precompiled headers if CMake supports it
2020-06-17 07:53:51 +02:00
d26593321d
Fixed Visual Studio compile error
2020-06-16 22:56:01 +02:00
4947a3b7ab
Bug hunting; review and improve handling of multi dimensional arrays
2020-06-16 22:50:45 +02:00
a49d60f0b3
use precompiled headers if CMake supports it
2020-06-16 19:56:53 +02:00
5c1a2db434
Fix handling of c++ casts in template expansion
...
Cast were not expanded properly: the `<` was not taken into account in
typeindentlevel, so we would then miss a `>`, resulting in syntaxError.
2020-06-16 19:36:04 +02:00
18225ee27e
Update text and change to warnings
2020-06-16 10:32:39 -05:00
7c9144ea47
Add to classInfo
2020-06-15 19:43:33 -05:00
172537807b
Add check for incorrect usage of mutexes and lock guards
2020-06-15 19:40:54 -05:00
6faad9cd90
Bug hunting; better handling when assigning multidimensional array in for loop
2020-06-15 22:42:45 +02:00
b36c85d8fd
Rename VerifyException to BugHuntingException
2020-06-15 22:07:32 +02:00
f5fe5ca2dd
9768: Fix ast with throw in the middle of return ( #2678 )
...
* 9768: Fix ast with throw in the middle of return
```
int f(bool x)
{
return x ? 0 : throw 0;
}
```
The `throw` part was not included in the ast, leading to an invalid
ternary operator.
* 8526: Fix ast construction for ternary operator
This tries to decide a bit more properly when ':' can be part of a
ternary operator. More precisely, there are some times when we want to
delay the construction of the ast for ':', so that it is place
accordingly to the matching '?'.
Typically, this fixes an issue with
`return val < 0 ? throw 1 : val;`,
where the ast for ':' would be constructed during as part of the
`throw`, and the ast for `?` would be invalid.
This patch is a bit of a hardcode, stating that we don't expect ':'
inside a throw, unless there is a complete ternary operator in there
(there can't be a range based for loop, a case in a switch). When we
reach ':', we know we are and the end of the `throw`.
2020-06-15 10:36:02 +02:00
2b0e4926bc
valueFlowAfterAssign: variable initialization
2020-06-14 21:14:05 +02:00
7ddb7aef7d
8526: Fix ast construction for ternary operator
...
This tries to decide a bit more properly when ':' can be part of a
ternary operator. More precisely, there are some times when we want to
delay the construction of the ast for ':', so that it is place
accordingly to the matching '?'.
Typically, this fixes an issue with
`return val < 0 ? throw 1 : val;`,
where the ast for ':' would be constructed during as part of the
`throw`, and the ast for `?` would be invalid.
This patch is a bit of a hardcode, stating that we don't expect ':'
inside a throw, unless there is a complete ternary operator in there
(there can't be a range based for loop, a case in a switch). When we
reach ':', we know we are and the end of the `throw`.
2020-06-14 18:57:18 +02:00
4023a487ff
9768: Fix ast with throw in the middle of return
...
```
int f(bool x)
{
return x ? 0 : throw 0;
}
```
The `throw` part was not included in the ast, leading to an invalid
ternary operator.
2020-06-14 14:49:10 +02:00
f69ce02c90
Running astyle [ci skip]
2020-06-14 10:06:54 +02:00
97fd51edd1
Set version to 2.1.99 / 2.2 dev
2020-06-14 07:16:14 +02:00
026bbac975
2.1: Set version
2020-06-13 17:04:26 +02:00
37245a8179
Update copyright year
2020-06-13 16:37:12 +02:00
06ed088bd0
Fix issue 9751: Wrong lifetime caused by std::function ( #2676 )
2020-06-13 10:26:54 +02:00
03b41ac987
Fix issue 9718: False positive: Parameter can be declared const when written to via stream extraction operator ( #2677 )
2020-06-13 09:20:40 +02:00
6600453b44
Try to make Travis happy
2020-06-13 07:45:31 +02:00
258d0a6ade
Running astyle [ci skip].
2020-06-12 16:08:40 +02:00
9f445fc735
Library: simplified code and added test cases for validating <valid>-tag expressions
2020-06-12 16:06:43 +02:00
a3d58a9302
std.cfg: Allow scientific floating point notation for '<valid>'-tags
2020-06-12 08:51:33 +02:00
3f1f62e078
Fixed #9746 (SymbolDatabase: Wrong valueType for return)
2020-06-10 21:13:53 +02:00
d31d778bf4
Fixed #9533 (Syntax Error: AST broken, 'for' doesn't have two operands incrementing pointer in initializer)
2020-06-09 20:57:00 +02:00
0c659a1499
Fix incorrect logic for condition ( #2675 )
2020-06-09 08:16:53 +02:00
6d796b434e
Fixed #9731 (ValueFlow: does not handle many assignments well)
2020-06-08 21:17:12 +02:00
43b30d974f
astyle formatting
...
[ci skip]
2020-06-08 00:50:45 +02:00
ca8b5f49f3
library: fixed handling of indirect attribute
2020-06-07 20:18:54 +02:00
1705d096f7
Simplify empty anonymous namespaces. ( #2673 )
2020-06-07 13:49:04 +02:00
a45c7752a5
9185: Don't syntax error on nested lambdas ( #2672 )
2020-06-07 08:58:12 +02:00
86ed860d26
Fix issue 9548: False negative: Mismatching iterators when inserting into a vector ( #2595 )
2020-06-06 17:54:56 +02:00
99ff04f617
9757: skip template parameters when computing scope ( #2670 )
...
The template parameter is confusing simplifyUsing: it does not compute
properly the scope, and we end up replace "type" in "to_string" with
"void", then later "void" is removed and we have an internal error.
2020-06-06 17:51:15 +02:00
44ff22f879
Fixed #9276 (FP literalWithCharPtrCompare)
2020-06-06 17:47:30 +02:00
120c572252
Fixed #9750 (Chained stream operation gives uninitvar error)
2020-06-06 15:24:01 +02:00
8c2c81dbcd
Fix some false positive in loop forward analysis ( #2669 )
...
* Fix some false positive in loop forward analysis
In cases like:
```
bool b();
void f()
{
int val[50];
int i, sum=0;
for (i = 1; b() && i < 50; i++)
sum += val[i];
for (; i < 50; i++)
sum -= val[i];
}
```
The forward analysis assumed the second loop was entered, and we ended
up with false positive in it:
`Array 'val[50]' accessed at index 50, which is out of bounds`
* Fix style
2020-06-05 18:06:03 +02:00
eeda0442fa
astyle formatting
...
[ci skip]
2020-06-01 08:59:34 +02:00
3109d16b42
Fix issue 9742: FP iterators3 for address of reference to vector in struct ( #2668 )
2020-06-01 08:53:08 +02:00
9772770226
Import project: Fix standard
2020-05-31 21:37:02 +02:00
eb4754b7d9
Fix issue 9587: False positive: parameter can be declared with const ( #2667 )
2020-05-31 10:10:10 +02:00
eed2e829a7
Revert "Cleanup: Removed Tokenizer::simplifyTokenList2. As a side-effect, rules for "simple" token list are now executed on normal token list." ( #2666 )
...
This reverts commit 187cde183d
2020-05-30 11:23:22 +02:00
187cde183d
Cleanup: Removed Tokenizer::simplifyTokenList2. As a side-effect, rules for "simple" token list are now executed on normal token list.
2020-05-29 21:21:07 +02:00
eb9576cdf8
CLI: 'simple' rules are deprecated, support will be removed in Cppcheck-2.5
2020-05-29 14:20:46 +02:00
bf69541369
Visual Studio: Use new files precompiled.h with several common includes for core and testrunner.
...
- CLI+Core: Reduces build time by 55% from 3:53 to 1:47
- Testrunner: Reduces build time by 27% from 1:40 to 1:13
2020-05-29 12:16:04 +02:00
67115491ea
Fixed #9739 (Tokenizer: simplifyTypedef: wrong simplification in using)
2020-05-29 11:16:49 +02:00
7ff692341e
Fixed #9730 (Regression: TEXT macro not handled in windows code)
2020-05-28 22:03:16 +02:00
79c3af56e4
fix 9296: false negative uninit variable ( #2663 )
2020-05-28 21:28:18 +02:00
d64631219b
Fixed #9741 (Wrong value for sizeof)
2020-05-28 21:24:48 +02:00
c9798590ba
Fix issue 9701: False positive. 3rd expression in for uses comma operator. ( #2664 )
2020-05-28 07:41:47 +02:00
27fc5f1a2f
Fix Cppcheck warning
2020-05-27 21:31:40 +02:00
208e2c7fdf
Clang parser; only set cpp std if path is c++
2020-05-27 21:06:27 +02:00
f482eb49cd
ExprEngine; Fixed bug. Constraint expressions must be boolean
2020-05-27 19:37:07 +02:00
3a90341961
some CMake cleanups and additions ( #2639 )
2020-05-27 05:15:46 +02:00
6a7eada417
Reverted and fixed changes in version.h
2020-05-26 23:29:12 +02:00
4d5fe6ec5e
astyle formatting
...
[ci skip]
2020-05-26 23:28:19 +02:00
72f9fcefbb
Update version '2.0 dev'
2020-05-26 21:25:45 +02:00
60c7b66636
Clang import; do not use FileSettings::cppcheckDefines() when Clang parser is used
2020-05-26 20:46:41 +02:00
4f68d85633
optimized non-matchcompiled Token::simpleMatch() a bit ( #2640 )
2020-05-26 20:13:56 +02:00
dc0b68d505
handle clang type 'x < y::z >' better
2020-05-26 17:37:33 +02:00
39fec386a1
Import project: Add stdcpp20 and stdcpplatest
2020-05-26 08:53:37 +02:00
d70911c801
ImportProject: Read --std settings from vcxproj file
2020-05-25 21:43:24 +02:00
f7f26ffe90
Tokenizer: Better handling of c alternative tokens in const method
2020-05-25 15:07:23 +02:00
f7bff1a272
Import project: Avoid NULL pointer dereference
2020-05-24 21:39:18 +02:00
e448cc68b5
Import project: Speed up if --file-filter has been provided
2020-05-24 21:23:49 +02:00
ff17cc2e8f
astyle formatting
...
[ci skip]
2020-05-24 10:52:58 +02:00
31324573fa
Clang import; Update ast dump flags. Use -Xclang.
2020-05-24 10:52:43 +02:00
bbe6157e16
Fix issue 9712: False positive: Returning pointer to local variable when return line implicitly cast to return type ( #2662 )
2020-05-23 23:12:00 +02:00
084529575f
Skip ast validation inside template ( #2661 )
2020-05-23 21:11:08 +02:00
5a4b309e6f
Bug hunting: Add 'buffer overflow' check. Detect CVE-2019-19334
2020-05-23 17:50:24 +02:00
c1f762b861
disabled some Visual Studio warnings ( #2635 )
2020-05-23 17:42:56 +02:00
820a9c29c1
ExprEngine: Return instead of Throw to continue analysis more
2020-05-23 11:43:30 +02:00
e5a3dc1a0c
ExprEngine; Slow processing
2020-05-23 11:31:12 +02:00
4e2f8d5d48
astyle formatting
...
[ci skip]
2020-05-23 07:30:22 +02:00
5c3474ec5c
Renamed hasReturnFunction to hasNoreturFunction
2020-05-23 07:30:05 +02:00
37bc0483a4
made check.h less heavy ( #2633 )
2020-05-23 07:16:49 +02:00
0832830a95
Fix issue 9721: ValueFlow: Comparison is always false, but ValueFlow says it is always true ( #2658 )
2020-05-23 07:15:13 +02:00
4270819728
Fix issue 9713: FP invalidContainerLoop when modifying container and immediately exiting the loop ( #2659 )
2020-05-23 07:14:45 +02:00
6162ebd608
Fix issue 9714: FP invalidContainer related to auto and std::string::insert ( #2660 )
2020-05-23 07:13:55 +02:00
526abd4b52
Fix issue 9738: ValueFlow: handle std::tie better ( #2657 )
2020-05-22 22:57:20 +02:00
c86cfdaa50
Fixed #9736 (False positive: knownArgument in assert calls)
2020-05-22 11:49:28 +02:00
43b58dbc9e
Fixed #9729 (AST: lambda with noexcept)
2020-05-22 11:29:10 +02:00
ac1ceb85b6
AST: improved AST when expression starts with %char% or %str%
2020-05-22 09:35:55 +02:00
4c5310433c
astyle formatting
...
[ci skip]
2020-05-22 08:48:28 +02:00
ffdf13fcdb
AST: A little code cleanup
2020-05-22 08:48:06 +02:00
8301fa8244
Fix issue 8144: valueFlowBeforeCondition: struct ( #2645 )
2020-05-21 08:47:48 +02:00
a9d8b3495d
feat: add modulo of one check ( #9528 ) ( #2650 )
2020-05-20 23:01:32 +02:00
662745b504
Fixed several coverity messages
2020-05-20 18:54:16 +02:00
a96a879b6d
Fix crash in addons/test/test-misra.py ( #2652 )
2020-05-20 16:02:13 +02:00
79d3f488da
Pass defines flags when calling clang ( #2651 )
2020-05-20 14:56:55 +02:00
299e11c991
Fixed Cppcheck warnings
2020-05-19 21:55:28 +02:00
dc701276de
Optimizations to ValueFlow and ForwardAnalyzer:
...
- Remove errorPath of a value on assignment (this fixes enormous memory consumption for code with many subsequent assignments)
- De-virtualized a simple get function that was virtual for no reason
- Cloned function isAliasOf() for single values to avoid instantiating unnecessary std::list objects (
- Replaced a couple of trivial Token::Match/simpleMatch expressions by direct comparison
- Treat enumerators as literal values
2020-05-19 21:07:04 +02:00
64291c6b61
fix Clang execution
2020-05-19 19:17:23 +02:00
32e569704b
executeCommand in CppCheckExecutor or QCheckThread
2020-05-19 16:04:40 +02:00
baca1fbe04
Fixed compilation: Added missing include
2020-05-19 14:32:50 +02:00
22884888fb
Optimization: Improved performance of ForwardAnalyzer by adding some pre-checks and combining conditions
2020-05-19 13:48:15 +02:00
c155062cf2
Optimization: Speed up SymbolDatabase creation and Tokenizer::findGarbageCode() by using Token::isKeyword() for pre-checks
2020-05-19 13:48:15 +02:00
f6788c0472
Fixed Token::isKeyword: Actually set this flag to a reasonable value in all code paths
2020-05-19 13:47:25 +02:00
c9d8f607df
Optimization: Reduced peak memory usage (30% in my test case) by immediately deleting simplecpp::TokenList while creating the cppcheck TokenList.
2020-05-19 12:08:17 +02:00
d78ff975a0
Run dmake
2020-05-19 10:11:56 +02:00
37646c9ffb
revert accidental mode changes
2020-05-19 10:05:14 +02:00
09a30bd6b5
Optimization: Speed up Tokenizer::findGarbageCode() (by 15% in my test case) by avoiding iterating through token list multiple times
2020-05-19 08:54:47 +02:00
a9cea9ad7c
Fixed compilation (next attempt): Added more missing includes
2020-05-19 08:53:38 +02:00
f0ac0c8675
Optimization: Remove simplecpp::TokenList as soon as cppecheck TokenList was created. This saves memory while checks are running (20% in my test case), although not peak memory
2020-05-19 08:41:05 +02:00
ade253a730
Optimization: Reduced memory consumption of token list
...
- allocate memory for mTemplateSimplifierPointers only if necessary
- reordered member variables in TokenImpl
2020-05-19 08:40:24 +02:00
c409daf918
Fixed compilation: Added missing include
2020-05-19 08:38:51 +02:00
4948f85460
Visual Studio: Updated solution
...
- Enable several compiler warnings again
- Let __cplusplus have a reasonable value
2020-05-19 08:35:13 +02:00
d6390dbd14
Optimization: Improved performance of simplifyTypedef for code with lots of typedefs
...
20% performance gain when checking ExtremeTuxRacer sourcecode (with glext.h available)
2020-05-19 08:35:13 +02:00
32923b7ac5
Refactorization: Fixed a couple of compiler warnings about reusing variable names
2020-05-19 08:35:12 +02:00
793ed68029
Refactorization: Moved code from header to source
...
- from utils.h to new utils.cpp
- from token.h to token.cpp
- from valueflow.h to valueflow.cpp
- from errorlogger.h to errorlogger.cpp
2020-05-19 08:35:12 +02:00
65e9f6210c
CLI: Tweak execution of python addons
2020-05-19 08:14:56 +02:00
259724d6e3
astyle formatting
...
[ci skip]
2020-05-18 19:53:35 +02:00
7bfd686f04
Fix #9700 duplicateBranch false positive from missing scope operator :: in ast ( #2646 )
2020-05-18 19:31:13 +02:00
f6f489ea49
Try to make AppVeyor happy
2020-05-18 09:51:47 +02:00
aa7a4b8372
Try to make AppVeyor happy
2020-05-18 08:24:17 +02:00
a0f2fda53a
Addons: If normal python fails, try 'python'
2020-05-18 07:44:46 +02:00
2ef538c171
Tweak paths when executing addons in Cppcheck
2020-05-17 21:45:37 +02:00
9eda399323
Less strict unknownMacro
2020-05-17 19:12:16 +02:00
547d1b158e
Fixed #9723 (GUI: inline suppressions does not work for addons)
2020-05-17 16:50:13 +02:00
871cf379d5
ExprData: Better handling of ternary operator
2020-05-15 21:34:52 +02:00
76f4fae806
Bug hunting; Started to activate some itc tests for uninitialized variables
2020-05-15 20:58:33 +02:00
57e9036186
Cppcheck --addon command should use python3 by default. It can be overridden if needed.
2020-05-15 14:33:35 +02:00
e508950f4f
ExprEngine; Activate bug hunting analysis for uninitialized variables/data. This analysis is pretty experimental right now.
2020-05-15 11:25:56 +02:00
275c8e84d2
Set development version 2.0.99
2020-05-15 11:15:34 +02:00
2fd2edd3f9
astyle formatting
...
[ci skip]
2020-05-14 18:18:14 +02:00
a0317477c9
utils.h: avoid unnecessary string creation in isStringCharLiteral() ( #2638 )
...
* utils.h: avoid unnecessary string creation in isStringCharLiteral()
reduces Ir from 541 to 63 in a test
* dmake
2020-05-14 14:45:35 +02:00
d123279fc1
Fix issue 9709: ValueFlow: variable value is not known ( #2643 )
2020-05-14 14:10:32 +02:00
0799d74071
Tweak Z3 version checks
2020-05-12 17:01:16 +02:00
3e650c311b
Remove NEW_Z3 macro
2020-05-12 16:57:07 +02:00
046f8eb6c6
ExprEngine: improved handling when lhs/rhs for && has unknown value
2020-05-10 22:50:23 +02:00
e0e50139cb
cleaned up includes based on include-what-you-use ( #2632 )
...
* cleaned up includes based on include-what-you-use
* token.cpp: fixed -Wextra-semi-stmt warning
2020-05-10 16:45:45 +02:00
dc32f428ff
Set Cppcheck version
2020-05-10 11:28:31 +02:00
08ddd84780
Update copyright year
2020-05-10 11:16:32 +02:00
3e0218299b
Revert "Update copyright year"
...
This reverts commit 6eec6c4bd5
2020-05-10 11:13:05 +02:00
6eec6c4bd5
Update copyright year
2020-05-10 11:11:34 +02:00
137f262300
Fix Token::isImpossibleIntValue
2020-05-09 10:30:19 +02:00
d4169f04d5
Bug hunting; Avoid false warnings for impossible values
2020-05-08 17:42:56 +02:00
ab8bf81f03
ValueFlow: Try to clarify debug output for impossible values
2020-05-08 16:13:55 +02:00
02d88cb191
Travis: Run TestExprEngine tests
2020-05-08 12:21:22 +02:00
4779cb124e
Fixed #9649 (False positive: uninitialized struct member)
2020-05-07 22:27:18 +02:00
00d1091506
Tokenizer: operator handling, fix tests
2020-05-04 23:00:51 +02:00
06cb0e99d1
Tokenizer: Fix syntax error when operator* is called
2020-05-04 21:33:30 +02:00
8c57055a0b
Try to make Travis happy
2020-05-03 20:46:29 +02:00
b5094f298a
Bug hunting; Add new 'incomplete' flag for error messages. Used when analysis is incomplete.
2020-05-03 17:20:38 +02:00
4c63940902
Add bug hunting test case for CVE-2019-7156
2020-05-02 22:22:31 +02:00
5eeeba97eb
SymbolDatabase: Better handling of function pointer function argument
2020-05-02 17:04:54 +02:00
56abbc1d42
Fixed segmentation faults
2020-05-01 18:10:18 +02:00
34572a40ab
Bug hunting: Fixed handling of switch 'case %char%'
2020-05-01 15:15:24 +02:00
999ef06156
ExprEngine: Try to handle function with unknown type better
2020-04-30 22:10:30 +02:00
b27fabaacb
Refactoring ExprEngine
2020-04-30 21:49:27 +02:00
b97250e0fa
ExprEngine; Try to handle assignments better
2020-04-30 21:05:34 +02:00
5a9e81897a
ExprEngine: Document how it works
2020-04-30 12:18:49 +02:00
e30eabc896
ExprEngine: Fail to execute contract => write error message
2020-04-29 18:30:12 +02:00
daea5e2d6c
Bug hunting: Do not warn about 'Division by zero' when variable is uninitialized
2020-04-29 11:00:33 +02:00
5d67fd0e56
Bug hunting: Set 'inconclusive' flag for bailout values
2020-04-29 10:58:01 +02:00
3eb19a64cb
Removed inline suppression, it was not a FP, use #ifdef differently
2020-04-28 22:29:16 +02:00
13e79fdeb6
Temporary inline suppression to hide false positive
2020-04-28 22:21:07 +02:00
249a101ec2
Travis: Fix naming
2020-04-28 22:18:02 +02:00
12dfd8a5ca
GUI: Show missing/added contracts in tab
2020-04-28 22:09:01 +02:00
dab8b9fd31
ExprEngine: Improved checking of contracts in function calls
2020-04-28 17:16:13 +02:00
Daniel Marjamäki
Rikard Falkeborn
Paul
Georgy Komarov
Ken-Patrick Lehrmann
orbitcowboy
Jens Yllman
firewave
Simon Martin
PKEuS
miltolstoy
amai2012
Philipp Kloke
shaneasd
versat