a765a1310d
ValueFlow: omit unnecessary location information from `valueFlowBailoutIncompleteVar` ( #5583 )
...
This is unnecessary since we only issue it from a single location. It
also leads to a lot of unnecessary noise in the daca diff reports.
2023-10-23 10:13:10 +02:00
3103736c51
refs #11928 / refs #10045 / fixes #11794 - generate `limits.h`/`climits` defines from platform ( #5414 )
2023-10-21 17:21:12 +02:00
26ba29c303
Fix #12086 FN passedByValue with index operator and namespaced function call ( #5574 )
2023-10-21 12:41:39 +02:00
f4d18a8d1e
#12077 FP constStatement with ctor in namespace ( #5572 )
2023-10-21 12:12:56 +02:00
27bd972832
test/CMakeLists.txt: updated the test fixture costs ( #5565 )
2023-10-21 09:15:22 +02:00
7086ffaa1b
fixed #12045 - print error when using an option which has not been compiled in instead of treating it as non-existent or a no-op ( #5508 )
...
Also disabled more internal code around those options and did some
cleanups.
2023-10-21 09:12:59 +02:00
41bd28c0b3
Fix #12087 Library: add Container::Action::FIND_CONST ( #5579 )
2023-10-20 21:22:06 +02:00
b61feaf77f
Fix syntaxError with const lambda (refs #11275 ) ( #5571 )
2023-10-20 15:32:46 +02:00
0070a78101
Fix #12088 FP constStatement with delete in loop increment ( #5576 )
2023-10-20 10:25:31 +02:00
17ea101e7b
Fix #12081 (Tokenizer::simplifyTypedef: Handle volatile structs better) ( #5577 )
2023-10-19 21:02:03 +02:00
f2c8153231
Set the lower and upper bounds for variable that are only incremented or decremented ( #5523 )
...
Also, changed `isExpressionChanged` and `isThisChanged` to return the
token that is being modified and renamed the functions to
`findExpressionChanged` and `findThisChanged`.
2023-10-19 18:42:52 +02:00
7c3ae68e4d
Fix #11893 FP constStatement unused variable ( #5567 )
2023-10-19 10:51:16 +02:00
e1a120e6b0
Partial fix for 12031: False positive: uninitialized variable ( #5573 )
2023-10-18 23:49:22 +02:00
09f426d980
Fix #12082 FP uninitvar for assignment to array member in conditional ( #5570 )
2023-10-18 18:50:49 +02:00
285ef96b5b
Report unknownMacro in string concatenation (refs #11378 ) ( #5558 )
2023-10-18 18:46:47 +02:00
b60b374f9c
Fix internalASTError with decltype (regression, refs #11378 ) ( #5564 )
2023-10-18 12:17:20 +02:00
b40d36a09e
fixed #12063 - use less heavy code in executor tests ( #5566 )
...
The allocation invokes some heavy ValueFlow computations. We just want
to generate an unconditional error from the analysis so use some lighter
code which does the same.
`TestThreadExecutorFiles::deadlock_with_many_errors`
Before:
```
real 0m23.517s
user 0m33.453s
sys 0m2.297s
```
After:
```
real 0m5.051s
user 0m6.234s
sys 0m0.422s
```
2023-10-17 20:24:37 +02:00
85fe627c68
fixed some typos ( #5562 )
2023-10-17 18:32:07 +02:00
dd76504f82
Fixed #3537 (Allow inline suppression comments for macros) ( #5559 )
2023-10-16 19:43:15 +02:00
3811d01498
fixed "Redundant dereferencing and tasking address expression" Rider warnings ( #5563 )
2023-10-16 14:09:03 +02:00
5e89eb05a6
iwyu.yml: made `include-what-you-use` output more verbose / cleaned up includes ( #5540 )
2023-10-16 12:57:49 +02:00
93297727ef
Fix internalASTError with decltype (refs #11378 ) ( #5553 )
2023-10-15 20:47:01 +02:00
16c5a11786
posix.cfg: Warn in case the return value of localtime() is ignored. ( #5555 )
2023-10-14 16:59:42 +02:00
903df84ddc
Fix #12072 FN constStatement with enum ( #5554 )
2023-10-13 21:40:47 +02:00
ec15772381
Refactoring suppressions code. ( #5550 )
2023-10-13 19:57:08 +02:00
efd488b519
Partial fix for #12062 FN: memleak ( #5548 )
2023-10-13 18:47:06 +02:00
f56677a99d
Fix #11857 FP constParameterReference with std::map ( #5551 )
2023-10-13 18:08:40 +02:00
ebb877adcc
gui/platforms.h: renamed `Platform` to `PlatformData` / Platform: removed unnecessary `cppcheck` namespace ( #5545 )
2023-10-13 16:02:04 +02:00
44ab976451
Inline suppression for block of code or whole file ( #5402 )
...
Added new suppress comments:
- `cppcheck-suppress-begin` and `cppcheck-suppress-end` to remove blocks
of suppression
- `cppcheck-suppress-file` to remove suppression at file level
The suppressions do not interfere with each others. For example, all the
suppressions are matched in the following code:
```c
// cppcheck-suppress-file uninitvar
void f() {
int a;
// cppcheck-suppress-begin uninitvar
// cppcheck-suppress uninitvar
a++;
// cppcheck-suppress-end uninitvar
}
```
Tickets:
https://trac.cppcheck.net/ticket/11902
https://trac.cppcheck.net/ticket/8528
2023-10-13 12:45:13 +02:00
8ef4da475a
Add test for #2456 , #12011 ( #5544 )
2023-10-12 16:27:10 +02:00
9d4e3829c2
Partial fix #12030 (False positive: uninitialized variable, conditional modification, flag) ( #5543 )
2023-10-12 13:56:47 +02:00
8c0d43d928
removed unnecessary encapsulation of severity enum and made it an `enum class` ( #5541 )
2023-10-12 11:58:39 +02:00
179d26f06b
Fix #12064 FP useStlAlgorithm with loop over initializer list ( #5542 )
2023-10-12 10:06:52 +02:00
e247e818ec
Fix #12052 FP: containerOutOfBounds ( #5534 )
2023-10-11 14:08:17 +02:00
7393083d5d
added `CmdLineLogger::printRaw()` / CppCheckExecutor: more `CmdLineLogger` usage ( #5537 )
2023-10-09 22:22:39 +02:00
cc92b09ec1
fixed #12016 - ProcessExecutor: added missing invocation of clang-tidy ( #5529 )
...
No changes in tests since the intercepted invocation function in called
in a forked process. The clang-tidy integration is also broken.
2023-10-09 12:26:58 +02:00
06b5ef1e4d
cleaned up includes based on include-what-you-use ( #5532 )
2023-10-09 10:07:20 +02:00
0f28f3e493
generate `AddonInfo` only once ( #4958 )
...
Currently the `AddonInfo` is generated and discarded on each addon
invocation. This leads to an unnecessary process invocation for each
addon on each file.
Also if an addon is completely broken we will still perform the whole
analysis only for it to be failed at the end so we should bail out early
if we know it doesn't work at all.
2023-10-08 21:28:57 +02:00
960e8bb4ea
testrunner: got rid of some redundant preprocessing code / added some missing asserts ( #5521 )
...
This consolidates the stray invocations of preprocessing.
2023-10-08 11:29:52 +02:00
a22c181553
fixed "Redundant elaborated type specifier" Rider warnings ( #5517 )
2023-10-08 09:10:17 +02:00
3ba53c6b6a
fixed #12022 - disallow using `--project` with source files ( #5515 )
2023-10-08 09:07:15 +02:00
8dee551cad
added testing of clang-tidy invocation to executor tests / also some cleanups ( #5514 )
2023-10-08 09:06:02 +02:00
eb076d877b
Improve testcases for unsigned char platforms ( #5524 )
...
I got error messages while building `cppcheck 2.12.0` for RISC-V Arch
Linux:
```
Testing Complete
Number of tests: 4420
Number of todos: 331
Tests failed: 2
/usr/src/debug/cppcheck/cppcheck/test/testcondition.cpp:4501(TestCondition::alwaysTrue): Assertion failed.
Expected:
[test.cpp:6]: (style) Condition 'o[1]=='\0'' is always false\n
Actual:
[test.cpp:4] -> [test.cpp:6]: (style) Condition 'o[1]=='\0'' is always false\n
_____
/usr/src/debug/cppcheck/cppcheck/test/testcondition.cpp:5014(TestCondition::alwaysTrueContainer): Assertion failed.
Expected:
[test.cpp:5]: (style) Condition 'buffer.back()=='\0'' is always false\n
Actual:
[test.cpp:3] -> [test.cpp:5]: (style) Condition 'buffer.back()=='\0'' is always false\n
```
I found out the reason is that the testcases were designed for
x86/x86_64 or other `signed char` platforms (i.e. default character type
is `signed char` ), whereareas RISC-V is an `unsigned char` platform,
which causes different behavior in
`lib/valueflow.cpp:valueFlowImpossibleValues`. I'm not sure whether this
error leads from a functional bug, so if you have a better approach to
fix it, please let me know.
Maybe you could reproduce this error on x86_64 platform by setting
`defaultSign = 'u';` in `Platform::set(Type t)`.
2023-10-07 23:04:57 +02:00
e9c39c124a
windows.cfg: Fix wrong FlushConsoleInputBuffer configuration ( #5526 )
...
After flushing, the function returns. Before it was configured to
not-return.
A proper regression test was added.
2023-10-07 20:05:43 +02:00
d48df980b4
Fix 12030: False positive: uninitialized variable, conditional modification, flag ( #5520 )
2023-10-07 14:01:06 +02:00
1d30b617c1
windows.cfg: Fixed wrong configuration of GetModuleHandle(A|W)-functions ( #5525 )
...
This fixes a FP: `Variable 'path' can be declared as const array
[constVariable]`
The reason was the wrong direction attribute of GetModuleHandle()
2023-10-07 13:59:01 +02:00
903eccb336
Fix #12039 FP knownConditionTrueFalse ( #5513 )
2023-10-06 09:53:24 +02:00
5a52fa80fb
refs #12022 - disallow multiple `--project` options ( #5499 )
2023-10-05 21:36:44 +02:00
fe8730cf0f
MathLib: renamed `to{U}LongNumber()` to `toBig{U}Number()` ( #5503 )
...
The name was misleading as it was actually a `long long` and also if we
ever move to an (optional) 128-bit value it wouldn't even less fitting.
We should name it to match our alias type.
2023-10-05 19:21:42 +02:00
fc700b68eb
refs #4452 / refs #11705 - improved `--showtime=` behavior and testing ( #4876 )
...
This is a step onto leveraging the `ThreadExecutor` implementation for
`ProcessExecutor` which is a follow-up to #4870 . We need to have the
proper test coverage and the existing implementations working as
expected before we move to the shared code.
Fixes:
- added `--showtime=` tests for all executor implementations
- only print `--showtime=summary` once at the end
- prevents `--showtime=` by multiple threads to be written at the same
time - essentially breaking the output
- reset the timer results before each test
- deprecated `top5` in favor of `top5_file`
- fixed printing for all executors except `ProcessExecutor`
2023-10-05 19:04:06 +02:00
787da43dc9
Fix #12036 FN knownConditionTrueFalse comparing enum with number ( #5510 )
2023-10-05 18:15:18 +02:00
a52d2a23a0
Fix #12018 (False positive: null pointer, multiple arguments) ( #5509 )
2023-10-05 15:08:25 +02:00
d9a8909d2a
Fix #11408 debug: Function::addArguments found argument 't' with varid 0 ( #5507 )
2023-10-05 10:01:46 +02:00
6a8f787915
Fix #12026 (simplifyTypedef: not handled properly when typedef and enum constant has same name) ( #5500 )
2023-10-01 21:26:54 +02:00
6773cdb34b
Fix #12014 syntaxError due to bad typedef simplification ( #5493 )
2023-09-28 19:26:12 +02:00
ed5532c2a7
Fix #12019 (False positive: null pointer, array zero initialization) ( #5495 )
2023-09-28 15:18:08 +02:00
c4fe5ac8b7
Fix #12012 (FP: uninitvar, address of variable is casted to uintptr_t that is passed to function) ( #5494 )
2023-09-28 13:47:11 +02:00
63b76d2266
Fix valueFlowBailoutIncompleteVar with ptr to ptr (refs #10045 ) ( #5488 )
2023-09-28 10:36:18 +02:00
73d305ea46
Fix #12013 crash: crashes in release builds if cppcheck build dir is used ( #5489 )
2023-09-27 16:44:22 +02:00
e928f2b5aa
Fix valueFlowBailoutIncompleteVar with new (refs #10045 ) ( #5487 )
2023-09-26 21:39:07 +02:00
3774d46303
TestCmdlineParser: store messages in logger class instead of utilizing the redirect ( #5482 )
2023-09-26 21:38:15 +02:00
f037edf586
Fix #11440 FN Moved value when using {} to initialize ( #5479 )
2023-09-26 10:04:22 +02:00
9f96803f62
TestCheck: added missing registration ( #5484 )
2023-09-26 10:03:53 +02:00
99e38cf8f8
Partial fix for #10968 FN detect always false/true comparison of function with constant ( #5480 )
2023-09-25 22:18:07 +02:00
3fd00c19df
perform logging in `CmdLineParser` through an interface ( #5478 )
...
This is in preparation of avoiding accessing `std::cout` directly as
well as streamlining and improving the logging during the settings
parsing. There are no functional changes yet.
2023-09-25 13:43:18 +02:00
1959c85e34
test/cli/test-other.py: improved addon tests ( #5469 )
2023-09-25 13:39:17 +02:00
3979ade9ea
got rid of test-only `Library` functions / avoid some more direct modifications of library data structures in test ( #5468 )
2023-09-25 13:37:24 +02:00
bba96c5c8f
Fix valueFlowConditionExpressions bailout for C++ casts (refs #10045 ) ( #5472 )
2023-09-22 18:19:36 +02:00
b745d9ad6e
Fix #12010 Improve unknownMacro message: int ( #5473 )
2023-09-22 10:16:21 +02:00
dc59543348
Fix #12006 Improve unknownMacro message ( #5470 )
2023-09-21 00:28:49 +02:00
57bbb17f3b
Fix #11986 debug: Executable scope 'x' with unknown function. ( #5463 )
2023-09-20 17:18:00 +02:00
dc19916966
Fix valueFlowConditionExpressions bailout for library function (refs #10045 ) ( #5461 )
2023-09-20 15:49:13 +02:00
f49fedb2ad
fixed #11483 (FN unusedFunction for method with inline implementation) ( #5457 )
...
Co-authored-by: chrchr-github <78114321+chrchr-github@users.noreply.github.com>
2023-09-20 14:45:44 +02:00
21e001cd1a
refs #11993 - error out in `TestFileLister::recursiveAddFiles()` instead of looping infinitely when repository root directory is not found ( #5462 )
...
Not a proper fix yet but at least it prevents the hang and gives some
feedback.
2023-09-20 10:49:00 +02:00
a43b55a0ca
Improved addon execution errorhandling ( #5451 )
2023-09-20 10:40:57 +02:00
58a7519cbb
Fix 11992: FN (regression): uninitvar ( #5465 )
2023-09-20 06:43:58 +02:00
c6b3c56174
Improve findEnumerator() (refs #10045 ) ( #5459 )
2023-09-19 11:45:59 +02:00
b6f60ad952
Support importing projects with project-name ( #5456 )
2023-09-18 13:54:20 +02:00
10c1ac977c
Fix findEnumerator() with nested enum (refs #10045 ) ( #5454 )
2023-09-18 12:09:59 +02:00
640b561633
Fix #11995 FP passedByValue when variable is moved from ( #5455 )
2023-09-17 22:32:35 +02:00
0c51977f86
Fix valueFlowBailoutIncompleteVar for cast and template args (refs #10045 ) ( #5452 )
2023-09-16 13:03:14 +02:00
50ba5061c7
Fix #11438 MathLib error on user defined literals ( #5448 )
...
Based on #4701 , #5418
A helper function for the `isdigit()` test should be introduced on the
simplecpp side.
Co-authored-by: gerboengels <github@gerbo.org>
2023-09-15 10:00:00 +02:00
5a21851bb7
Fix #11981 internalAstError with using declaration ( #5446 )
2023-09-14 12:14:08 +02:00
775af5ec70
Add test for simplecpp#314 ( #5438 )
2023-09-14 09:41:39 +02:00
e6632d93e3
Fix 11983: False positive: uninitialized variable ( #5443 )
2023-09-13 23:27:08 +02:00
a1078f446a
Fix 11980: False positive returnDanglingLifetime returning pointer to stack array as std::string (by way of struct return value constructor) ( #5445 )
2023-09-13 21:26:37 +02:00
844ed2bf22
Fix #11421 FP shiftTooManyBits with 64bit enum ( #5406 )
2023-09-13 17:59:47 +02:00
7d1423c5fb
Fix #11975 (SymbolDatabase: findFunction does not find the correct function) ( #5440 )
2023-09-13 13:37:57 +02:00
523c41a60b
Fix #11978 debug: Executable scope 'x' with unknown function. ( #5437 )
2023-09-13 11:39:09 +02:00
98ce46a3e5
fixed #11919 - Removed deprecated command-line options `--template <template>` and `--template-format=<template>` ( #5439 )
2023-09-12 22:46:40 +02:00
18ee859737
Fix #11976 FP incorrectStringBooleanError in assert ( #5415 )
2023-09-12 10:05:51 +02:00
e7dd490fed
adjusted tests to reduce the amount of `friend` declarations necessary ( #5435 )
...
We were calling several interface functions through their inherited
classes instead of using the base classes requiring us to add `friend`
declarations to make the implementations accessible. This adjusts
several of those cases.
2023-09-11 20:26:22 +02:00
1b5b74d1f3
Fix FP knownArgument (f'up to #11927 ) ( #5434 )
2023-09-11 20:02:00 +02:00
c6721688e2
Fix #11929 FP knownPointerToBool with dynamic_cast ( #5416 )
2023-09-11 18:04:36 +02:00
cbbf500cd4
Fix valueFlowBailoutIncompleteVar for init list (refs #10045 ) ( #5433 )
2023-09-11 16:49:39 +02:00
aa281501c9
Fix #11923 FN unreadVariable (regression) ( #5409 )
2023-09-11 11:36:03 +02:00
64cd09ab62
fixed #11917 (Default to `native` platform in Windows builds) ( #5428 )
2023-09-11 11:08:23 +02:00
87719121bd
Fixed #11908 (SymbolDatabase: array not parsed properly 'int (**rs)[32]') ( #5430 )
2023-09-10 20:58:30 +02:00
f9b18bc9d8
Fix FP (regression): Resource handle 'fd' freed twice. [doubleFree] ( #5424 )
2023-09-10 20:32:55 +02:00
91070ca794
utils.h: added `startsWith()` and started using it ( #5381 )
...
This makes the code much more readable. It also makes it less prone to
errors because we do not need to specify the length of the string to
match and the returnvalue is clear.
The code with the bad returnvalue check was never executed and I added a
test to show that.
2023-09-08 19:30:25 +02:00
Oliver Stöneberg
chrchr-github
Daniel Marjamäki
Paul Fultz II
orbitcowboy
Johan Bertrand
moui0
Tomasz Edward Posluszny